Update Remove-SqlDscRole to improve error handling by using ItemNotFoundException

johlju · johlju · commit 7abc53a7d5ec · 2025-10-20T20:21:39.000+02:00
diff --git a/source/Public/Remove-SqlDscRole.ps1 b/source/Public/Remove-SqlDscRole.ps1
@@ -96,9 +96,9 @@ function Remove-SqlDscRole
 
                 $PSCmdlet.ThrowTerminatingError(
                     [System.Management.Automation.ErrorRecord]::new(
-                        [System.InvalidOperationException]::new($errorMessage),
+                        [System.Management.Automation.ItemNotFoundException]::new($errorMessage),
                         'RSDR0001', # cspell: disable-line
-                        [System.Management.Automation.ErrorCategory]::InvalidOperation,
+                        [System.Management.Automation.ErrorCategory]::ObjectNotFound,
                         $Name
                     )
                 )

Original file line number	Diff line number	Diff line change
`@@ -96,9 +96,9 @@ function Remove-SqlDscRole`
`96`	`96`
`97`	`97`	`$PSCmdlet.ThrowTerminatingError(`
`98`	`98`	`[System.Management.Automation.ErrorRecord]::new(`
`99`		`- [System.InvalidOperationException]::new($errorMessage),`
	`99`	`+ [System.Management.Automation.ItemNotFoundException]::new($errorMessage),`
`100`	`100`	`'RSDR0001', # cspell: disable-line`
`101`		`- [System.Management.Automation.ErrorCategory]::InvalidOperation,`
	`101`	`+ [System.Management.Automation.ErrorCategory]::ObjectNotFound,`
`102`	`102`	`$Name`
`103`	`103`	`)`
`104`	`104`	`)`