Enhance error diagnostics in integration tests by re-throwing exceptions on final retry attempt with status code 0

Author: johlju

CHANGELOG.md

@@ -59,7 +59,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Fixed integration tests failing with status code 0 when checking ReportServer
     and Reports site accessibility by adding retry logic (up to 2 minutes) to
     handle timing issues where Reporting Services web services are not immediately
-    ready after DSC configuration completes.
+    ready after DSC configuration completes. On final retry attempt with status
+    code 0, the exception is now re-thrown to provide detailed error diagnostics.
     ([issue #2104](https://github.com/dsccommunity/SqlServerDsc/issues/2104)).
   - Refactored to use the public command `Get-SqlDscServerProtocol` instead
     of the deprecated private function `Get-ServerProtocolObject`

tests/Integration/Resources/DSC_SqlRS.Integration.Tests.ps1

@@ -215,6 +215,12 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
                         Write-Verbose -Message "ReportServer not yet accessible (attempt $attempt of $maxRetries). Waiting $retryIntervalSeconds seconds..." -Verbose
                         Start-Sleep -Seconds $retryIntervalSeconds
                     }
+                    elseif ($webRequestStatusCode -eq 0 -and $attempt -eq $maxRetries)
+                    {
+                        # On the last attempt with status code 0, re-throw to get error details
+                        Write-Verbose -Message "ReportServer still not accessible after $maxRetries attempts. Re-throwing exception for diagnostics." -Verbose
+                        throw $_
+                    }
                     elseif ($webRequestStatusCode -ne 0)
                     {
                         # If we got an actual HTTP error code, break and let the assertion handle it
@@ -271,6 +277,12 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
                         Write-Verbose -Message "Reports site not yet accessible (attempt $attempt of $maxRetries). Waiting $retryIntervalSeconds seconds..." -Verbose
                         Start-Sleep -Seconds $retryIntervalSeconds
                     }
+                    elseif ($webRequestStatusCode -eq 0 -and $attempt -eq $maxRetries)
+                    {
+                        # On the last attempt with status code 0, re-throw to get error details
+                        Write-Verbose -Message "Reports site still not accessible after $maxRetries attempts. Re-throwing exception for diagnostics." -Verbose
+                        throw $_
+                    }
                     elseif ($webRequestStatusCode -ne 0)
                     {
                         # If we got an actual HTTP error code, break and let the assertion handle it

tests/Integration/Resources/DSC_SqlRS_Default.Integration.Tests.ps1

@@ -214,6 +214,12 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
                         Write-Verbose -Message "ReportServer not yet accessible (attempt $attempt of $maxRetries). Waiting $retryIntervalSeconds seconds..." -Verbose
                         Start-Sleep -Seconds $retryIntervalSeconds
                     }
+                    elseif ($webRequestStatusCode -eq 0 -and $attempt -eq $maxRetries)
+                    {
+                        # On the last attempt with status code 0, re-throw to get error details
+                        Write-Verbose -Message "ReportServer still not accessible after $maxRetries attempts. Re-throwing exception for diagnostics." -Verbose
+                        throw $_
+                    }
                     elseif ($webRequestStatusCode -ne 0)
                     {
                         # If we got an actual HTTP error code, break and let the assertion handle it
@@ -270,6 +276,12 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
                         Write-Verbose -Message "Reports site not yet accessible (attempt $attempt of $maxRetries). Waiting $retryIntervalSeconds seconds..." -Verbose
                         Start-Sleep -Seconds $retryIntervalSeconds
                     }
+                    elseif ($webRequestStatusCode -eq 0 -and $attempt -eq $maxRetries)
+                    {
+                        # On the last attempt with status code 0, re-throw to get error details
+                        Write-Verbose -Message "Reports site still not accessible after $maxRetries attempts. Re-throwing exception for diagnostics." -Verbose
+                        throw $_
+                    }
                     elseif ($webRequestStatusCode -ne 0)
                     {
                         # If we got an actual HTTP error code, break and let the assertion handle it
@@ -446,6 +458,12 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
                         Write-Verbose -Message "ReportServer not yet accessible (attempt $attempt of $maxRetries). Waiting $retryIntervalSeconds seconds..." -Verbose
                         Start-Sleep -Seconds $retryIntervalSeconds
                     }
+                    elseif ($webRequestStatusCode -eq 0 -and $attempt -eq $maxRetries)
+                    {
+                        # On the last attempt with status code 0, re-throw to get error details
+                        Write-Verbose -Message "ReportServer still not accessible after $maxRetries attempts. Re-throwing exception for diagnostics." -Verbose
+                        throw $_
+                    }
                     elseif ($webRequestStatusCode -ne 0)
                     {
                         # If we got an actual HTTP error code, break and let the assertion handle it
@@ -502,6 +520,12 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2016',
                         Write-Verbose -Message "Reports site not yet accessible (attempt $attempt of $maxRetries). Waiting $retryIntervalSeconds seconds..." -Verbose
                         Start-Sleep -Seconds $retryIntervalSeconds
                     }
+                    elseif ($webRequestStatusCode -eq 0 -and $attempt -eq $maxRetries)
+                    {
+                        # On the last attempt with status code 0, re-throw to get error details
+                        Write-Verbose -Message "Reports site still not accessible after $maxRetries attempts. Re-throwing exception for diagnostics." -Verbose
+                        throw $_
+                    }
                     elseif ($webRequestStatusCode -ne 0)
                     {
                         # If we got an actual HTTP error code, break and let the assertion handle it