Add ErrorAction parameter to Connect-SqlDscDatabaseEngine and Disconnect-SqlDscDatabaseEngine for improved error handling

johlju · johlju · commit 8ac28ba9f08a · 2025-10-27T18:43:50.000+01:00
diff --git a/tests/Integration/Commands/Get-SqlDscCompatibilityLevel.Integration.Tests.ps1 b/tests/Integration/Commands/Get-SqlDscCompatibilityLevel.Integration.Tests.ps1
@@ -40,11 +40,11 @@ Describe 'Get-SqlDscCompatibilityLevel' -Tag @('Integration_SQL2017', 'Integrati
 
         $script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)
 
-        $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential
+        $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'
     }
 
     AfterAll {
-        Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject
+        Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject -ErrorAction 'Stop'
     }
 
     Context 'When getting compatibility levels' {

Original file line number	Diff line number	Diff line change
`@@ -40,11 +40,11 @@ Describe 'Get-SqlDscCompatibilityLevel' -Tag @('Integration_SQL2017', 'Integrati`
`40`	`40`
`41`	`41`	`$script:mockSqlAdminCredential = [System.Management.Automation.PSCredential]::new($mockSqlAdministratorUserName, $mockSqlAdministratorPassword)`
`42`	`42`
`43`		`- $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential`
	`43`	`+ $script:serverObject = Connect-SqlDscDatabaseEngine -InstanceName $script:mockInstanceName -Credential $script:mockSqlAdminCredential -ErrorAction 'Stop'`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`AfterAll {`
`47`		`- Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject`
	`47`	`+ Disconnect-SqlDscDatabaseEngine -ServerObject $script:serverObject -ErrorAction 'Stop'`
`48`	`48`	`}`
`49`	`49`
`50`	`50`	`Context 'When getting compatibility levels' {`