New-SqlDscRole: Fix verbose output (#2359)

Author: johlju

CHANGELOG.md

@@ -38,6 +38,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Fixed parameter types for boolean database properties from `System.Boolean` to
     `System.Management.Automation.SwitchParameter` to follow PowerShell best practices.
     ([issue #2190](https://github.com/dsccommunity/SqlServerDsc/issues/2190)).
+- `New-SqlDscRole`
+  - Fixed duplicate verbose output by removing manual `Write-Verbose` call, as
+    `$PSCmdlet.ShouldProcess()` already generates appropriate verbose output
+    ([issue #2156](https://github.com/dsccommunity/SqlServerDsc/issues/2156)).
 - `Set-SqlDscDatabaseProperty`
   - Fixed parameter types for database-scoped configuration properties from
     `System.Boolean` to `Microsoft.SqlServer.Management.Smo.DatabaseScopedConfigurationOnOff`

source/Public/New-SqlDscRole.ps1

@@ -93,8 +93,6 @@ function New-SqlDscRole
             $ServerObject.Roles.Refresh()
         }
 
-        Write-Verbose -Message ($script:localizedData.Role_Create -f $Name, $ServerObject.InstanceName)
-
         # Check if the role already exists
         if ($ServerObject.Roles[$Name])
         {

source/en-US/SqlServerDsc.strings.psd1

@@ -317,7 +317,6 @@ ConvertFrom-StringData @'
     Get_SqlDscRole_NotFound = Server role '{0}' was not found. (GSDR0001)
 
     ## New-SqlDscRole
-    Role_Create = Creating server role '{0}' on instance '{1}'.
     Role_CreateFailed = Failed to create server role '{0}' on instance '{1}'.
     Role_AlreadyExists = Server role '{0}' already exists on instance '{1}'.
     Role_Create_ShouldProcessDescription = Creating the server role '{0}' on the instance '{1}'.