Clarify return usage with Write-Error and fix markdown table formatting

Co-authored-by: johlju <[email protected]>

Author: Copilot

.github/instructions/dsc-community-style-guidelines-powershell.instructions.md

@@ -96,7 +96,7 @@ applyTo: "{**/*.ps1,**/*.psm1,**/*.psd1}"
   - For non-terminating errors: Omit `-ErrorAction` parameter (caller controls via `-ErrorAction`)
   - Always include `-Message` (localized string), `-Category` (relevant error category), `-ErrorId` (unique ID matching localized string ID), `-TargetObject` (object causing error)
   - In catch blocks, pass original exception using `-Exception`
-  - Always use `return` after `Write-Error` to avoid further processing
+  - Use `return` only after non-terminating `Write-Error` to stop further processing. Omit `return` when using `-ErrorAction 'Stop'`.
 - **Never use `$PSCmdlet.ThrowTerminatingError()` in public commands** - it creates command-terminating (not script-terminating) errors; use `Write-Error` with `-ErrorAction 'Stop'` instead
   - May be used in private functions where behavior is understood by internal callers
 - **Never use `throw` in public commands** except in `[ValidateScript()]` parameter validation attributes (it's the only valid mechanism there)

CONTRIBUTING.md

@@ -353,9 +353,9 @@ $db = Get-Database -Name 'NonExistent' -ErrorAction 'Stop'
 ```
 
 > [!IMPORTANT]
-> Always use `return` after `Write-Error` to prevent further processing in the
-> command. Without `return`, the command continues executing, which may cause
-> unexpected behavior or additional errors.
+> Use `return` after `Write-Error` only for non-terminating errors (no `-ErrorAction 'Stop'`)
+> to stop further processing in the current function. Omit `return` when using
+> `-ErrorAction 'Stop'`, as execution stops automatically.
 
 ##### Error Handling in Public Commands
 
@@ -374,8 +374,6 @@ function Get-Database
             -ErrorId 'GD0001' `
             -TargetObject $Name `
             -ErrorAction 'Stop'
-        
-        return
     }
 
     # Continue processing...
@@ -507,14 +505,12 @@ $results = $items | Process-Items -ErrorAction 'Stop'
 
 ##### Summary
 
-<!-- markdownlint-disable MD013 - Line length -->
 | Scenario | Use | Notes |
-|----------|-----|-------|
+| --- | --- | --- |
 | Terminating errors in public commands | `Write-Error` with `-ErrorAction 'Stop'` | Simple and standard PowerShell behavior |
 | Non-terminating errors in public commands | `Write-Error` without `-ErrorAction` | Allows caller to control termination via `-ErrorAction` |
 | Pipeline processing with multiple items | `Write-Error` without `-ErrorAction` | Allows processing to continue for remaining items |
 | Catching .NET method exceptions | try-catch with `Write-Error` | .NET exceptions are always caught automatically |
 | Parameter validation in `[ValidateScript()]` | `throw` | Only valid option within validation attributes |
 | Private functions (internal use only) | `Write-Error` or `$PSCmdlet.ThrowTerminatingError()` | Behavior is understood by internal callers |
 | Public commands | Never use `throw` or `$PSCmdlet.ThrowTerminatingError()` | Use `Write-Error` instead |
-<!-- markdownlint-enable MD013 - Line length -->