Address code review feedback: remove ValueFromPipelineByPropertyName, use Should -Invoke assertions, and remove redundant tests

Co-authored-by: johlju <[email protected]>

Author: Copilot

source/Public/Test-SqlDscIsLoginEnabled.ps1

@@ -76,7 +76,7 @@ function Test-SqlDscIsLoginEnabled
         [Microsoft.SqlServer.Management.Smo.Login]
         $LoginObject,
 
-        [Parameter(ParameterSetName = 'ServerObject', Mandatory = $true, ValueFromPipelineByPropertyName = $true)]
+        [Parameter(ParameterSetName = 'ServerObject', Mandatory = $true)]
         [System.String]
         $Name,
 

tests/Unit/Public/Disable-SqlDscLogin.Tests.ps1

@@ -177,19 +177,17 @@ Describe 'Disable-SqlDscLogin' -Tag 'Public' {
             } -Force
 
             Mock -CommandName Get-SqlDscLogin -MockWith {
-                $script:mockGetSqlDscLoginWasRun += 1
                 return @($mockLoginObject)
             }
         }
 
         It 'Should call the correct methods and not invoke Get-SqlDscLogin' {
             $script:mockMethodDisableWasRun = 0
-            $script:mockGetSqlDscLoginWasRun = 0
 
             Disable-SqlDscLogin -LoginObject $mockLoginObject -Force
 
             $script:mockMethodDisableWasRun | Should -Be 1
-            $script:mockGetSqlDscLoginWasRun | Should -Be 0
+            Should -Invoke -CommandName Get-SqlDscLogin -Exactly -Times 0 -Scope It
         }
 
         It 'Should not call Disable method when using WhatIf' {

tests/Unit/Public/Enable-SqlDscLogin.Tests.ps1

@@ -177,19 +177,17 @@ Describe 'Enable-SqlDscLogin' -Tag 'Public' {
             } -Force
 
             Mock -CommandName Get-SqlDscLogin -MockWith {
-                $script:mockGetSqlDscLoginWasRun += 1
                 return @($mockLoginObject)
             }
         }
 
         It 'Should call the correct methods and not invoke Get-SqlDscLogin' {
             $script:mockMethodEnableWasRun = 0
-            $script:mockGetSqlDscLoginWasRun = 0
 
             Enable-SqlDscLogin -LoginObject $mockLoginObject -Force
 
             $script:mockMethodEnableWasRun | Should -Be 1
-            $script:mockGetSqlDscLoginWasRun | Should -Be 0
+            Should -Invoke -CommandName Get-SqlDscLogin -Exactly -Times 0 -Scope It
         }
 
         It 'Should not call Enable method when using WhatIf' {

tests/Unit/Public/Test-SqlDscIsLoginEnabled.Tests.ps1

@@ -91,11 +91,6 @@ Describe 'Test-SqlDscIsLoginEnabled' -Tag 'Public' {
         ($parameterInfo.Attributes.ValueFromPipeline -or $parameterInfo.Attributes.ValueFromPipelineByPropertyName) | Should -BeTrue
     }
 
-    It 'Should have Name parameter accept pipeline input by property name' {
-        $parameterInfo = (Get-Command -Name 'Test-SqlDscIsLoginEnabled').Parameters['Name']
-        $parameterInfo.Attributes.ValueFromPipelineByPropertyName | Should -BeTrue
-    }
-
     It 'Should have LoginObject parameter accept pipeline input' {
         $parameterInfo = (Get-Command -Name 'Test-SqlDscIsLoginEnabled').Parameters['LoginObject']
         ($parameterInfo.Attributes.ValueFromPipeline -or $parameterInfo.Attributes.ValueFromPipelineByPropertyName) | Should -BeTrue
@@ -169,24 +164,6 @@ Describe 'Test-SqlDscIsLoginEnabled' -Tag 'Public' {
                 } -Exactly -Times 1 -Scope It
             }
         }
-
-        Context 'When the login cannot be resolved' {
-            BeforeAll {
-                Mock -CommandName Get-SqlDscLogin -MockWith {
-                    # Simulate Get-SqlDscLogin behavior when login is not found with ErrorAction Stop
-                    $PSCmdlet.ThrowTerminatingError((New-Object System.Management.Automation.ErrorRecord ([System.Exception]"Login 'NonExistentLogin' does not exist."), 'GSDL0001', [System.Management.Automation.ErrorCategory]::ObjectNotFound, 'NonExistentLogin'))
-                }
-            }
-
-            It 'Should handle error when login is not found' {
-                # The behavior will depend on ErrorAction preference - with 'Stop' it should throw
-                { Test-SqlDscIsLoginEnabled -ServerObject $mockServerObject -Name 'NonExistentLogin' } | Should -Throw
-
-                Should -Invoke -CommandName Get-SqlDscLogin -ParameterFilter {
-                    $ServerObject -eq $mockServerObject -and $Name -eq 'NonExistentLogin'
-                } -Exactly -Times 1 -Scope It
-            }
-        }
     }
 
     Context 'When using parameter set LoginObject' {