Skip to content

Commit b67f844

Browse files
committed
Refactor error messages in Remove-SqlDscDatabase tests for consistency and clarity
1 parent 99f3e18 commit b67f844

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

tests/Unit/Public/Remove-SqlDscDatabase.Tests.ps1

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,13 +80,21 @@ Describe 'Remove-SqlDscDatabase' -Tag 'Public' {
8080
}
8181

8282
It 'Should throw error when database does not exist' {
83+
$expectedMessage = InModuleScope -ScriptBlock {
84+
$script:localizedData.Remove_SqlDscDatabase_NotFound -f 'NonExistentDatabase'
85+
}
86+
8387
{ Remove-SqlDscDatabase -ServerObject $mockServerObject -Name 'NonExistentDatabase' -Force } |
84-
Should -Throw -ExpectedMessage '*not found*'
88+
Should -Throw -ExpectedMessage ('*{0}*' -f $expectedMessage) -ErrorId 'RSDD0002,Remove-SqlDscDatabase'
8589
}
8690

8791
It 'Should throw error when trying to remove system database' {
92+
$expectedMessage = InModuleScope -ScriptBlock {
93+
$script:localizedData.Database_CannotRemoveSystem -f 'master'
94+
}
95+
8896
{ Remove-SqlDscDatabase -ServerObject $mockServerObject -Name 'master' -Force } |
89-
Should -Throw -ExpectedMessage '*Cannot remove system database*' -ErrorId 'RSDD0001,Remove-SqlDscDatabase'
97+
Should -Throw -ExpectedMessage ('*{0}*' -f $expectedMessage) -ErrorId 'RSDD0001,Remove-SqlDscDatabase'
9098
}
9199
}
92100

@@ -121,8 +129,12 @@ Describe 'Remove-SqlDscDatabase' -Tag 'Public' {
121129
return $mockParent
122130
} -Force
123131

132+
$expectedMessage = InModuleScope -ScriptBlock {
133+
$script:localizedData.Database_CannotRemoveSystem -f 'master'
134+
}
135+
124136
{ Remove-SqlDscDatabase -DatabaseObject $mockSystemDatabaseObject -Force } |
125-
Should -Throw -ExpectedMessage '*Cannot remove system database*' -ErrorId 'RSDD0001,Remove-SqlDscDatabase'
137+
Should -Throw -ExpectedMessage ('*{0}*' -f $expectedMessage) -ErrorId 'RSDD0001,Remove-SqlDscDatabase'
126138
}
127139
}
128140

0 commit comments

Comments
 (0)