Validate usage of StopAtMarkAfterDate and StopBeforeMarkAfterDate parameters in Restore-SqlDscDatabase

Author: johlju

source/Public/Restore-SqlDscDatabase.ps1

@@ -368,7 +368,9 @@ function Restore-SqlDscDatabase
                 NotAllowedList = @(
                     'ToPointInTime'
                     'StopAtMarkName'
+                    'StopAtMarkAfterDate'
                     'StopBeforeMarkName'
+                    'StopBeforeMarkAfterDate'
                 )
                 IfParameterPresent = @{
                     RestoreType = $RestoreType
@@ -378,6 +380,23 @@ function Restore-SqlDscDatabase
             Assert-BoundParameter @assertBoundParameterParameters
         }
 
+        # Validate that AfterDate parameters are only used with their corresponding mark name parameters
+        $assertBoundParameterParameters = @{
+            BoundParameterList = $PSBoundParameters
+            RequiredParameter = @('StopAtMarkName')
+            IfParameterPresent = @('StopAtMarkAfterDate')
+        }
+
+        Assert-BoundParameter @assertBoundParameterParameters
+
+        $assertBoundParameterParameters = @{
+            BoundParameterList = $PSBoundParameters
+            RequiredParameter = @('StopBeforeMarkName')
+            IfParameterPresent = @('StopBeforeMarkAfterDate')
+        }
+
+        Assert-BoundParameter @assertBoundParameterParameters
+
         $descriptionMessage = $script:localizedData.Restore_SqlDscDatabase_ShouldProcessVerboseDescription -f $restoreTypeDescription, $Name, $BackupFile, $ServerObject.InstanceName
         $confirmationMessage = $script:localizedData.Restore_SqlDscDatabase_ShouldProcessVerboseWarning -f $restoreTypeDescription, $Name
         $captionMessage = $script:localizedData.Restore_SqlDscDatabase_ShouldProcessCaption

tests/Unit/Public/Restore-SqlDscDatabase.Tests.ps1

@@ -140,6 +140,26 @@ Describe 'Restore-SqlDscDatabase' -Tag 'Public' {
             { Restore-SqlDscDatabase -ServerObject $mockServerObject -Name 'TestDatabase' -BackupFile 'C:\Backups\Test.bak' -RestoreType 'Files' -StopBeforeMarkName 'MyMark' -Force } |
                 Should -Throw -ExpectedMessage "*The parameter(s) 'StopBeforeMarkName' are not allowed to be specified*" -ErrorId 'Parameters,New-ArgumentException'
         }
+
+        It 'Should throw error when StopAtMarkAfterDate is used with Full restore' {
+            { Restore-SqlDscDatabase -ServerObject $mockServerObject -Name 'TestDatabase' -BackupFile 'C:\Backups\Test.bak' -RestoreType 'Full' -StopAtMarkAfterDate '2024-01-15T14:30:00' -Force } |
+                Should -Throw -ExpectedMessage "*The parameter(s) 'StopAtMarkAfterDate' are not allowed to be specified*" -ErrorId 'Parameters,New-ArgumentException'
+        }
+
+        It 'Should throw error when StopBeforeMarkAfterDate is used with Differential restore' {
+            { Restore-SqlDscDatabase -ServerObject $mockServerObject -Name 'TestDatabase' -BackupFile 'C:\Backups\Test.bak' -RestoreType 'Differential' -StopBeforeMarkAfterDate '2024-01-15T14:30:00' -Force } |
+                Should -Throw -ExpectedMessage "*The parameter(s) 'StopBeforeMarkAfterDate' are not allowed to be specified*" -ErrorId 'Parameters,New-ArgumentException'
+        }
+
+        It 'Should throw error when StopAtMarkAfterDate is used without StopAtMarkName' {
+            { Restore-SqlDscDatabase -ServerObject $mockServerObject -Name 'TestDatabase' -BackupFile 'C:\Backups\Test.trn' -RestoreType 'Log' -StopAtMarkAfterDate '2024-01-15T14:30:00' -Force } |
+                Should -Throw -ExpectedMessage "*'StopAtMarkName'*must*all be specified*" -ErrorId 'ARCP0001,Assert-RequiredCommandParameter'
+        }
+
+        It 'Should throw error when StopBeforeMarkAfterDate is used without StopBeforeMarkName' {
+            { Restore-SqlDscDatabase -ServerObject $mockServerObject -Name 'TestDatabase' -BackupFile 'C:\Backups\Test.trn' -RestoreType 'Log' -StopBeforeMarkAfterDate '2024-01-15T14:30:00' -Force } |
+                Should -Throw -ExpectedMessage "*'StopBeforeMarkName'*must*all be specified*" -ErrorId 'ARCP0001,Assert-RequiredCommandParameter'
+        }
     }
 
     Context 'When performing successful restores' {