Fix integ test and changelog

Author: johlju

CHANGELOG.md

@@ -11,26 +11,25 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Removed the function `Get-RegistryPropertyValue` and `Format-Path` in
     favor of the commands with the same names in the module _DscResource.Common_.
 - SqlRSSetup
-  - The DSC resource has been refactored into a class-based resource
-    - The parameter `SourcePath` was removed and replaced with `MediaPath`
-    - The parameter `IAcceptLicensTerms` was removed and replaced with a
-      boolean parameter `AcceptLicensingTerms`
+  - The DSC resource has been refactored into a class-based resource.
+    - The parameter `SourcePath` was replaced with `MediaPath`.
+    - The parameter `IAcceptLicensTerms` was replaced with a boolean parameter
+      `AcceptLicensingTerms`.
     - The parameter `SourceCredential` was removed. Because of this, the
       functionality that allowed copying the media from a UNC path using
       those credentials was also removed. If this was something you used,
       please open an issue.
     - The version validation no longer gets the current version from the
       installed package (using `Get-Package`), but instead from the registry.
-    - The read-only property `CurrentVersion` was removed and replaced with
-      the more appropriate property `ProductVersion`.
     - Prior when install was successful, the resource checked whether there
       were any pending rename operations. Since the install returns 3010
       if a restart is needed it is now assumed that the setup process takes
       care of this. If that is not the case, and this check is needed, then
       open an issue to discuss in what cases this is needed.
-    - The `Edition` value 'Development` was removed and replaced by the value
+    - The `Edition` option 'Development` was replaced by the value
       `Developer`.
-    - The read-only properties `ServiceName` and `ErrorDumpDirectory` was removed.
+    - The read-only properties `CurrentVersion`, `ServiceName` and `ErrorDumpDirectory`
+      were removed.
 
 ### Added
 
@@ -92,14 +91,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
     the module manifest.
   - Now integration tests will fail on an exception when the command `Test-DscConfiguration`
     is run.
-  - Added Test-SqlDscIsRole to be used like Test-SqlDscIsLogin but tests for a server role as principal.
+  - Added Test-SqlDscIsRole to be used like Test-SqlDscIsLogin but tests
+    for a server role as principal.
 - SqlSetup
   - Fixed issue with AddNode where cluster IP information was not being passed to
     setup.exe ([issue #1171](https://github.com/dsccommunity/SqlServerDsc/issues/1171)).
 - SqlRSSetup
   - The DSC resource has been refactored into a class-based resource.
 
-
 ### Fixed
 
 - Fixed workaround for the GitHub Actions to support building module in Windows

tests/Integration/Resources/DSC_SqlRSSetup.Integration.Tests.ps1

@@ -178,46 +178,11 @@ Describe "$($script:dscResourceName)_Integration" -Tag @('Integration_SQL2017',
                     -and $_.ResourceId -eq $resourceId
             }
 
+            ## Uncomment this line to see the registry key values.
+            #Write-Verbose -Message ((reg query "HKLM\SOFTWARE\Microsoft\Microsoft SQL Server" /s) | Out-String) -Verbose
+
             $resourceCurrentState.InstanceName | Should -Be $ConfigurationData.AllNodes.InstanceName
             $resourceCurrentState.InstallFolder | Should -Be $ConfigurationData.AllNodes.InstallFolder
-
-            if (Test-ContinuousIntegrationTaskCategory -Category 'Integration_SQL2017')
-            {
-                ## Uncomment this line to see the registry key values.
-                #Write-Verbose -Message ((reg query "HKLM\SOFTWARE\Microsoft\Microsoft SQL Server" /s) | Out-String) -Verbose
-
-                <#
-                    THIS HAS BEEN COMMENTED FROM THE TEST BECAUSE IT IS NOT WORKING PROPERLY.
-                    Maybe due to setup exiting with 3010 (reboot required) and the
-                    registry key not being set yet. Or maybe due to the fact that
-                    the setup does not add a product version.
-                #>
-                #$resourceCurrentState.ProductVersion | Should -BeGreaterOrEqual ([System.Version] '14.0.0.0')
-            }
-
-            if (Test-ContinuousIntegrationTaskCategory -Category 'Integration_SQL2019')
-            {
-                ## Uncomment this line to see the registry key values.
-                #Write-Verbose -Message ((reg query "HKLM\SOFTWARE\Microsoft\Microsoft SQL Server" /s) | Out-String) -Verbose
-
-                $resourceCurrentState.ProductVersion | Should -BeGreaterOrEqual ([System.Version] '15.0.0.0')
-            }
-
-            if (Test-ContinuousIntegrationTaskCategory -Category 'Integration_SQL2022')
-            {
-                ## Uncomment this line to see the registry key values.
-                #Write-Verbose -Message ((reg query "HKLM\SOFTWARE\Microsoft\Microsoft SQL Server" /s) | Out-String) -Verbose
-
-                $resourceCurrentState.ProductVersion | Should -BeGreaterOrEqual ([System.Version] '16.0.0.0')
-            }
-
-            if (Test-ContinuousIntegrationTaskCategory -Category 'Integration_PowerBI')
-            {
-                ## Uncomment this line to see the registry key values.
-                #Write-Verbose -Message ((reg query "HKLM\SOFTWARE\Microsoft\Microsoft SQL Server" /s) | Out-String) -Verbose
-
-                $resourceCurrentState.ProductVersion | Should -BeGreaterOrEqual ([System.Version] '1.22.9153.7886')
-            }
         }
 
         It 'Should return $true when Test-DscConfiguration is run' {