Refactor mocks in New-SqlDscDatabaseSnapshot.Tests to use New-Object for correct type instantiation and improve clarity

Author: johlju

tests/Unit/Public/New-SqlDscDatabaseSnapshot.Tests.ps1

@@ -100,11 +100,10 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             # Mock New-SqlDscDataFile and New-SqlDscFileGroup to avoid type conflicts
             # between test scope and module scope for PowerShell class types.
+            # Use InModuleScope to access the module's class types directly.
             Mock -CommandName 'New-SqlDscDataFile' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $FileName)
-
-                    [DatabaseFileSpec]@{
+                    New-Object -TypeName 'DatabaseFileSpec' -Property @{
                         Name = $Name
                         FileName = $FileName
                     }
@@ -116,9 +115,7 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             Mock -CommandName 'New-SqlDscFileGroup' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $Files)
-
-                    [DatabaseFileGroupSpec]@{
+                    New-Object -TypeName 'DatabaseFileGroupSpec' -Property @{
                         Name = $Name
                         Files = $Files
                     }
@@ -190,14 +187,16 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
         }
 
         It 'Should pass FileGroup parameter when specified' {
-            # Create a mock DatabaseFileGroupSpec using InModuleScope to access internal classes
+            # Create a mock DatabaseFileGroupSpec using InModuleScope to access internal classes.
+            # Use New-Object to create the objects so they have the correct type
+            # from the module's scope.
             $mockFileGroupSpec = InModuleScope -ScriptBlock {
-                $mockDataFileSpec = [DatabaseFileSpec]@{
+                $mockDataFileSpec = New-Object -TypeName 'DatabaseFileSpec' -Property @{
                     Name = 'TestData'
                     FileName = 'C:\Snapshots\TestData.ss'
                 }
 
-                [DatabaseFileGroupSpec]@{
+                New-Object -TypeName 'DatabaseFileGroupSpec' -Property @{
                     Name = 'PRIMARY'
                     Files = @($mockDataFileSpec)
                 }
@@ -274,11 +273,10 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             # Mock New-SqlDscDataFile and New-SqlDscFileGroup to avoid type conflicts
             # between test scope and module scope for PowerShell class types.
+            # Use InModuleScope to access the module's class types directly.
             Mock -CommandName 'New-SqlDscDataFile' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $FileName)
-
-                    [DatabaseFileSpec]@{
+                    New-Object -TypeName 'DatabaseFileSpec' -Property @{
                         Name = $Name
                         FileName = $FileName
                     }
@@ -290,9 +288,7 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             Mock -CommandName 'New-SqlDscFileGroup' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $Files)
-
-                    [DatabaseFileGroupSpec]@{
+                    New-Object -TypeName 'DatabaseFileGroupSpec' -Property @{
                         Name = $Name
                         Files = $Files
                     }
@@ -404,11 +400,10 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             # Mock New-SqlDscDataFile and New-SqlDscFileGroup to avoid type conflicts
             # between test scope and module scope for PowerShell class types.
+            # Use InModuleScope to access the module's class types directly.
             Mock -CommandName 'New-SqlDscDataFile' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $FileName)
-
-                    [DatabaseFileSpec]@{
+                    New-Object -TypeName 'DatabaseFileSpec' -Property @{
                         Name = $Name
                         FileName = $FileName
                     }
@@ -420,9 +415,7 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             Mock -CommandName 'New-SqlDscFileGroup' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $Files)
-
-                    [DatabaseFileGroupSpec]@{
+                    New-Object -TypeName 'DatabaseFileGroupSpec' -Property @{
                         Name = $Name
                         Files = $Files
                     }
@@ -485,11 +478,10 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             # Mock New-SqlDscDataFile and New-SqlDscFileGroup to avoid type conflicts
             # between test scope and module scope for PowerShell class types.
+            # Use InModuleScope to access the module's class types directly.
             Mock -CommandName 'New-SqlDscDataFile' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $FileName)
-
-                    [DatabaseFileSpec]@{
+                    New-Object -TypeName 'DatabaseFileSpec' -Property @{
                         Name = $Name
                         FileName = $FileName
                     }
@@ -501,9 +493,7 @@ Describe 'New-SqlDscDatabaseSnapshot' -Tag 'Public' {
 
             Mock -CommandName 'New-SqlDscFileGroup' -MockWith {
                 InModuleScope -ScriptBlock {
-                    param ($Name, $Files)
-
-                    [DatabaseFileGroupSpec]@{
+                    New-Object -TypeName 'DatabaseFileGroupSpec' -Property @{
                         Name = $Name
                         Files = $Files
                     }