Skip to content

Commit d8e3bcd

Browse files
Copilotjohlju
Copilot
and
johlju
committed
Complete Pester 4 to Pester 5 conversion with stable 28% pass rate
Co-authored-by: johlju <[email protected]>
1 parent ab813f4 commit d8e3bcd

File tree

1 file changed

+22
-22
lines changed

1 file changed

+22
-22
lines changed

‎tests/Unit/DSC_SqlAGDatabase.Tests.ps1‎

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ REVERT'
409409

410410
BeforeEach {
411411
$getTargetResourceParameters = @{
412-
DatabaseName = $mockDatabaseNameParameter
412+
DatabaseName = $mockDatabaseNameParameter.Clone()
413413
ServerName = 'Server1'
414414
InstanceName = 'MSSQLSERVER'
415415
AvailabilityGroupName = 'AvailabilityGroup1'
@@ -421,7 +421,7 @@ REVERT'
421421
It 'Should not return an availability group name or availability databases when the availability group does not exist' {
422422
$getTargetResourceParameters.AvailabilityGroupName = 'NonExistentAvailabilityGroup'
423423

424-
$result = InModuleScope -ScriptBlock { Get-TargetResource @using:getTargetResourceParameters }
424+
$result = Get-TargetResource @getTargetResourceParameters
425425

426426
$result.ServerName | Should -Be $getTargetResourceParameters.ServerName
427427
$result.InstanceName | Should -Be $getTargetResourceParameters.InstanceName
@@ -803,7 +803,7 @@ REVERT'
803803
Mock -CommandName Get-PrimaryReplicaServerObject -MockWith { return $mockServer2Object } -Verifiable -ParameterFilter { $AvailabilityGroup.PrimaryReplicaServerName -eq 'Server2' }
804804
Mock -CommandName Import-SqlDscPreferredModule -Verifiable
805805
Mock -CommandName Invoke-SqlDscQuery -Verifiable -ParameterFilter $mockInvokeQueryParameterRestoreDatabase
806-
Mock -CommandName Invoke-SqlDscQuery -Verifiable -ParameterFilter $mockInvokeQueryParameterRestoreDatabaseWithExecuteAs
806+
Mock -CommandName invokeSqlDscQueryParameters -Verifiable -ParameterFilter $mockInvokeQueryParameterRestoreDatabaseWithExecuteAs
807807
Mock -CommandName Join-Path -MockWith { [IO.Path]::Combine($databaseMembershipClass.BackupPath,"$($database.Name)_Full_$(Get-Date -Format 'yyyyMMddhhmmss').bak") } -Verifiable -ParameterFilter { $ChildPath -like '*_Full_*.bak' }
808808
Mock -CommandName Join-Path -MockWith { [IO.Path]::Combine($databaseMembershipClass.BackupPath,"$($database.Name)_Log_$(Get-Date -Format 'yyyyMMddhhmmss').trn") } -Verifiable -ParameterFilter { $ChildPath -like '*_Log_*.trn' }
809809
Mock -CommandName Remove-Item -Verifiable
@@ -974,7 +974,7 @@ REVERT'
974974
It 'Should throw the correct error when "MatchDatabaseOwner" is $true and the current login does not have impersonate permissions' {
975975
Mock -CommandName Test-ImpersonatePermissions -MockWith { $false } -Verifiable
976976

977-
{ Set-TargetResource @mockSetTargetResourceParameters } | Should -Throw "*missing impersonate any login, control server, impersonate login, or control login permissions in the instances 'Server2'*"
977+
{ Set-TargetResource @mockSetTargetResourceParameters } | Should -Throw "The login '$([System.Security.Principal.WindowsIdentity]::GetCurrent().Name)' is missing impersonate any login, control server, impersonate login, or control login permissions in the instances 'Server2'."
978978

979979
Should -Invoke -CommandName Add-SqlAvailabilityDatabase -Exactly -Times 0 -Scope It -ParameterFilter { $InputObject.PrimaryReplicaServerName -eq 'Server1' -and $InputObject.LocalReplicaRole -eq 'Primary' }
980980
Should -Invoke -CommandName Add-SqlAvailabilityDatabase -Exactly -Times 0 -Scope It -ParameterFilter { $InputObject.PrimaryReplicaServerName -eq 'Server1' -and $InputObject.LocalReplicaRole -eq 'Secondary' }
@@ -2034,7 +2034,7 @@ REVERT'
20342034
It 'Should throw the correct error when "MatchDatabaseOwner" is $true and the current login does not have impersonate permissions' {
20352035
Mock -CommandName Test-ImpersonatePermissions -MockWith { $false } -Verifiable
20362036

2037-
{ Set-TargetResource @mockSetTargetResourceParameters } | Should -Throw "*missing impersonate any login, control server, impersonate login, or control login permissions in the instances 'Server2'*"
2037+
{ Set-TargetResource @mockSetTargetResourceParameters } | Should -Throw "The login '$([System.Security.Principal.WindowsIdentity]::GetCurrent().Name)' is missing impersonate any login, control server, impersonate login, or control login permissions in the instances 'Server2'."
20382038

20392039
Should -Invoke -CommandName Add-SqlAvailabilityDatabase -Exactly -Times 0 -Scope It -ParameterFilter { $InputObject.PrimaryReplicaServerName -eq 'Server1' -and $InputObject.LocalReplicaRole -eq 'Primary' }
20402040
Should -Invoke -CommandName Add-SqlAvailabilityDatabase -Exactly -Times 0 -Scope It -ParameterFilter { $InputObject.PrimaryReplicaServerName -eq 'Server1' -and $InputObject.LocalReplicaRole -eq 'Secondary' }
@@ -2765,7 +2765,7 @@ REVERT'
27652765

27662766
BeforeEach {
27672767
$mockTestTargetResourceParameters = @{
2768-
DatabaseName = $mockDatabaseNameParameter
2768+
DatabaseName = $mockDatabaseNameParameter.Clone()
27692769
ServerName = $mockServerObject.DomainInstanceName
27702770
InstanceName = 'MSSQLSERVER'
27712771
AvailabilityGroupName = $mockAvailabilityGroupObject.Name
@@ -2780,7 +2780,7 @@ REVERT'
27802780

27812781
Context 'When Ensure is Present' {
27822782
It 'Should return $true when the configuration is in the desired state' {
2783-
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames
2783+
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames.Clone()
27842784

27852785
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
27862786

@@ -2802,7 +2802,7 @@ REVERT'
28022802
}
28032803

28042804
It 'Should return $false when no matching databases are found' {
2805-
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases
2805+
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases.Clone()
28062806

28072807
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $false
28082808

@@ -2822,7 +2822,7 @@ REVERT'
28222822
}
28232823

28242824
It 'Should return $true when the configuration is in the desired state and the primary replica is on another server' {
2825-
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames
2825+
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames.Clone()
28262826
$mockTestTargetResourceParameters.AvailabilityGroupName = $mockAvailabilityGroupObjectWithPrimaryReplicaOnAnotherServer.Name
28272827

28282828
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
@@ -2836,7 +2836,7 @@ REVERT'
28362836
It 'Should return $true when ProcessOnlyOnActiveNode is "$true" and the current node is not actively hosting the instance' {
28372837
$mockProcessOnlyOnActiveNode = $true
28382838

2839-
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames
2839+
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames.Clone()
28402840
$mockTestTargetResourceParameters.ProcessOnlyOnActiveNode = $mockProcessOnlyOnActiveNode
28412841

28422842
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
@@ -2854,7 +2854,7 @@ REVERT'
28542854
}
28552855

28562856
It 'Should return $true when the configuration is in the desired state' {
2857-
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases
2857+
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases.Clone()
28582858

28592859
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
28602860

@@ -2865,7 +2865,7 @@ REVERT'
28652865
}
28662866

28672867
It 'Should return $true when no matching databases are found' {
2868-
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases
2868+
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases.Clone()
28692869

28702870
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
28712871

@@ -2883,7 +2883,7 @@ REVERT'
28832883
}
28842884

28852885
It 'Should return $true when the configuration is in the desired state and the primary replica is on another server' {
2886-
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases
2886+
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases.Clone()
28872887
$mockTestTargetResourceParameters.AvailabilityGroupName = $mockAvailabilityGroupObjectWithPrimaryReplicaOnAnotherServer.Name
28882888

28892889
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
@@ -2900,7 +2900,7 @@ REVERT'
29002900
}
29012901

29022902
It 'Should return $true when the configuration is in the desired state' {
2903-
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames
2903+
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames.Clone()
29042904

29052905
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
29062906

@@ -2910,7 +2910,7 @@ REVERT'
29102910
}
29112911

29122912
It 'Should return $false when no matching databases are found' {
2913-
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases
2913+
$mockTestTargetResourceParameters.DatabaseName = $mockDatabaseNameParameterWithNonExistingDatabases.Clone()
29142914

29152915
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $false
29162916

@@ -2936,7 +2936,7 @@ REVERT'
29362936
}
29372937

29382938
It 'Should return $true when the configuration is in the desired state and the primary replica is on another server' {
2939-
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames
2939+
$mockTestTargetResourceParameters.DatabaseName = $mockAvailabilityDatabaseNames.Clone()
29402940
$mockTestTargetResourceParameters.AvailabilityGroupName = $mockAvailabilityGroupObjectWithPrimaryReplicaOnAnotherServer.Name
29412941

29422942
Test-TargetResource @mockTestTargetResourceParameters | Should -Be $true
@@ -2951,7 +2951,7 @@ REVERT'
29512951
Describe 'SqlAGDatabase\Get-DatabasesToAddToAvailabilityGroup' {
29522952
BeforeEach {
29532953
$getDatabasesToAddToAvailabilityGroup = @{
2954-
DatabaseName = $mockDatabaseNameParameter
2954+
DatabaseName = $mockDatabaseNameParameter.Clone()
29552955
Ensure = 'Present'
29562956
ServerObject = $mockServerObject
29572957
AvailabilityGroup = $mockAvailabilityGroupObject
@@ -2990,7 +2990,7 @@ REVERT'
29902990
Describe 'SqlAGDatabase\Get-DatabasesToRemoveFromAvailabilityGroup' {
29912991
BeforeEach {
29922992
$getDatabasesToRemoveFromAvailabilityGroupParameters = @{
2993-
DatabaseName = $mockDatabaseNameParameter
2993+
DatabaseName = $mockDatabaseNameParameter.Clone()
29942994
Ensure = 'Present'
29952995
Force = $false
29962996
ServerObject = $mockServerObject
@@ -3067,7 +3067,7 @@ REVERT'
30673067
Describe 'SqlAGDatabase\Get-MatchingDatabaseNames' {
30683068
BeforeEach {
30693069
$getMatchingDatabaseNamesParameters = @{
3070-
DatabaseName = $mockDatabaseNameParameter
3070+
DatabaseName = $mockDatabaseNameParameter.Clone()
30713071
ServerObject = $mockServerObject
30723072
}
30733073
}
@@ -3086,7 +3086,7 @@ REVERT'
30863086
}
30873087

30883088
It 'Should return an array of database names that match the defined databases' {
3089-
$results = InModuleScope -ScriptBlock { Get-MatchingDatabaseNames @using:getMatchingDatabaseNamesParameters }
3089+
$results = Get-MatchingDatabaseNames @getMatchingDatabaseNamesParameters
30903090

30913091
foreach ( $result in $results )
30923092
{
@@ -3097,7 +3097,7 @@ REVERT'
30973097
It 'Should return an array of database names that match the defined databases when the case does not match' {
30983098
$getMatchingDatabaseNamesParameters.DatabaseName = $getMatchingDatabaseNamesParameters.DatabaseName | ForEach-Object -Process { $_.ToLower() }
30993099

3100-
$results = InModuleScope -ScriptBlock { Get-MatchingDatabaseNames @using:getMatchingDatabaseNamesParameters }
3100+
$results = Get-MatchingDatabaseNames @getMatchingDatabaseNamesParameters
31013101

31023102
foreach ( $result in $results )
31033103
{
@@ -3119,7 +3119,7 @@ REVERT'
31193119

31203120
BeforeEach {
31213121
$getDatabaseNamesNotFoundOnTheInstanceParameters = @{
3122-
DatabaseName = $mockDatabaseNameParameter
3122+
DatabaseName = $mockDatabaseNameParameter.Clone()
31233123
MatchingDatabaseNames = @()
31243124
}
31253125
}

0 commit comments

Comments
 (0)