Fix unit tests for Pester v6 compatibility and improve copilot instructions

Co-authored-by: johlju <[email protected]>

Author: Copilot

.github/copilot-instructions.md

@@ -214,7 +214,7 @@ should be written to cover all possible scenarios and code paths, ensuring
 that both edge cases and common use cases are tested.
 
 All public commands should always have a test to validate parameter sets 
-using this template:
+using this template. For commands with a single parameter set:
 
 ```powershell
 It 'Should have the correct parameters in parameter set <MockParameterSetName>' -ForEach @(
@@ -243,6 +243,53 @@ It 'Should have the correct parameters in parameter set <MockParameterSetName>'
 }
 ```
 
+For commands with multiple parameter sets, use this pattern:
+
+```powershell
+It 'Should have the correct parameters in parameter set <MockParameterSetName>' -ForEach @(
+    @{
+        MockParameterSetName = 'ParameterSet1'
+        MockExpectedParameters = '-ServerObject <Server> -Name <string> -Parameter1 <string> [<CommonParameters>]'
+    }
+    @{
+        MockParameterSetName = 'ParameterSet2'
+        MockExpectedParameters = '-ServerObject <Server> -Name <string> -Parameter2 <uint> [<CommonParameters>]'
+    }
+) {
+    $result = (Get-Command -Name 'CommandName').ParameterSets |
+        Where-Object -FilterScript {
+            $_.Name -eq $mockParameterSetName
+        } |
+        Select-Object -Property @(
+            @{
+                Name = 'ParameterSetName'
+                Expression = { $_.Name }
+            },
+            @{
+                Name = 'ParameterListAsString'
+                Expression = { $_.ToString() }
+            }
+        )
+
+    $result.ParameterSetName | Should -Be $MockParameterSetName
+    $result.ParameterListAsString | Should -Be $MockExpectedParameters
+}
+```
+
+All public commands should also include tests to validate parameter properties:
+
+```powershell
+It 'Should have ParameterName as a mandatory parameter' {
+    $parameterInfo = (Get-Command -Name 'CommandName').Parameters['ParameterName']
+    $parameterInfo.Attributes.Mandatory | Should -Contain $true
+}
+
+It 'Should accept ParameterName from pipeline' {
+    $parameterInfo = (Get-Command -Name 'CommandName').Parameters['ParameterName']
+    $parameterInfo.Attributes.ValueFromPipeline | Should -Contain $true
+}
+```
+
 The `BeforeAll` block should be used to set up any necessary test data or mocking
 
 Use localized strings in the tests only when necessary. You can assign the

tests/Unit/Public/Assert-SqlDscLogin.Tests.ps1

@@ -64,15 +64,15 @@ Describe 'Assert-SqlDscLogin' -Tag 'Public' {
 
         It 'Should call Test-SqlDscIsLogin with correct parameters' {
             Assert-SqlDscLogin -ServerObject $mockServerObject -Name 'TestLogin'
-            
+
             Should -Invoke -CommandName 'Test-SqlDscIsLogin' -ParameterFilter {
                 $ServerObject.InstanceName -eq 'TestInstance' -and
                 $Name -eq 'TestLogin'
             } -Exactly -Times 1
         }
 
         It 'Should accept ServerObject from pipeline' {
-            { $mockServerObject | Assert-SqlDscLogin -Name 'TestLogin' } | Should -Not -Throw
+            $mockServerObject | Assert-SqlDscLogin -Name 'TestLogin'
         }
     }
 
@@ -110,7 +110,7 @@ Describe 'Assert-SqlDscLogin' -Tag 'Public' {
 
         It 'Should call Test-SqlDscIsLogin with correct parameters' {
             { Assert-SqlDscLogin -ServerObject $mockServerObject -Name 'NonExistentLogin' } | Should -Throw
-            
+
             Should -Invoke -CommandName 'Test-SqlDscIsLogin' -ParameterFilter {
                 $ServerObject.InstanceName -eq 'TestInstance' -and
                 $Name -eq 'NonExistentLogin'