diff --git a/CHANGELOG.md b/CHANGELOG.md index 575be63e50..3b46e9f862 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - Removed parameter `DatabaseSnapshotBaseName`. Database snapshots should be created using the `New-SqlDscDatabaseSnapshot`, or the `New-SqlDscDatabase` command with the `-DatabaseSnapshotBaseName` parameter. + - Removed parameter `DefaultSchema`. Default schema is a user-level property, + not a database-level property. See [issue #2177](https://github.com/dsccommunity/SqlServerDsc/issues/2177). ### Added diff --git a/source/Public/Set-SqlDscDatabaseProperty.ps1 b/source/Public/Set-SqlDscDatabaseProperty.ps1 index 5d6cd2144e..59879410d5 100644 --- a/source/Public/Set-SqlDscDatabaseProperty.ps1 +++ b/source/Public/Set-SqlDscDatabaseProperty.ps1 @@ -116,8 +116,6 @@ .PARAMETER DefaultLanguage Specifies the ID of the default language for the database. - .PARAMETER DefaultSchema - Specifies the default schema name for users without an explicit default schema. .PARAMETER DelayedDurability Specifies the delayed durability setting for the database (DISABLED, ALLOWED, FORCED). @@ -577,10 +575,6 @@ function Set-SqlDscDatabaseProperty [System.String] $Collation, - [Parameter()] - [System.String] - $DefaultSchema, - [Parameter()] [System.String] $FilestreamDirectoryName, diff --git a/tests/Unit/Public/Set-SqlDscDatabaseProperty.Tests.ps1 b/tests/Unit/Public/Set-SqlDscDatabaseProperty.Tests.ps1 index 1108d45e6e..0049434c32 100644 --- a/tests/Unit/Public/Set-SqlDscDatabaseProperty.Tests.ps1 +++ b/tests/Unit/Public/Set-SqlDscDatabaseProperty.Tests.ps1 @@ -366,7 +366,7 @@ Describe 'Set-SqlDscDatabaseProperty' -Tag 'Public' { It 'Should have the correct parameters in parameter set ServerObjectSet' -ForEach @( @{ ExpectedParameterSetName = 'ServerObjectSet' - ExpectedParameters = '-ServerObject -Name [-Refresh] [-AcceleratedRecoveryEnabled ] [-AnsiNullDefault ] [-AnsiNullsEnabled ] [-AnsiPaddingEnabled ] [-AnsiWarningsEnabled ] [-ArithmeticAbortEnabled ] [-AutoClose ] [-AutoCreateIncrementalStatisticsEnabled ] [-AutoCreateStatisticsEnabled ] [-AutoShrink ] [-AutoUpdateStatisticsAsync ] [-AutoUpdateStatisticsEnabled ] [-BrokerEnabled ] [-ChangeTrackingAutoCleanUp ] [-ChangeTrackingEnabled ] [-CloseCursorsOnCommitEnabled ] [-ConcatenateNullYieldsNull ] [-DatabaseOwnershipChaining ] [-DataRetentionEnabled ] [-DateCorrelationOptimization ] [-EncryptionEnabled ] [-HonorBrokerPriority ] [-IsFullTextEnabled ] [-IsLedger ] [-IsParameterizationForced ] [-IsReadCommittedSnapshotOn ] [-IsSqlDw ] [-IsVarDecimalStorageFormatEnabled ] [-LegacyCardinalityEstimation ] [-LegacyCardinalityEstimationForSecondary ] [-LocalCursorsDefault ] [-NestedTriggersEnabled ] [-NumericRoundAbortEnabled ] [-ParameterSniffing ] [-ParameterSniffingForSecondary ] [-QueryOptimizerHotfixes ] [-QueryOptimizerHotfixesForSecondary ] [-QuotedIdentifiersEnabled ] [-ReadOnly ] [-RecursiveTriggersEnabled ] [-RemoteDataArchiveEnabled ] [-RemoteDataArchiveUseFederatedServiceAccount ] [-TemporalHistoryRetentionEnabled ] [-TransformNoiseWords ] [-Trustworthy ] [-ChangeTrackingRetentionPeriod ] [-DefaultFullTextLanguage ] [-DefaultLanguage ] [-MaxDop ] [-MaxDopForSecondary ] [-MirroringRedoQueueMaxSize ] [-MirroringTimeout ] [-TargetRecoveryTime ] [-TwoDigitYearCutoff ] [-MaxSizeInBytes ] [-Collation ] [-DefaultSchema ] [-FilestreamDirectoryName ] [-MirroringPartner ] [-MirroringPartnerInstance ] [-MirroringWitness ] [-PersistentVersionStoreFileGroup ] [-PrimaryFilePath ] [-RemoteDataArchiveCredential ] [-RemoteDataArchiveEndpoint ] [-RemoteDataArchiveLinkedServer ] [-RemoteDatabaseName ] [-ChangeTrackingRetentionPeriodUnits ] [-CompatibilityLevel ] [-ContainmentType ] [-DelayedDurability ] [-FilestreamNonTransactedAccess ] [-MirroringSafetyLevel ] [-PageVerify ] [-RecoveryModel ] [-UserAccess ] [-Force] [-PassThru] [-WhatIf] [-Confirm] []' + ExpectedParameters = '-ServerObject -Name [-Refresh] [-AcceleratedRecoveryEnabled ] [-AnsiNullDefault ] [-AnsiNullsEnabled ] [-AnsiPaddingEnabled ] [-AnsiWarningsEnabled ] [-ArithmeticAbortEnabled ] [-AutoClose ] [-AutoCreateIncrementalStatisticsEnabled ] [-AutoCreateStatisticsEnabled ] [-AutoShrink ] [-AutoUpdateStatisticsAsync ] [-AutoUpdateStatisticsEnabled ] [-BrokerEnabled ] [-ChangeTrackingAutoCleanUp ] [-ChangeTrackingEnabled ] [-CloseCursorsOnCommitEnabled ] [-ConcatenateNullYieldsNull ] [-DatabaseOwnershipChaining ] [-DataRetentionEnabled ] [-DateCorrelationOptimization ] [-EncryptionEnabled ] [-HonorBrokerPriority ] [-IsFullTextEnabled ] [-IsLedger ] [-IsParameterizationForced ] [-IsReadCommittedSnapshotOn ] [-IsSqlDw ] [-IsVarDecimalStorageFormatEnabled ] [-LegacyCardinalityEstimation ] [-LegacyCardinalityEstimationForSecondary ] [-LocalCursorsDefault ] [-NestedTriggersEnabled ] [-NumericRoundAbortEnabled ] [-ParameterSniffing ] [-ParameterSniffingForSecondary ] [-QueryOptimizerHotfixes ] [-QueryOptimizerHotfixesForSecondary ] [-QuotedIdentifiersEnabled ] [-ReadOnly ] [-RecursiveTriggersEnabled ] [-RemoteDataArchiveEnabled ] [-RemoteDataArchiveUseFederatedServiceAccount ] [-TemporalHistoryRetentionEnabled ] [-TransformNoiseWords ] [-Trustworthy ] [-ChangeTrackingRetentionPeriod ] [-DefaultFullTextLanguage ] [-DefaultLanguage ] [-MaxDop ] [-MaxDopForSecondary ] [-MirroringRedoQueueMaxSize ] [-MirroringTimeout ] [-TargetRecoveryTime ] [-TwoDigitYearCutoff ] [-MaxSizeInBytes ] [-Collation ] [-FilestreamDirectoryName ] [-MirroringPartner ] [-MirroringPartnerInstance ] [-MirroringWitness ] [-PersistentVersionStoreFileGroup ] [-PrimaryFilePath ] [-RemoteDataArchiveCredential ] [-RemoteDataArchiveEndpoint ] [-RemoteDataArchiveLinkedServer ] [-RemoteDatabaseName ] [-ChangeTrackingRetentionPeriodUnits ] [-CompatibilityLevel ] [-ContainmentType ] [-DelayedDurability ] [-FilestreamNonTransactedAccess ] [-MirroringSafetyLevel ] [-PageVerify ] [-RecoveryModel ] [-UserAccess ] [-Force] [-PassThru] [-WhatIf] [-Confirm] []' } ) { $result = (Get-Command -Name 'Set-SqlDscDatabaseProperty').ParameterSets | @@ -383,7 +383,7 @@ Describe 'Set-SqlDscDatabaseProperty' -Tag 'Public' { It 'Should have the correct parameters in parameter set DatabaseObjectSet' -ForEach @( @{ ExpectedParameterSetName = 'DatabaseObjectSet' - ExpectedParameters = '-DatabaseObject [-AcceleratedRecoveryEnabled ] [-AnsiNullDefault ] [-AnsiNullsEnabled ] [-AnsiPaddingEnabled ] [-AnsiWarningsEnabled ] [-ArithmeticAbortEnabled ] [-AutoClose ] [-AutoCreateIncrementalStatisticsEnabled ] [-AutoCreateStatisticsEnabled ] [-AutoShrink ] [-AutoUpdateStatisticsAsync ] [-AutoUpdateStatisticsEnabled ] [-BrokerEnabled ] [-ChangeTrackingAutoCleanUp ] [-ChangeTrackingEnabled ] [-CloseCursorsOnCommitEnabled ] [-ConcatenateNullYieldsNull ] [-DatabaseOwnershipChaining ] [-DataRetentionEnabled ] [-DateCorrelationOptimization ] [-EncryptionEnabled ] [-HonorBrokerPriority ] [-IsFullTextEnabled ] [-IsLedger ] [-IsParameterizationForced ] [-IsReadCommittedSnapshotOn ] [-IsSqlDw ] [-IsVarDecimalStorageFormatEnabled ] [-LegacyCardinalityEstimation ] [-LegacyCardinalityEstimationForSecondary ] [-LocalCursorsDefault ] [-NestedTriggersEnabled ] [-NumericRoundAbortEnabled ] [-ParameterSniffing ] [-ParameterSniffingForSecondary ] [-QueryOptimizerHotfixes ] [-QueryOptimizerHotfixesForSecondary ] [-QuotedIdentifiersEnabled ] [-ReadOnly ] [-RecursiveTriggersEnabled ] [-RemoteDataArchiveEnabled ] [-RemoteDataArchiveUseFederatedServiceAccount ] [-TemporalHistoryRetentionEnabled ] [-TransformNoiseWords ] [-Trustworthy ] [-ChangeTrackingRetentionPeriod ] [-DefaultFullTextLanguage ] [-DefaultLanguage ] [-MaxDop ] [-MaxDopForSecondary ] [-MirroringRedoQueueMaxSize ] [-MirroringTimeout ] [-TargetRecoveryTime ] [-TwoDigitYearCutoff ] [-MaxSizeInBytes ] [-Collation ] [-DefaultSchema ] [-FilestreamDirectoryName ] [-MirroringPartner ] [-MirroringPartnerInstance ] [-MirroringWitness ] [-PersistentVersionStoreFileGroup ] [-PrimaryFilePath ] [-RemoteDataArchiveCredential ] [-RemoteDataArchiveEndpoint ] [-RemoteDataArchiveLinkedServer ] [-RemoteDatabaseName ] [-ChangeTrackingRetentionPeriodUnits ] [-CompatibilityLevel ] [-ContainmentType ] [-DelayedDurability ] [-FilestreamNonTransactedAccess ] [-MirroringSafetyLevel ] [-PageVerify ] [-RecoveryModel ] [-UserAccess ] [-Force] [-PassThru] [-WhatIf] [-Confirm] []' + ExpectedParameters = '-DatabaseObject [-AcceleratedRecoveryEnabled ] [-AnsiNullDefault ] [-AnsiNullsEnabled ] [-AnsiPaddingEnabled ] [-AnsiWarningsEnabled ] [-ArithmeticAbortEnabled ] [-AutoClose ] [-AutoCreateIncrementalStatisticsEnabled ] [-AutoCreateStatisticsEnabled ] [-AutoShrink ] [-AutoUpdateStatisticsAsync ] [-AutoUpdateStatisticsEnabled ] [-BrokerEnabled ] [-ChangeTrackingAutoCleanUp ] [-ChangeTrackingEnabled ] [-CloseCursorsOnCommitEnabled ] [-ConcatenateNullYieldsNull ] [-DatabaseOwnershipChaining ] [-DataRetentionEnabled ] [-DateCorrelationOptimization ] [-EncryptionEnabled ] [-HonorBrokerPriority ] [-IsFullTextEnabled ] [-IsLedger ] [-IsParameterizationForced ] [-IsReadCommittedSnapshotOn ] [-IsSqlDw ] [-IsVarDecimalStorageFormatEnabled ] [-LegacyCardinalityEstimation ] [-LegacyCardinalityEstimationForSecondary ] [-LocalCursorsDefault ] [-NestedTriggersEnabled ] [-NumericRoundAbortEnabled ] [-ParameterSniffing ] [-ParameterSniffingForSecondary ] [-QueryOptimizerHotfixes ] [-QueryOptimizerHotfixesForSecondary ] [-QuotedIdentifiersEnabled ] [-ReadOnly ] [-RecursiveTriggersEnabled ] [-RemoteDataArchiveEnabled ] [-RemoteDataArchiveUseFederatedServiceAccount ] [-TemporalHistoryRetentionEnabled ] [-TransformNoiseWords ] [-Trustworthy ] [-ChangeTrackingRetentionPeriod ] [-DefaultFullTextLanguage ] [-DefaultLanguage ] [-MaxDop ] [-MaxDopForSecondary ] [-MirroringRedoQueueMaxSize ] [-MirroringTimeout ] [-TargetRecoveryTime ] [-TwoDigitYearCutoff ] [-MaxSizeInBytes ] [-Collation ] [-FilestreamDirectoryName ] [-MirroringPartner ] [-MirroringPartnerInstance ] [-MirroringWitness ] [-PersistentVersionStoreFileGroup ] [-PrimaryFilePath ] [-RemoteDataArchiveCredential ] [-RemoteDataArchiveEndpoint ] [-RemoteDataArchiveLinkedServer ] [-RemoteDatabaseName ] [-ChangeTrackingRetentionPeriodUnits ] [-CompatibilityLevel ] [-ContainmentType ] [-DelayedDurability ] [-FilestreamNonTransactedAccess ] [-MirroringSafetyLevel ] [-PageVerify ] [-RecoveryModel ] [-UserAccess ] [-Force] [-PassThru] [-WhatIf] [-Confirm] []' } ) { $result = (Get-Command -Name 'Set-SqlDscDatabaseProperty').ParameterSets |