Setup is responsible for knowing if the depot supports hard links or not, and acts accordingly.

Author: mitchell-as

pkg/runtime/depot.go

@@ -55,7 +55,7 @@ type depot struct {
 	depotPath         string
 	artifacts         map[strfmt.UUID]struct{}
 	fsMutex           *sync.Mutex
-	supportsHardLinks bool
+	SupportsHardLinks bool
 }
 
 func newDepot(runtimePath string) (*depot, error) {
@@ -78,7 +78,7 @@ func newDepot(runtimePath string) (*depot, error) {
 		depotPath:         depotPath,
 		artifacts:         map[strfmt.UUID]struct{}{},
 		fsMutex:           &sync.Mutex{},
-		supportsHardLinks: supportsHardLinks(depotPath),
+		SupportsHardLinks: supportsHardLinks(depotPath),
 	}
 
 	if !fileutils.TargetExists(depotPath) {
@@ -148,8 +148,8 @@ func (d *depot) Put(id strfmt.UUID) error {
 
 // DeployViaLink will take an artifact from the depot and link it to the target path.
 func (d *depot) DeployViaLink(id strfmt.UUID, relativeSrc, absoluteDest string) error {
-	if !d.supportsHardLinks {
-		return d.DeployViaCopy(id, relativeSrc, absoluteDest)
+	if !d.SupportsHardLinks {
+		return errs.New("depot does not support hard links; use copy instead")
 	}
 
 	d.fsMutex.Lock()

pkg/runtime/setup.go

@@ -470,10 +470,14 @@ func (s *setup) install(id strfmt.UUID) (rerr error) {
 		if err := envDef.ApplyFileTransforms(s.path); err != nil {
 			return errs.Wrap(err, "Could not apply env transforms")
 		}
-	} else {
+	} else if s.depot.SupportsHardLinks {
 		if err := s.depot.DeployViaLink(id, envDef.InstallDir, s.path); err != nil {
 			return errs.Wrap(err, "Could not deploy artifact via link")
 		}
+	} else {
+		if err := s.depot.DeployViaCopy(id, envDef.InstallDir, s.path); err != nil {
+			return errs.Wrap(err, "Could not deploy artifact via copy")
+		}
 	}
 
 	return nil