state refresh should not error if the runtime is up to date.

mitchell-as · mitchell-as · commit 2dae8ec99f13 · 2024-10-29T14:03:42.000-04:00
diff --git a/internal/runners/refresh/refresh.go b/internal/runners/refresh/refresh.go
@@ -92,7 +92,8 @@ func (r *Refresh) Run(params *Params) error {
 	}
 
 	if !needsUpdate {
-		return locale.NewInputError("refresh_runtime_uptodate")
+		r.out.Notice(locale.T("refresh_runtime_uptodate"))
+		return nil
 	}
 
 	rti, err := runtime_runbit.Update(r.prime, trigger.TriggerRefresh, runtime_runbit.WithoutHeaders(), runtime_runbit.WithIgnoreAsync())
diff --git a/test/integration/refresh_int_test.go b/test/integration/refresh_int_test.go
@@ -39,7 +39,7 @@ func (suite *RefreshIntegrationTestSuite) TestRefresh() {
 
 	cp = ts.Spawn("refresh")
 	cp.Expect("already up to date")
-	cp.ExpectExitCode(1)
+	cp.ExpectExitCode(0)
 }
 
 func (suite *RefreshIntegrationTestSuite) TestJSON() {

Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,8 @@ func (r Refresh) Run(params Params) error {`
`92`	`92`	`}`
`93`	`93`
`94`	`94`	`if !needsUpdate {`
`95`		`- return locale.NewInputError("refresh_runtime_uptodate")`
	`95`	`+ r.out.Notice(locale.T("refresh_runtime_uptodate"))`
	`96`	`+ return nil`
`96`	`97`	`}`
`97`	`98`
`98`	`99`	`rti, err := runtime_runbit.Update(r.prime, trigger.TriggerRefresh, runtime_runbit.WithoutHeaders(), runtime_runbit.WithIgnoreAsync())`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ func (suite *RefreshIntegrationTestSuite) TestRefresh() {`
`39`	`39`
`40`	`40`	`cp = ts.Spawn("refresh")`
`41`	`41`	`cp.Expect("already up to date")`
`42`		`- cp.ExpectExitCode(1)`
	`42`	`+ cp.ExpectExitCode(0)`
`43`	`43`	`}`
`44`	`44`
`45`	`45`	`func (suite *RefreshIntegrationTestSuite) TestJSON() {`