Do not use the default retryhttp client for state update; use a no-timeout client.

mitchell-as · mitchell-as · commit 314617cefdae · 2024-07-09T14:20:11.000-04:00
The default client times out after 30 seconds, which prevents users with slow internet connections from successfully running `state update`.
diff --git a/internal/updater/fetcher.go b/internal/updater/fetcher.go
@@ -26,7 +26,7 @@ type Fetcher struct {
 }
 
 func NewFetcher(an analytics.Dispatcher) *Fetcher {
-	return &Fetcher{retryhttp.DefaultClient, an}
+	return &Fetcher{retryhttp.NewClient(0, retryhttp.DefaultRetries), an}
 }
 
 func (f *Fetcher) Fetch(update *UpdateInstaller, targetDir string) error {

Original file line number	Diff line number	Diff line change
`@@ -26,7 +26,7 @@ type Fetcher struct {`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`func NewFetcher(an analytics.Dispatcher) *Fetcher {`
`29`		`- return &Fetcher{retryhttp.DefaultClient, an}`
	`29`	`+ return &Fetcher{retryhttp.NewClient(0, retryhttp.DefaultRetries), an}`
`30`	`30`	`}`
`31`	`31`
`32`	`32`	`func (f Fetcher) Fetch(update UpdateInstaller, targetDir string) error {`