Skip to content

Commit 6d7a124

Browse files
committed
Add comment
1 parent 824c198 commit 6d7a124

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

internal/runbits/dependencies/changesummary.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ const showUpdatedPackages = true
2222
// dependencies being installed for the requested packages, if any.
2323
func OutputChangeSummary(out output.Outputer, newBuildPlan *buildplan.BuildPlan, oldBuildPlan *buildplan.BuildPlan) {
2424
requested := newBuildPlan.RequestedArtifacts().ToIDMap()
25+
logging.Debug("requested: %v", requested)
2526

2627
addedString := []string{}
2728
addedLocale := []string{}
@@ -58,7 +59,7 @@ func OutputChangeSummary(out output.Outputer, newBuildPlan *buildplan.BuildPlan,
5859

5960
for _, i := range a.Ingredients { // added package, not updated/requested package
6061
dependencies = append(dependencies, i)
61-
directDependencies = append(directDependencies, i)
62+
directDependencies = append(dependencies, i)
6263
}
6364
break
6465

@@ -68,6 +69,7 @@ func OutputChangeSummary(out output.Outputer, newBuildPlan *buildplan.BuildPlan,
6869

6970
dependencies = sliceutils.UniqueByProperty(dependencies, func(i *buildplan.Ingredient) any { return i.IngredientID })
7071
directDependencies = sliceutils.UniqueByProperty(directDependencies, func(i *buildplan.Ingredient) any { return i.IngredientID })
72+
// Duplicate entries may occur when multiple artifacts share common dependencies.
7173
addedLocale = sliceutils.Unique(addedLocale)
7274
commonDependencies := directDependencies.CommonRuntimeDependencies().ToIDMap()
7375
numIndirect := len(dependencies) - len(directDependencies) - len(commonDependencies)

0 commit comments

Comments
 (0)