Use lambda function for filtering for installable artifacts.

Avoid changing more files with the upcoming runtime refactor.

Author: mitchell-as

pkg/buildplan/filters.go

@@ -65,9 +65,3 @@ func FilterSuccessfulArtifacts() FilterArtifact {
 			a.Status == types.ArtifactReady
 	}
 }
-
-func FilterInstallableArtifacts() FilterArtifact {
-	return func(a *Artifact) bool {
-		return a.URL != ""
-	}
-}

pkg/platform/runtime/setup/setup.go

@@ -615,7 +615,8 @@ func (s *Setup) fetchAndInstallArtifactsFromBuildPlan(bp *buildplan.BuildPlan, i
 	}
 
 	buildReady := bp.IsBuildReady()
-	if !buildReady && len(artifactsToInstall.Filter(buildplan.FilterSuccessfulArtifacts(), buildplan.FilterInstallableArtifacts())) == len(artifactsToInstall) {
+	filterInstallable := func(a *buildplan.Artifact) bool { return a.URL != "" }
+	if !buildReady && len(artifactsToInstall.Filter(buildplan.FilterSuccessfulArtifacts(), filterInstallable)) == len(artifactsToInstall) {
 		// Even though the build may not be complete, all of the necessary artifacts are ready.
 		buildReady = true
 	}