Apply PR feedback suggestions.

Author: mitchell-as

pkg/runtime/links_windows.go

@@ -14,13 +14,10 @@ const linkTarget = "__target__"
 const link = "__link__"
 
 func supportsHardLinks(path string) (supported bool) {
-	logging.Debug("Determining if hard links are supported for drive associated with '%s'", path)
 	defer func() {
-		log := "Yes they are"
 		if !supported {
-			log = "No they are not"
+			logging.Debug("Enforcing deployment via copy, as hardlinks are not supported")
 		}
-		logging.Debug(log)
 	}()
 
 	target := filepath.Join(path, linkTarget)

pkg/runtime/setup.go

@@ -465,21 +465,19 @@ func (s *setup) install(id strfmt.UUID) (rerr error) {
 		return errs.Wrap(err, "Could not get env")
 	}
 
-	if envDef.NeedsTransforms() {
+	if envDef.NeedsTransforms() || !s.supportsHardLinks {
 		if err := s.depot.DeployViaCopy(id, envDef.InstallDir, s.path); err != nil {
 			return errs.Wrap(err, "Could not deploy artifact via copy")
 		}
-		if err := envDef.ApplyFileTransforms(s.path); err != nil {
-			return errs.Wrap(err, "Could not apply env transforms")
+		if s.supportsHardLinks {
+			if err := envDef.ApplyFileTransforms(s.path); err != nil {
+				return errs.Wrap(err, "Could not apply env transforms")
+			}
 		}
-	} else if s.supportsHardLinks {
+	} else {
 		if err := s.depot.DeployViaLink(id, envDef.InstallDir, s.path); err != nil {
 			return errs.Wrap(err, "Could not deploy artifact via link")
 		}
-	} else {
-		if err := s.depot.DeployViaCopy(id, envDef.InstallDir, s.path); err != nil {
-			return errs.Wrap(err, "Could not deploy artifact via copy")
-		}
 	}
 
 	return nil