Merge pull request ActiveState#3240 from ActiveState/version/0-43-0-RC10

Version 0.43.0-RC10

Author: Naatan

internal/runners/artifacts/artifacts.go

@@ -1,6 +1,7 @@
 package artifacts
 
 import (
+	"errors"
 	"fmt"
 	"sort"
 	"strings"
@@ -12,9 +13,11 @@ import (
 	"github.com/ActiveState/cli/internal/locale"
 	"github.com/ActiveState/cli/internal/output"
 	"github.com/ActiveState/cli/internal/primer"
+	"github.com/ActiveState/cli/internal/rtutils/ptr"
 	"github.com/ActiveState/cli/internal/runbits/rationalize"
 	"github.com/ActiveState/cli/pkg/localcommit"
 	bpModel "github.com/ActiveState/cli/pkg/platform/api/buildplanner/model"
+	"github.com/ActiveState/cli/pkg/platform/api/buildplanner/request"
 	"github.com/ActiveState/cli/pkg/platform/authentication"
 	"github.com/ActiveState/cli/pkg/platform/model"
 	"github.com/ActiveState/cli/pkg/platform/runtime/buildplan"
@@ -92,12 +95,19 @@ type errInvalidCommitId struct {
 	id string
 }
 
-func rationalizeArtifactsError(err *error, auth *authentication.Auth) {
-	switch {
-	case err == nil:
+func rationalizeArtifactsError(rerr *error, auth *authentication.Auth) {
+	if rerr == nil {
 		return
+	}
+
+	var planningError *bpModel.BuildPlannerError
+	switch {
+	case errors.As(*rerr, &planningError):
+		// Forward API error to user.
+		*rerr = errs.WrapUserFacing(*rerr, planningError.Error())
+
 	default:
-		rationalizeCommonError(err, auth)
+		rationalizeCommonError(rerr, auth)
 	}
 }
 
@@ -253,7 +263,7 @@ func getTerminalArtifactMap(
 		pb.Stop(message + "\n") // extra empty line
 	}()
 
-	var targetPtr *string
+	targetPtr := ptr.To(request.TargetAll)
 	if target != "" {
 		targetPtr = &target
 	}

internal/runners/artifacts/download.go

@@ -16,6 +16,7 @@ import (
 	"github.com/ActiveState/cli/internal/httputil"
 	"github.com/ActiveState/cli/internal/locale"
 	"github.com/ActiveState/cli/internal/output"
+	"github.com/ActiveState/cli/pkg/platform/api/buildplanner/request"
 	"github.com/ActiveState/cli/pkg/platform/authentication"
 	"github.com/ActiveState/cli/pkg/platform/model"
 	"github.com/ActiveState/cli/pkg/platform/runtime/artifact"
@@ -80,8 +81,13 @@ func (d *Download) Run(params *DownloadParams) (rerr error) {
 		d.out.Notice(locale.Tr("operating_message", d.project.NamespaceString(), d.project.Dir()))
 	}
 
+	target := request.TargetAll
+	if params.Target != "" {
+		target = params.Target
+	}
+
 	terminalArtfMap, _, _, err := getTerminalArtifactMap(
-		d.project, params.Namespace, params.CommitID, params.Target, d.auth, d.out)
+		d.project, params.Namespace, params.CommitID, target, d.auth, d.out)
 	if err != nil {
 		return errs.Wrap(err, "Could not get build plan map")
 	}

pkg/platform/api/buildplanner/request/buildplan.go

@@ -5,6 +5,8 @@ import (
 	"github.com/ActiveState/cli/internal/rtutils/ptr"
 )
 
+const TargetAll = "__all__"
+
 func BuildPlan(commitID, organization, project string, target *string) gqlclient.Request {
 	if organization == "" && project == "" {
 		return BuildPlanByCommitID(commitID, ptr.From(target, ""))