Fix cutoff not considering time being equal

Author: Naatan

pkg/platform/authentication/auth.go

@@ -148,7 +148,7 @@ func (s *Auth) MaybeRenew() error {
 // cutoffReached checks whether the JWT will expire before the provided cutoff time
 func (s *Auth) cutoffReached(cutoff time.Time) bool {
 	expires := s.lastRenewal.Add(s.jwtLifetime)
-	return expires.Before(cutoff)
+	return expires.Equal(cutoff) || expires.Before(cutoff)
 }
 
 func (s *Auth) Close() error {

pkg/platform/authentication/auth_test.go

@@ -8,6 +8,8 @@ import (
 )
 
 func TestAuth_cutoffReached(t *testing.T) {
+	now := time.Now()
+
 	tests := []struct {
 		name   string
 		auth   *Auth
@@ -17,28 +19,28 @@ func TestAuth_cutoffReached(t *testing.T) {
 		{
 			"Cutoff one second beyond keepalive",
 			&Auth{
-				lastRenewal: ptr.To(time.Now()),
+				lastRenewal: ptr.To(now),
 				jwtLifetime: time.Second,
 			},
-			time.Now().Add(2 * time.Second),
+			now.Add(2 * time.Second),
 			true,
 		},
 		{
 			"Cutoff one second before keepalive",
 			&Auth{
-				lastRenewal: ptr.To(time.Now()),
+				lastRenewal: ptr.To(now),
 				jwtLifetime: 2 * time.Second,
 			},
-			time.Now().Add(time.Second),
+			now.Add(time.Second),
 			false,
 		},
 		{
 			"Cutoff equal to keepalive",
 			&Auth{
-				lastRenewal: ptr.To(time.Now()),
+				lastRenewal: ptr.To(now),
 				jwtLifetime: time.Second,
 			},
-			time.Now().Add(time.Second),
+			now.Add(time.Second),
 			true,
 		},
 	}