Merge pull request ActiveState#3354 from ActiveState/mitchell/dx-2887

mitchell-as · web-flow · commit fe9149e50cec · 2024-06-11T17:58:52.000-04:00
If the remote installer could not get an install payload, but no error happened, show a helpful error message.
diff --git a/cmd/state-remote-installer/main.go b/cmd/state-remote-installer/main.go
@@ -194,6 +194,8 @@ func execute(out output.Outputer, prompt prompt.Prompter, cfg *config.Instance,
 	availableUpdate, err := checker.CheckFor(channel, params.version)
 	if err != nil {
 		return errs.Wrap(err, "Could not retrieve install package information")
+	} else if availableUpdate == nil {
+		return locale.NewError("remote_install_no_available_update", "Could not find installer to download. This could be due to networking issues or temporary maintenance. Please try again later.")
 	}
 
 	version := availableUpdate.Version

Original file line number	Diff line number	Diff line change
`@@ -194,6 +194,8 @@ func execute(out output.Outputer, prompt prompt.Prompter, cfg *config.Instance,`
`194`	`194`	`availableUpdate, err := checker.CheckFor(channel, params.version)`
`195`	`195`	`if err != nil {`
`196`	`196`	`return errs.Wrap(err, "Could not retrieve install package information")`
	`197`	`+ } else if availableUpdate == nil {`
	`198`	`+ return locale.NewError("remote_install_no_available_update", "Could not find installer to download. This could be due to networking issues or temporary maintenance. Please try again later.")`
`197`	`199`	`}`
`198`	`200`
`199`	`201`	`version := availableUpdate.Version`