Skip to content

Commit aada468

Browse files
sokcevicGLUCI
authored andcommitted
upload: Return correct tuple values in _ProcessResults
Incorrect tuple values were returned with http://go/grev/440221 - instead of returning (Project, ReviewableBranch), _ProcessResults was returning (int, ReviewableBranch). [email protected] Bug: 376731172 Change-Id: I75205f42fd23f5ee6bd8d0c15b18066189b42bd9 Reviewed-on: https://gerrit-review.googlesource.com/c/git-repo/+/441121 Reviewed-by: Sam Saccone <[email protected]> Commit-Queue: Josip Sokcevic <[email protected]> Tested-by: Josip Sokcevic <[email protected]>
1 parent 1d50986 commit aada468

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

subcmds/upload.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -737,8 +737,8 @@ def _ProcessResults(_pool, _out, results):
737737
pending = []
738738
for result in results:
739739
project_idx, avail = result
740+
project = projects[project_idx]
740741
if avail is None:
741-
project = projects[project_idx]
742742
logger.error(
743743
'repo: error: %s: Unable to upload branch "%s". '
744744
"You might be able to fix the branch by running:\n"
@@ -748,7 +748,7 @@ def _ProcessResults(_pool, _out, results):
748748
project.manifest.branch,
749749
)
750750
elif avail:
751-
pending.append(result)
751+
pending.append((project, avail))
752752
return pending
753753

754754
with self.ParallelContext():

0 commit comments

Comments
 (0)