mingw (t5580): document bug when cloning from backslashed UNC paths

dscho · dscho · commit 2b6f1cda3739 · 2018-05-29T19:25:42.000+02:00
Due to a quirk in Git's method to spawn git-upload-pack, there is a
problem when passing paths with backslashes in them: Git will force the
command-line through the shell, which has different quoting semantics in
Git for Windows (being an MSYS2 program) than regular Win32 executables
such as git.exe itself.

The symptom is that the first of the two backslashes in UNC paths of the
form \\myserver\folder\repository.git is *stripped off*.

Document this bug by introducing a test case.

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/t/t5580-clone-push-unc.sh b/t/t5580-clone-push-unc.sh
@@ -49,6 +49,11 @@ test_expect_success clone '
 	git clone "file://$UNCPATH" clone
 '
 
+test_expect_failure 'clone with backslashed path' '
+	BACKSLASHED="$(echo "$UNCPATH" | tr / \\\\)" &&
+	git clone "$BACKSLASHED" backslashed
+'
+
 test_expect_success push '
 	(
 		cd clone &&

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,11 @@ test_expect_success clone '`
`49`	`49`	`git clone "file://$UNCPATH" clone`
`50`	`50`	`'`
`51`	`51`
	`52`	`+test_expect_failure 'clone with backslashed path' '`
	`53`	`+ BACKSLASHED="$(echo "$UNCPATH" \| tr / \\\\)" &&`
	`54`	`+ git clone "$BACKSLASHED" backslashed`
	`55`	`+'`
	`56`	`+`
`52`	`57`	`test_expect_success push '`
`53`	`58`	`(`
`54`	`59`	`cd clone &&`