Skip to content

Commit 4382c36

Browse files
committed
t1300: mark all test cases with funny filenames as !MINGW
On Windows, it is impossible to create a file whose name contains a quote character. We already excluded test cases using such files from running on Windows when git.exe itself was tested. However, we still had two test cases that try to create such a file, and redirect stdin from such a file, respectively. This *seems* to work in Git for Windows' Bash due to an obscure feature inherited from Cygwin: illegal filename characters are simply mapped into/from a private UTF-8 page. Pure Win32 programs (such as git.exe) *still* cannot work with those files, of course, but at least Unix shell scripts pretend to be able to. This entire strategy breaks down when switching to any Unix shell lacking support for that private UTF-8 page trick, e.g. BusyBox-w32's ash. So let's just exclude test cases that test whether the Unix shell can redirect to/from files with "funny names" those from running on Windows, too. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent 6302935 commit 4382c36

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

t/t1300-repo-config.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1549,7 +1549,7 @@ test_expect_success '--show-origin getting a single key' '
15491549
test_cmp expect output
15501550
'
15511551

1552-
test_expect_success 'set up custom config file' '
1552+
test_expect_success !MINGW 'set up custom config file' '
15531553
CUSTOM_CONFIG_FILE="file\" (dq) and spaces.conf" &&
15541554
cat >"$CUSTOM_CONFIG_FILE" <<-\EOF
15551555
[user]
@@ -1565,7 +1565,7 @@ test_expect_success !MINGW '--show-origin escape special file name characters' '
15651565
test_cmp expect output
15661566
'
15671567

1568-
test_expect_success '--show-origin stdin' '
1568+
test_expect_success !MINGW '--show-origin stdin' '
15691569
cat >expect <<-\EOF &&
15701570
standard input: user.custom=true
15711571
EOF

0 commit comments

Comments
 (0)