http: stop leaking buffer in http_get_info_packs()

peff · gitster · commit 75f4acc98125 · 2024-09-25T10:24:55.000-07:00
We use http_get_strbuf() to fetch the remote info/packs content into a
strbuf, but never free it, causing a leak. There's no need to hold onto
it, as we've already parsed it completely.

This lets us mark t5619 as leak-free.

Signed-off-by: Jeff King &lt;peff@peff.net&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/http.c b/http.c
@@ -2475,6 +2475,7 @@ int http_get_info_packs(const char *base_url, struct packed_git **packs_head)
 
 cleanup:
 	free(url);
+	strbuf_release(&buf);
 	return ret;
 }
 
diff --git a/t/t5619-clone-local-ambiguous-transport.sh b/t/t5619-clone-local-ambiguous-transport.sh
@@ -2,6 +2,7 @@
 
 test_description='test local clone with ambiguous transport'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY/lib-httpd.sh"
 

Original file line number	Diff line number	Diff line change
`@@ -2475,6 +2475,7 @@ int http_get_info_packs(const char base_url, struct packed_git *packs_head)`
`2475`	`2475`
`2476`	`2476`	`cleanup:`
`2477`	`2477`	`free(url);`
	`2478`	`+ strbuf_release(&buf);`
`2478`	`2479`	`return ret;`
`2479`	`2480`	`}`
`2480`	`2481`