t0018: remove leftover debugging cruft

gitster · gitster · commit 7c7516b8db8b · 2024-08-01T11:52:11.000-07:00
The actual file is copied out to /tmp, presumably so that the tester
can inspect it after the test is done, which may have been a useful
debugging aid.

But in the final shape of the test suite, such a code should not
exist.  We cannot even assume that we are allowed to write into /tmp
(our TMPDIR may not even be pointing at it) or read from it for that
matter.

Noticed-by: Randall S. Becker &lt;rsbecker@nexbridge.com&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/t0018-advice.sh b/t/t0018-advice.sh
@@ -93,7 +93,6 @@ EOF
 		>README &&
 		GIT_ADVICE=true git status
 	) >actual &&
-	cat actual > /tmp/actual &&
 	test_cmp expect actual
 '
 

Original file line number	Diff line number	Diff line change
`@@ -93,7 +93,6 @@ EOF`
`93`	`93`	`>README &&`
`94`	`94`	`GIT_ADVICE=true git status`
`95`	`95`	`) >actual &&`
`96`		`- cat actual > /tmp/actual &&`
`97`	`96`	`test_cmp expect actual`
`98`	`97`	`'`
`99`	`98`