Skip to content

Commit c473af7

Browse files
committed
Merge branch 'st/verify-tag'
A few unterminated here documents in tests were fixed, which in turn revealed incorrect expectations the tests make. These tests have been updated. * st/verify-tag: t7004, t7030: fix here-doc syntax errors
2 parents 980ee77 + b42ca35 commit c473af7

File tree

2 files changed

+10
-14
lines changed

2 files changed

+10
-14
lines changed

t/t7004-tag.sh

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -895,18 +895,16 @@ test_expect_success GPG 'verifying a forged tag should fail' '
895895
test_must_fail git tag -v forged-tag
896896
'
897897

898-
test_expect_success 'verifying a proper tag with --format pass and format accordingly' '
899-
cat >expect <<-\EOF
898+
test_expect_success GPG 'verifying a proper tag with --format pass and format accordingly' '
899+
cat >expect <<-\EOF &&
900900
tagname : signed-tag
901-
EOF &&
901+
EOF
902902
git tag -v --format="tagname : %(tag)" "signed-tag" >actual &&
903903
test_cmp expect actual
904904
'
905905

906-
test_expect_success 'verifying a forged tag with --format fail and format accordingly' '
907-
cat >expect <<-\EOF
908-
tagname : forged-tag
909-
EOF &&
906+
test_expect_success GPG 'verifying a forged tag with --format should fail silently' '
907+
>expect &&
910908
test_must_fail git tag -v --format="tagname : %(tag)" "forged-tag" >actual &&
911909
test_cmp expect actual
912910
'

t/t7030-verify-tag.sh

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -125,18 +125,16 @@ test_expect_success GPG 'verify multiple tags' '
125125
test_cmp expect.stderr actual.stderr
126126
'
127127

128-
test_expect_success 'verifying tag with --format' '
129-
cat >expect <<-\EOF
128+
test_expect_success GPG 'verifying tag with --format' '
129+
cat >expect <<-\EOF &&
130130
tagname : fourth-signed
131-
EOF &&
131+
EOF
132132
git verify-tag --format="tagname : %(tag)" "fourth-signed" >actual &&
133133
test_cmp expect actual
134134
'
135135

136-
test_expect_success 'verifying a forged tag with --format fail and format accordingly' '
137-
cat >expect <<-\EOF
138-
tagname : 7th forged-signed
139-
EOF &&
136+
test_expect_success GPG 'verifying a forged tag with --format should fail silently' '
137+
>expect &&
140138
test_must_fail git verify-tag --format="tagname : %(tag)" $(cat forged1.tag) >actual-forged &&
141139
test_cmp expect actual-forged
142140
'

0 commit comments

Comments
 (0)