Skip to content

Commit 0c3749a

Browse files
committed
IPatchSeriesMetadata: the PR URL is not actually optional
It _used_ to be optional when there was also a way to run GitGitGadget in a local repository on a branch that had an upstream branch configured, in which case there was no PR to work with. But after I dropped the CLI in 6d397b0 (Remove support for the CLI mode, 2023-12-31), GitGitGadget really only works with PRs. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent c8d2ac9 commit 0c3749a

File tree

3 files changed

+3
-1
lines changed

3 files changed

+3
-1
lines changed

lib/patch-series-metadata.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
export interface IPatchSeriesMetadata {
2-
readonly pullRequestURL?: string;
2+
readonly pullRequestURL: string;
33
baseCommit: string;
44
baseLabel: string;
55
headCommit: string;

tests/patch-series.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ class PatchSeriesTest extends PatchSeries {
8787
const thisAuthor = "GitGitGadget <[email protected]>";
8888
const senderName = "Nguyễn Thái Ngọc Duy";
8989
const prMeta = {
90+
pullRequestURL: "",
9091
baseCommit: "",
9192
baseLabel: "",
9293
headCommit: "",

tests/project-options.test.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ test("project options", async () => {
3636
await class X extends PatchSeries {
3737
public static async test(): Promise<void> {
3838
const prMeta = {
39+
pullRequestURL: "",
3940
baseCommit: options2.baseCommit,
4041
baseLabel: "upstream/main",
4142
headCommit: options2.headCommit,

0 commit comments

Comments
 (0)