Merge branch 'retire-misc-helper-and-defaultConfig'

Various cleanups, some of them long overdue.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>

Author: dscho

lib/ci-helper.ts

@@ -33,7 +33,6 @@ import {
 } from "./pullRequestKey.js";
 import { ISMTPOptions } from "./send-mail.js";
 import { fileURLToPath } from "url";
-import defaultConfig from "./gitgitgadget-config.js";
 
 const readFile = util.promisify(fs.readFile);
 type CommentFunction = (comment: string) => Promise<void>;
@@ -65,11 +64,12 @@ export class CIHelper {
 
     public static validateConfig = typia.createValidate<IConfig>();
 
-    public static getConfigAsGitHubActionInput(): IConfig | undefined {
-        if (process.env.GITHUB_ACTIONS !== "true") return undefined;
+    public static getConfigAsGitHubActionInput(): IConfig {
+        if (process.env.GITHUB_ACTIONS !== "true") throw new Error(`Need a config!`);
         const json = core.getInput("config");
-        if (!json) return undefined;
+        if (!json) throw new Error(`Need a config!`);
         const config = JSON.parse(json) as IConfig | undefined;
+        if (!config) throw new Error(`Need a config!`);
         const result = CIHelper.validateConfig(config);
         if (result.success) return config;
         throw new Error(
@@ -80,7 +80,7 @@ export class CIHelper {
     }
 
     public constructor(workDir: string = "pr-repo.git", config?: IConfig, skipUpdate?: boolean, gggConfigDir = ".") {
-        this.config = config || CIHelper.getConfigAsGitHubActionInput() || defaultConfig;
+        this.config = config || CIHelper.getConfigAsGitHubActionInput();
         this.gggConfigDir = gggConfigDir;
         this.workDir = workDir;
         this.notes = new GitNotes(workDir);

lib/gitgitgadget-config.ts

@@ -1,5 +1,5 @@
 export interface IPatchSeriesMetadata {
-    readonly pullRequestURL?: string;
+    readonly pullRequestURL: string;
     baseCommit: string;
     baseLabel: string;
     headCommit: string;