Set project in the defaultConfig

We're about to make the config required, and not implicit, therefore it
makes sense to start with the project options for `gitgitgadget/git`
itself.

So let's set `project` explicitly in `defaultConfig` and remove the
implicit configuration of the `gitgitgadget/git` project from
`ProjectOptions.get()`.

There is a slight quirk here, as the Git GUI special-casing is a bit
magic: based on the presence of a specific file at the top-level of
`HEAD`'s root tree, it is determined that this is a Git GUI PR rather
than a git/git PR.

Now, we _could_ introduce some new attribute of the `projectInfo` type
that would allow the same kind of trick for other projects. As per
gitgitgadget#1988 (comment)
though, no other project using GitGitGadget may ever need that, so we'll
still hard-code it for `gitgitgadget/git` (and `git/git`) specifically.

Signed-off-by: Johannes Schindelin <[email protected]>

Author: dscho

lib/gitgitgadget-config.ts

@@ -29,6 +29,14 @@ const defaultConfig: IConfig = {
         smtpUser: "[email protected]",
         smtpHost: "smtp.gmail.com",
     },
+    project: {
+        // The Git maintainer specifically requested not to be Cc:ed, see
+        // b2221f4e (Stop Cc:ing the Git maintainer, 2020-01-08) for specifics,
+        // hence no `cc: "Junio Hamano <[email protected]>"`
+        cc: [],
+        to: "[email protected]",
+        urlPrefix: "https://lore.kernel.org/git/",
+    },
     app: {
         appID: 12836,
         installationID: 195971,

lib/project-options.ts

@@ -22,15 +22,12 @@ export class ProjectOptions {
             for (const user of project.cc) {
                 cc.push(user);
             }
-        } else if ((await revParse(`${baseCommit}:git-gui.sh`, workDir)) !== undefined) {
-            // Git GUI
-            to = "[email protected]";
-            cc.push("Johannes Sixt <[email protected]>");
-        } else if ((await revParse(`${baseCommit}:git.c`, workDir)) !== undefined) {
-            // Git
-            to = "[email protected]";
-            // Do *not* Cc: Junio Hamano by default
-            midUrlPrefix = "https://lore.kernel.org/git/";
+            // Hard-code a check for gitgitgadget/git whether this is a Git GUI PR
+            // and hence needs the Git GUI maintainer to be Cc:ed
+            if (
+                `${config.repo.owner}/${config.repo.name}` === "gitgitgadget/git" &&
+                (await revParse(`${baseCommit}:git-gui.sh`, workDir)) !== undefined
+            ) {
         } else if ((await revParse(`${baseCommit}:winsup`, workDir)) !== undefined) {
             // Cygwin
             to = "[email protected]";