Skip to content

Commit b49c1c5

Browse files
committed
/submit: use correct URL in the "Submitted as" message
Currently this URL is constructed from the `host` and the `name` attributes of the project config setting's `mailrepo` attribute. However, the `name` is supposed to refer to the mailing list _mirror repository_, while we are interested in the URL where the web UI of the public-inbox instance lives. Luckily, we already have that in the project configuration: It's the `url` attribute. I noticed the need for this patch in cygwingitgadget/cygwin#1, where the URL displayed after submitting v1 pointed to an incorrect location. Signed-off-by: Johannes Schindelin <[email protected]>
1 parent f77fb14 commit b49c1c5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/ci-helper.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -909,7 +909,7 @@ export class CIHelper {
909909
await addComment(
910910
`Submitted as [${
911911
metadata?.coverLetterMessageId
912-
}](https://${this.config.mailrepo.host}/${this.config.mailrepo.name}/${
912+
}](${this.config.mailrepo.url.replace(/\/+$/, "")}/${
913913
metadata?.coverLetterMessageId
914914
})\n\nTo fetch this version into \`FETCH_HEAD\`:${
915915
code

0 commit comments

Comments
 (0)