Merge pull request gitgitgadget#1786 from gitgitgadget/dependabot/npm_and_yarn/json-stable-stringify-1.2.1

build(deps): bump json-stable-stringify from 1.1.1 to 1.2.1

Author: dscho

.vscode/launch.json

@@ -34,6 +34,7 @@
             "name": "Jest Debug Current File",
             "type": "node",
             "request": "launch",
+            "runtimeArgs": [ "--experimental-vm-modules" ],
             "program": "${workspaceFolder}/node_modules/jest/bin/jest.js",
             "args": [
                 "--runInBand",

lib/json-util.ts

@@ -5,9 +5,13 @@ export function fromJSON<T>(input: string): T {
 }
 
 export function toJSON<T>(input: T): string {
-    return stringify(input);
+    const result = stringify(input);
+    if (typeof result !== "string") throw new Error(`Could not convert ${input} to JSON`);
+    return result;
 }
 
 export function toPrettyJSON<T>(input: T): string {
-    return stringify(input, { space: 4 });
+    const result = stringify(input, { space: 4 });
+    if (typeof result !== "string") throw new Error(`Could not convert ${input} to JSON`);
+    return result;
 }

package-lock.json

@@ -80,7 +80,7 @@
     "commander": "^12.1.0",
     "dugite": "^2.7.1",
     "html-to-text": "^9.0.5",
-    "json-stable-stringify": "^1.1.1",
+    "json-stable-stringify": "^1.2.1",
     "jsonwebtoken": "^9.0.2",
     "mailparser": "^3.7.2",
     "marked": "^15.0.4",

package.json

@@ -1,7 +1,7 @@
 import { expect, jest, test } from "@jest/globals";
 import { fileURLToPath } from "url";
 import { isDirectory } from "../lib/fs-util.js";
-import { git, revParse } from "../lib/git.js";
+import { emptyBlobName, git, revParse } from "../lib/git.js";
 import { GitNotes } from "../lib/git-notes.js";
 import { IPatchSeriesMetadata } from "../lib/patch-series-metadata.js";
 import { testCreateRepo } from "./test-lib.js";
@@ -23,6 +23,14 @@ test("set/get notes", async () => {
     expect(await git(["log", "-p", "refs/notes/gitgitgadget"], { workDir: repo.workDir })).toMatch(/\n\+hello$/);
 
     const gitURL = "https://github.com/gitgitgadget/git";
+    // avoid network calls during tests
+    const fakeRemote = `${repo.workDir}/.git/fake-remote`;
+    await git(["init", "--bare", fakeRemote]);
+    await git([`--git-dir=${fakeRemote}`, "notes", "--ref=gitgitgadget", "add", "-m", "{}", emptyBlobName]);
+    await git([`--git-dir=${fakeRemote}`, "notes", "--ref=mail-to-commit", "add", "-m", "1", emptyBlobName]);
+    await git([`--git-dir=${fakeRemote}`, "notes", "--ref=commit-to-mail", "add", "-m", "1", emptyBlobName]);
+    await git(["config", `url.${fakeRemote}.insteadof`, gitURL], { workDir: repo.workDir });
+
     const pullRequestURL = `${gitURL}/git/pull/1`;
     const metadata: IPatchSeriesMetadata = {
         baseCommit: "0123456789012345678901234567890123456789",