fixup! Instead of creating Cygwin symlinks, use deep copy by default

dscho · dscho · commit fa6f2c28b1b5 · 2025-01-26T21:51:18.000+01:00
I totally messed up converting `!isdevice ()` to `ondisk ()`,
_inverting_ the logic (which obviously has _got_ to fail).

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/winsup/cygwin/path.cc b/winsup/cygwin/path.cc
@@ -2320,7 +2320,7 @@ symlink_worker (const char *oldpath, path_conv &win32_newpath, bool isdevice)
 		  set_errno (src_path.error);
 		  __leave;
 		}
-	      if (!src_path.isondisk ())
+	      if (src_path.isondisk ())
 	        {
 		  /* MSYS copy file instead make symlink */
 

Original file line number	Diff line number	Diff line change
`@@ -2320,7 +2320,7 @@ symlink_worker (const char *oldpath, path_conv &win32_newpath, bool isdevice)`
`2320`	`2320`	`set_errno (src_path.error);`
`2321`	`2321`	`__leave;`
`2322`	`2322`	`}`
`2323`		`- if (!src_path.isondisk ())`
	`2323`	`+ if (src_path.isondisk ())`
`2324`	`2324`	`{`
`2325`	`2325`	`/* MSYS copy file instead make symlink */`
`2326`	`2326`