Move some Module object assertions. NFC (emscripten-core#23995)

This moves these assertion alongside other similar checks.

Author: sbc100

src/preamble.js

@@ -150,10 +150,6 @@ var isFileURI = (filename) => filename.startsWith('file://');
 
 #include "runtime_shared.js"
 
-#if ASSERTIONS
-assert(!Module['STACK_SIZE'], 'STACK_SIZE can no longer be set at runtime.  Use -sSTACK_SIZE at link time')
-#endif
-
 #if ASSERTIONS
 assert(typeof Int32Array != 'undefined' && typeof Float64Array !== 'undefined' && Int32Array.prototype.subarray != undefined && Int32Array.prototype.set != undefined,
        'JS engine does not provide full typed array support');

src/runtime_debug.js

@@ -16,10 +16,6 @@
 })();
 #endif
 
-if (Module['ENVIRONMENT']) {
-  throw new Error('Module.ENVIRONMENT has been deprecated. To force the environment, use the ENVIRONMENT compile-time option (for example, -sENVIRONMENT=web or -sENVIRONMENT=node)');
-}
-
 function legacyModuleProp(prop, newName, incoming=true) {
   if (!Object.getOwnPropertyDescriptor(Module, prop)) {
     Object.defineProperty(Module, prop, {

src/shell.js

@@ -423,6 +423,9 @@ assert(typeof Module['readAsync'] == 'undefined', 'Module.readAsync option was r
 assert(typeof Module['readBinary'] == 'undefined', 'Module.readBinary option was removed (modify readBinary in JS)');
 assert(typeof Module['setWindowTitle'] == 'undefined', 'Module.setWindowTitle option was removed (modify emscripten_set_window_title in JS)');
 assert(typeof Module['TOTAL_MEMORY'] == 'undefined', 'Module.TOTAL_MEMORY has been renamed Module.INITIAL_MEMORY');
+assert(typeof Module['ENVIRONMENT'] == 'undefined', 'Module.ENVIRONMENT has been deprecated. To force the environment, use the ENVIRONMENT compile-time option (for example, -sENVIRONMENT=web or -sENVIRONMENT=node)');
+assert(typeof Module['STACK_SIZE'] == 'undefined', 'STACK_SIZE can no longer be set at runtime.  Use -sSTACK_SIZE at link time')
+
 {{{ makeRemovedModuleAPIAssert('asm', 'wasmExports', false) }}}
 {{{ makeRemovedModuleAPIAssert('readAsync') }}}
 {{{ makeRemovedModuleAPIAssert('readBinary') }}}

test/other/codesize/test_codesize_hello_O0.gzsize

@@ -1 +1 @@
-7956
+7940

test/other/codesize/test_codesize_hello_O0.jssize

@@ -1 +1 @@
-21272
+21295

test/other/codesize/test_codesize_minimal_O0.gzsize

@@ -1 +1 @@
-6297
+6284

test/other/codesize/test_codesize_minimal_O0.jssize

@@ -1 +1 @@
-16628
+16651

test/other/test_unoptimized_code_size.js.size

@@ -1 +1 @@
-52217
+52240

test/other/test_unoptimized_code_size_strict.js.size

@@ -1 +1 @@
-50430
+50453