Skip to content

Commit 2840bec

Browse files
authored
Merge pull request #1021 from rubenporras/upgradePMD
build: upgrade to PMD 7.7
2 parents 1723b47 + 0f81008 commit 2840bec

File tree

3 files changed

+11
-10
lines changed

3 files changed

+11
-10
lines changed

.github/workflows/verify.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
1414
id: pmd
1515
with:
16-
version: '7.5.0'
16+
version: '7.7.0'
1717
rulesets: 'ddk-configuration/pmd/ruleset.xml'
1818
analyzeModifiedFilesOnly: false
1919
- name: Fail build if there are violations

ddk-configuration/pmd/ruleset.xml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -73,15 +73,16 @@
7373
<exclude name="AccessorMethodGeneration"/>
7474
<exclude name="AvoidReassigningParameters"/>
7575
<exclude name="UnusedPrivateMethod"/><!-- false positives-->
76-
<exclude name="DefaultLabelNotLastInSwitchStmt"/>
76+
<exclude name="DefaultLabelNotLastInSwitch"/>
7777
<exclude name="ForLoopCanBeForeach"/>
7878
<exclude name="GuardLogStatement"/><!--TODO-->
79-
<exclude name="JUnitTestContainsTooManyAsserts"/><!--New after PMD 5.3 upgrade, limitation to 1 assert not sensible, would need customization, disabled for the time being-->
80-
<exclude name="JUnitTestsShouldIncludeAssert"/>
81-
<exclude name="JUnit4TestShouldUseAfterAnnotation"/><!--Checkstyle-->
82-
<exclude name="JUnit4TestShouldUseBeforeAnnotation"/><!--Checkstyle-->
83-
<exclude name="JUnit4TestShouldUseTestAnnotation"/>
84-
<exclude name="SwitchStmtsShouldHaveDefault"/>
79+
<exclude name="UnitTestAssertionsShouldIncludeMessage"/>
80+
<exclude name="UnitTestContainsTooManyAsserts"/><!--New after PMD 5.3 upgrade, limitation to 1 assert not sensible, would need customization, disabled for the time being-->
81+
<exclude name="UnitTestShouldIncludeAssert"/>
82+
<exclude name="UnitTestShouldUseAfterAnnotation"/><!--Checkstyle-->
83+
<exclude name="UnitTestShouldUseBeforeAnnotation"/><!--Checkstyle-->
84+
<exclude name="UnitTestShouldUseTestAnnotation"/>
85+
<exclude name="NonExhaustiveSwitch"/>
8586
<exclude name="PreserveStackTrace"/><!--TODO-->
8687
<exclude name="UnusedLocalVariable"/><!--Checkstyle-->
8788
<exclude name="UseTryWithResources"/><!--TODO-->
@@ -125,7 +126,7 @@
125126
<exclude name="ConsecutiveLiteralAppends"/>
126127
<exclude name="OptimizableToArrayCall"/>
127128
<exclude name="RedundantFieldInitializer"/><!--Checkstyle-->
128-
<exclude name="TooFewBranchesForASwitchStatement"/>
129+
<exclude name="TooFewBranchesForSwitch"/>
129130
</rule>
130131

131132
</ruleset>

ddk-parent/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
<spotbugs.plugin.version>4.8.6.5</spotbugs.plugin.version>
5454
<spotbugs.version>4.8.6</spotbugs.version>
5555
<pmd.plugin.version>3.25.0</pmd.plugin.version>
56-
<pmd.version>7.6.0</pmd.version>
56+
<pmd.version>7.7.0</pmd.version>
5757
<tycho.version>4.0.9</tycho.version>
5858
<xtend.version>2.36.0</xtend.version>
5959
</properties>

0 commit comments

Comments
 (0)