Skip to content

Commit 6f4eb7d

Browse files
committed
feat: enable PMD UnusedFormalParameter and Checkstyle's JavadocMethod checks
1 parent 689dfe4 commit 6f4eb7d

File tree

2 files changed

+20
-2
lines changed

2 files changed

+20
-2
lines changed

ddk-configuration/checkstyle/avaloq.xml

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,23 @@
7070
<module name="IllegalImport"/>
7171
<module name="IllegalThrows"/>
7272
<module name="InterfaceIsType"/>
73+
<!-- Internal methods: allow @Override and @Inject; still validate tags when javadoc is present -->
7374
<module name="JavadocMethod">
75+
<property name="accessModifiers" value="package,private"/>
76+
<!-- Cover methods + constructors + compact constructors -->
77+
<property name="tokens" value="METHOD_DEF,CTOR_DEF,COMPACT_CTOR_DEF"/>
7478
<property name="allowedAnnotations" value="Override,Inject"/>
75-
<property name="accessModifiers" value="package"/>
76-
<property name="tokens" value="METHOD_DEF"/>
79+
<property name="allowMissingParamTags" value="false"/>
80+
<property name="allowMissingReturnTag" value="false"/>
81+
<property name="validateThrows" value="true"/>
82+
</module>
83+
<!-- Public API: enforce tags; no @Inject exemption -->
84+
<module name="JavadocMethod">
85+
<property name="accessModifiers" value="public,protected"/>
86+
<property name="tokens" value="METHOD_DEF,CTOR_DEF,COMPACT_CTOR_DEF"/>
87+
<property name="allowMissingParamTags" value="false"/>
88+
<property name="allowMissingReturnTag" value="false"/>
89+
<property name="validateThrows" value="true"/>
7790
</module>
7891
<module name="JavadocType"/>
7992
<module name="JavadocStyle"/>

ddk-configuration/pmd/ruleset.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,6 +90,11 @@
9090
<exclude name="UseTryWithResources"/><!--TODO-->
9191
<exclude name="JUnit5TestShouldBePackagePrivate"/>
9292
</rule>
93+
<rule ref="category/java/bestpractices.xml/UnusedFormalParameter">
94+
<properties>
95+
<property name="checkAll" value="true" />
96+
</properties>
97+
</rule>
9398
<rule ref="category/java/codestyle.xml">
9499
<exclude name="AtLeastOneConstructor"/>
95100
<exclude name="CallSuperInConstructor"/>

0 commit comments

Comments
 (0)