chore: address PMD markers

Author: joaodinissf

com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java

@@ -195,6 +195,7 @@ protected void internalToConvertedExpression(final XExpression obj, final ITreeA
   }
 
   // CHECKSTYLE:OFF
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   protected void _toJavaStatement(final XGuardExpression expr, final ITreeAppendable b, final boolean isReferenced) {
     // CHECKSTYLE:ON
     internalToJavaStatement(expr.getGuard(), b, true);

com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java

@@ -26,6 +26,7 @@ public class DummyCheckContext extends AbstractCheckContext {
    * @return {@code true} always
    */
   @CheckContext(issueCodes = {CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE})
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public boolean enableForEnabledDisabledCode(final EObject context) {
     return ENABLED;
   }
@@ -39,6 +40,7 @@ public boolean enableForEnabledDisabledCode(final EObject context) {
    */
   @CheckContext(issueCodes = {CheckContextTest.DISABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE,
       CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE})
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public boolean disableForCodes(final EObject context) {
     return DISABLED;
   }
@@ -51,6 +53,7 @@ public boolean disableForCodes(final EObject context) {
    * @return {@code true} always
    */
   @CheckContext(issueCodes = {CheckContextTest.ENABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE})
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public boolean enabledForCodes(final EObject context) {
     return ENABLED;
   }

com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java

@@ -127,6 +127,7 @@ private String getLanguage(final URI uri) {
    *          the context object of the validation being executed
    * @return the configuration store instance
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   protected ICheckConfigurationStore internalGetCheckConfigurationStore(final Object context) {
     if (configurationStore == null) {
       configurationStore = new CheckConfigurationStore(DEFAULT_CHECK_CONFIGURATION_NODE);

com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java

@@ -109,7 +109,7 @@ public interface DiagnosticCollector extends ValidationMessageAcceptor {
    * @param eventCollector
    *          an event collector for collecting validation events, may be {@code null}
    */
-  @SuppressWarnings("checkstyle:IllegalCatch")
+  @SuppressWarnings({"checkstyle:IllegalCatch", "PMD.UnusedFormalParameter"})
   protected void validate(final String contextName, final String qContextName, final EObject object, final Runnable checkAction, final DiagnosticCollector diagnosticCollector, final ResourceValidationRuleSummaryEvent.Collector eventCollector) {
     if (!disabledMethodTracker.isDisabled(contextName)) {
       try {

com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java

@@ -99,7 +99,7 @@ private String ruleName(final MethodWrapper method) {
    *          the context
    * @return true, if successful
    */
-  @SuppressWarnings("PMD.NPathComplexity")
+  @SuppressWarnings({"PMD.NPathComplexity", "PMD.UnusedFormalParameter"})
   protected final boolean internalValidate(final EClass class1, final EObject object, final DiagnosticChain diagnostics, final Map<Object, Object> context) {
     initCheckMethodCache();
 

com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java

@@ -111,6 +111,7 @@ protected void handleChangedContents(final Delta delta, final IBuildContext cont
    * @param context
    *          build context
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   protected void handleDeletion(final Delta delta, final IBuildContext context) {
     if (hasCorrectExtension(delta, resourceServiceProvider)) {
       try {

com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java

@@ -142,6 +142,7 @@ protected <T> T getFromServiceProvider(final Class<T> type, final URI uri) {
    *         have changed before the builder participant kicks
    *         in.
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   protected boolean isExtensionUpdateRequired(final CheckCatalog catalog, final IPluginExtension extension, final Iterable<IPluginElement> elements) {
     return extension.getPoint().equals(getExtensionPointId()); // if points are different, given extension must not be updated
   }
@@ -214,6 +215,7 @@ public IPluginExtension addExtensionToPluginBase(final IPluginModelBase base, fi
    *          the extension id
    * @return true, if the extension should be enabled
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   protected boolean isExtensionEnabled(final IPluginModelBase base, final CheckCatalog catalog, final ExtensionType type, final String extensionId) {
     if (type == ExtensionType.MARKERHELP) {
       return false; // disabled until https://bugs.eclipse.org/bugs/show_bug.cgi?id=369534 is fixed

com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java

@@ -272,6 +272,7 @@ public ExtensionType apply(final IPluginExtension from) {
    * @throws CoreException
    *           the core exception
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public void updateExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
     QualifiedName catalogName = nameProvider.apply(catalog);
     Collection<IPluginExtension> catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL);
@@ -296,6 +297,7 @@ public void updateExtensions(final CheckCatalog catalog, final IPluginModelBase
    * @throws CoreException
    *           the core exception
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public void addExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
     QualifiedName catalogName = nameProvider.apply(catalog);
     Collection<IPluginExtension> catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL);
@@ -324,6 +326,7 @@ public void addExtensions(final CheckCatalog catalog, final IPluginModelBase plu
    * @throws CoreException
    *           the core exception
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public void removeExtensions(final IEObjectDescription obj, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
     for (IPluginExtension extension : findExtensions(pluginModel, obj.getName(), ExtensionType.ALL)) {
       final ExtensionType extensionType = getExtensionType(extension);
@@ -344,6 +347,7 @@ public void removeExtensions(final IEObjectDescription obj, final IPluginModelBa
    * @throws CoreException
    *           the core exception
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public void removeExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
     QualifiedName name = nameConverter.toQualifiedName(projectUtil.getCatalogQualifiedName(catalog));
     for (IPluginExtension extension : findExtensions(pluginModel, name, ExtensionType.ALL)) {
@@ -362,6 +366,7 @@ public void removeExtensions(final CheckCatalog catalog, final IPluginModelBase
    * @throws CoreException
    *           the core exception
    */
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   public void sortAllExtensions(final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
     Ordering<IPluginExtension> ordering = Ordering.from((a, b) -> ComparisonChain.start().compare(a.getPoint(), b.getPoint()).compare(a.getId(), b.getId(), Ordering.natural().nullsLast()).compare(a.getName(), b.getName(), Ordering.natural().nullsLast()).result());
     List<IPluginExtension> catalogExtensions = Lists.newArrayList(findAllExtensions(pluginModel));

com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java

@@ -67,7 +67,7 @@ public void generateDefaultQuickfixProvider(final IPath path, final CheckProject
    * @param projectInfo
    *          the project info
    */
-  @SuppressWarnings("nls")
+  @SuppressWarnings({"nls", "PMD.UnusedFormalParameter"})
   public void generateDocsDirectory(final IPath path, final CheckProjectInfo projectInfo) {
     fsa.setOutputPath(path.toOSString());
     // IFileSystemAccess doesn't support creating empty directories, so:

com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java

@@ -111,6 +111,7 @@ protected void _createProposals(final Keyword keyword, final ContentAssistContex
     super._createProposals(keyword, context, acceptor);
   }
 
+  @SuppressWarnings("PMD.UnusedFormalParameter")
   protected void completeLanguages(final EObject model, final ContentAssistContext context, final IIdeContentProposalAcceptor acceptor) {
     for (String language : checkCfgUtil.getAllLanguages()) {
       ContentAssistEntry entry = getProposalCreator().createProposal(language, context, (final ContentAssistEntry it) -> {