Skip to content

Commit f2baa24

Browse files
joaodinissfjoaodinissf
committed
chore: address PMD markers
diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java index f6c1c11..c775964 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java @@ -195,6 +195,7 @@ public class CheckCompiler extends XbaseCompiler { } // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected void _toJavaStatement(final XGuardExpression expr, final ITreeAppendable b, final boolean isReferenced) { // CHECKSTYLE:ON internalToJavaStatement(expr.getGuard(), b, true); diff --git a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java index 14e6df3..68d41a6 100644 --- a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java +++ b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java @@ -26,6 +26,7 @@ public class DummyCheckContext extends AbstractCheckContext { * @return {@code true} always */ @CheckContext(issueCodes = {CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE}) + @SuppressWarnings("PMD.UnusedFormalParameter") public boolean enableForEnabledDisabledCode(final EObject context) { return ENABLED; } @@ -39,6 +40,7 @@ public class DummyCheckContext extends AbstractCheckContext { */ @CheckContext(issueCodes = {CheckContextTest.DISABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE, CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE}) + @SuppressWarnings("PMD.UnusedFormalParameter") public boolean disableForCodes(final EObject context) { return DISABLED; } @@ -51,6 +53,7 @@ public class DummyCheckContext extends AbstractCheckContext { * @return {@code true} always */ @CheckContext(issueCodes = {CheckContextTest.ENABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE}) + @SuppressWarnings("PMD.UnusedFormalParameter") public boolean enabledForCodes(final EObject context) { return ENABLED; } diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java index 32db905..a1773a1 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java @@ -127,6 +127,7 @@ public class CheckConfigurationStoreService implements ICheckConfigurationStoreS * the context object of the validation being executed * @return the configuration store instance */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected ICheckConfigurationStore internalGetCheckConfigurationStore(final Object context) { if (configurationStore == null) { configurationStore = new CheckConfigurationStore(DEFAULT_CHECK_CONFIGURATION_NODE); diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java index 698514f..5678c21 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java @@ -109,7 +109,7 @@ public abstract class AbstractDispatchingCheckImpl extends AbstractCheckImpl { * @param eventCollector * an event collector for collecting validation events, may be {@code null} */ - @SuppressWarnings("checkstyle:IllegalCatch") + @SuppressWarnings({"checkstyle:IllegalCatch", "PMD.UnusedFormalParameter"}) protected void validate(final String contextName, final String qContextName, final EObject object, final Runnable checkAction, final DiagnosticCollector diagnosticCollector, final ResourceValidationRuleSummaryEvent.Collector eventCollector) { if (!disabledMethodTracker.isDisabled(contextName)) { try { diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java index 6928a34..96caba6 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java @@ -99,7 +99,7 @@ public abstract class DefaultCheckImpl extends AbstractStatefulCheckImpl { * the context * @return true, if successful */ - @SuppressWarnings("PMD.NPathComplexity") + @SuppressWarnings({"PMD.NPathComplexity", "PMD.UnusedFormalParameter"}) protected final boolean internalValidate(final EClass class1, final EObject object, final DiagnosticChain diagnostics, final Map<Object, Object> context) { initCheckMethodCache(); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java index dd75a86..1682ba1 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java @@ -111,6 +111,7 @@ public class CheckBuilderParticipant extends ConditionalBuilderParticipant { * @param context * build context */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void handleDeletion(final Delta delta, final IBuildContext context) { if (hasCorrectExtension(delta, resourceServiceProvider)) { try { diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java index 28ff2ac..e7fb723 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java @@ -142,6 +142,7 @@ public abstract class AbstractCheckExtensionHelper implements ICheckExtensionHel * have changed before the builder participant kicks * in. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean isExtensionUpdateRequired(final CheckCatalog catalog, final IPluginExtension extension, final Iterable<IPluginElement> elements) { return extension.getPoint().equals(getExtensionPointId()); // if points are different, given extension must not be updated } @@ -214,6 +215,7 @@ public abstract class AbstractCheckExtensionHelper implements ICheckExtensionHel * the extension id * @return true, if the extension should be enabled */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean isExtensionEnabled(final IPluginModelBase base, final CheckCatalog catalog, final ExtensionType type, final String extensionId) { if (type == ExtensionType.MARKERHELP) { return false; // disabled until https://bugs.eclipse.org/bugs/show_bug.cgi?id=369534 is fixed diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java index 3b8a1ac..6a7cc8b 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java @@ -272,6 +272,7 @@ public class CheckExtensionHelperManager { * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void updateExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { QualifiedName catalogName = nameProvider.apply(catalog); Collection<IPluginExtension> catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL); @@ -296,6 +297,7 @@ public class CheckExtensionHelperManager { * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void addExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { QualifiedName catalogName = nameProvider.apply(catalog); Collection<IPluginExtension> catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL); @@ -324,6 +326,7 @@ public class CheckExtensionHelperManager { * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void removeExtensions(final IEObjectDescription obj, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { for (IPluginExtension extension : findExtensions(pluginModel, obj.getName(), ExtensionType.ALL)) { final ExtensionType extensionType = getExtensionType(extension); @@ -344,6 +347,7 @@ public class CheckExtensionHelperManager { * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void removeExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { QualifiedName name = nameConverter.toQualifiedName(projectUtil.getCatalogQualifiedName(catalog)); for (IPluginExtension extension : findExtensions(pluginModel, name, ExtensionType.ALL)) { @@ -362,6 +366,7 @@ public class CheckExtensionHelperManager { * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void sortAllExtensions(final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { Ordering<IPluginExtension> ordering = Ordering.from((a, b) -> ComparisonChain.start().compare(a.getPoint(), b.getPoint()).compare(a.getId(), b.getId(), Ordering.natural().nullsLast()).compare(a.getName(), b.getName(), Ordering.natural().nullsLast()).result()); List<IPluginExtension> catalogExtensions = Lists.newArrayList(findAllExtensions(pluginModel)); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java index a2111de..6c215d9 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java @@ -67,7 +67,7 @@ public class CheckCatalogGenerator { * @param projectInfo * the project info */ - @SuppressWarnings("nls") + @SuppressWarnings({"nls", "PMD.UnusedFormalParameter"}) public void generateDocsDirectory(final IPath path, final CheckProjectInfo projectInfo) { fsa.setOutputPath(path.toOSString()); // IFileSystemAccess doesn't support creating empty directories, so: diff --git a/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java b/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java index 031db95..527e7b3 100644 --- a/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java +++ b/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java @@ -111,6 +111,7 @@ public class CheckCfgIdeContentProposalProvider extends XbaseIdeContentProposalP super._createProposals(keyword, context, acceptor); } + @SuppressWarnings("PMD.UnusedFormalParameter") protected void completeLanguages(final EObject model, final ContentAssistContext context, final IIdeContentProposalAcceptor acceptor) { for (String language : checkCfgUtil.getAllLanguages()) { ContentAssistEntry entry = getProposalCreator().createProposal(language, context, (final ContentAssistEntry it) -> { diff --git a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java index fe9632a..dbb65d1 100644 --- a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java @@ -110,6 +110,7 @@ public class CheckCfgOutlineTreeProvider extends DefaultOutlineTreeProvider { * @return {@code true} */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final ConfiguredCheck modelElement) { // CHECKSTYLE:ON return true; diff --git a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java index eebfd69..6b586e8 100644 --- a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java +++ b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java @@ -47,6 +47,7 @@ public abstract class AbstractTypeLabelProvider implements ITypeLabelProvider { * exception encountered by the dispatcher. * @return default text for a null value if exception was a NullPointerException, else wraps and throws exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected String handleTextError(final Object[] params, final Throwable e) { if (e instanceof NullPointerException) { return text(null); @@ -66,6 +67,7 @@ public abstract class AbstractTypeLabelProvider implements ITypeLabelProvider { * a null value * @return the label for {@code type} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected String text(final Void type) { return "<null>"; //$NON-NLS-1$ } diff --git a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java index 7c938da..b50f633 100644 --- a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java +++ b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java @@ -409,6 +409,7 @@ public abstract class AbstractTypeProvider implements ITypeProvider { * the expression to get the type for * @return the type of {@code expression} if it can be computed; otherwise null. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType handleCyclicGetType(final IExpression expression) { return null; } @@ -423,6 +424,7 @@ public abstract class AbstractTypeProvider implements ITypeProvider { * the expression to compute the type for * @return the type of {@code expression} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType type(final IExpression expression) { return null; } @@ -475,6 +477,7 @@ public abstract class AbstractTypeProvider implements ITypeProvider { * the expression to get the expected type for * @return the expected type of {@code expression} if it can be computed; otherwise null. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType handleCycleGetExpectedType(final IExpression expression) { return null; } @@ -494,6 +497,7 @@ public abstract class AbstractTypeProvider implements ITypeProvider { * if {@code reference} is a list, then the index within that list; otherwise -1 * @return the expected type of {@code expression} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType expectedType(final EObject container, final EReference reference, final int index) { return null; } @@ -541,6 +545,7 @@ public abstract class AbstractTypeProvider implements ITypeProvider { * the named element to get the type for * @return the type of {@code element} if it can be computed; otherwise null. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType handleCycleGetTypeForNamedElement(final INamedElement element) { return null; } @@ -555,6 +560,7 @@ public abstract class AbstractTypeProvider implements ITypeProvider { * the named element to compute the type for * @return the type of {@code element} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType typeForNamedElement(final INamedElement element) { return null; } @@ -631,6 +637,7 @@ public abstract class AbstractTypeProvider implements ITypeProvider { * the object to get the provider for * @return the type provider for {@code eObject} or {@code null} if it is not known. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected ITypeProvider getTypeProviderFor(final EObject eObject) { return null; } diff --git a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java index b3a26bf..dc504d1 100644 --- a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java +++ b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java @@ -36,6 +36,7 @@ public final class ResourceLoaderProviders { * degree * @return parallel resource loader */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static Provider<IResourceLoader> getParallelLoader(final int nrOfThreads) { int nProcessors = Runtime.getRuntime().availableProcessors(); // CHECKSTYLE:CONSTANTS-OFF diff --git a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java index 624ad7d..279254b 100644 --- a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java @@ -119,6 +119,7 @@ public class ExportLabelProvider extends DefaultEObjectLabelProvider { * the import * @return the import image */ + @SuppressWarnings("PMD.UnusedFormalParameter") Image image(final Import impaurt) { return JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPDECL); } diff --git a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java index a676a8a..4a39120 100644 --- a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java @@ -61,6 +61,7 @@ public class ExportOutlineTreeProvider extends DefaultOutlineTreeProvider { * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final Interface modelElement) { // CHECKSTYLE:ON return true; @@ -74,6 +75,7 @@ public class ExportOutlineTreeProvider extends DefaultOutlineTreeProvider { * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final Export modelElement) { // CHECKSTYLE:ON return true; diff --git a/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java b/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java index aaccae9..fa37391 100644 --- a/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java @@ -87,6 +87,7 @@ public class ExportScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EClass(final ExportModel context, final EReference reference) { // CHECKSTYLE:ON IScope result = IScope.NULLSCOPE; @@ -117,6 +118,7 @@ public class ExportScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EStructuralFeature(final DeclarationForType context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getType(); @@ -136,6 +138,7 @@ public class ExportScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EAttribute(final DeclarationForType context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getType(); @@ -155,6 +158,7 @@ public class ExportScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_InterfaceNavigation_ref(final Interface context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getType(); diff --git a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java index f6c796f..7c7ce4e 100644 --- a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java @@ -42,6 +42,7 @@ public class FormatLabelProvider extends XbaseLabelProvider { * the element * @return the string */ + @SuppressWarnings("PMD.UnusedFormalParameter") public String text(final WildcardRule element) { return "*"; //$NON-NLS-1$ } diff --git a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java index 2700384..210bfb0 100644 --- a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java @@ -95,6 +95,7 @@ public class ScopeLabelProvider extends DefaultEObjectLabelProvider { * the import * @return the import image */ + @SuppressWarnings("PMD.UnusedFormalParameter") Image image(final Import impaurt) { return JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPDECL); } diff --git a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java index 2d2aafe..04e4f15 100644 --- a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java @@ -59,6 +59,7 @@ public class ScopeOutlineTreeProvider extends DefaultOutlineTreeProvider { * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final Expression modelElement) { // CHECKSTYLE:ON return true; @@ -72,6 +73,7 @@ public class ScopeOutlineTreeProvider extends DefaultOutlineTreeProvider { * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final ScopeRule modelElement) { // CHECKSTYLE:ON return true; diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java index c90bb36..ca1fba7 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java @@ -105,6 +105,7 @@ public class ScopeScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EClass(final ScopeModel context, final EReference reference) { // CHECKSTYLE:ON IScope result = IScope.NULLSCOPE; @@ -125,6 +126,7 @@ public class ScopeScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_ScopeContext_reference(final ScopeContext context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getContextType(); @@ -144,6 +146,7 @@ public class ScopeScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_ScopeDefinition_reference(final ScopeDefinition context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getContextType(); @@ -190,6 +193,7 @@ public class ScopeScopeProvider extends AbstractDeclarativeScopeProvider { * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_ScopeDelegation_scope(final ScopeDelegation context, final EReference reference) { // CHECKSTYLE:ON return getIncludedScopes(IScope.NULLSCOPE, EcoreUtil2.getContainerOfType(context, ScopeModel.class)); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java index 327f336..e10ed15 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java @@ -625,6 +625,7 @@ public abstract class AbstractXtextMarkerBasedTest extends AbstractXtextTest { * @param testSource * the test source, not {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void beforeApplyAssertions(final XtextTestSource testSource) { } diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java index d873827..395ef79 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java @@ -780,6 +780,7 @@ public abstract class AbstractScopingTest extends AbstractXtextMarkerBasedTest { * If target of a reference is an implicit item and this parameter is set to true, the test will get and compare the original object from which this * implicit item was created */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void testLinking(final EObject sourceObject, final int targetTag, final boolean traverseImplicitItems) { assertNotNull(sourceObject, "Source object must not be null."); //$NON-NLS-1$ EObject referencedTargetObject = getObjectForTag(targetTag); @@ -845,6 +846,7 @@ public abstract class AbstractScopingTest extends AbstractXtextMarkerBasedTest { * Cross reference to be resolved, must not be {@code null} * @return the referenced {@link EObject}, must not be {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected EObject getCrossReferencedObject(final int sourceTag, final boolean traverseImplicitItems, final CrossReference crossReference) { EObject context = getObjectForTag(sourceTag); if (crossReference == null) { diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java index b8e426e..e59a736 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java @@ -974,6 +974,7 @@ public abstract class AbstractValidationTest extends AbstractXtextMarkerBasedTes * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertNoLinkingErrorsOnResource(final EObject object, final String referenceType, final String... referenceNames) { final List<Resource.Diagnostic> linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List<String> errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); @@ -999,6 +1000,7 @@ public abstract class AbstractValidationTest extends AbstractXtextMarkerBasedTes * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertLinkingErrorsOnResourceExist(final EObject object, final String referenceType, final String... referenceNames) { final List<Resource.Diagnostic> linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List<String> errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java index 38a5ab8..d797d5e 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java @@ -627,6 +627,7 @@ public abstract class AbstractXtextMarkerBasedTest extends AbstractXtextTest { * @param testSource * the test source, not {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void beforeApplyAssertions(final XtextTestSource testSource) { } diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java index ad5df85..86b877c 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java @@ -780,6 +780,7 @@ public abstract class AbstractScopingTest extends AbstractXtextMarkerBasedTest { * If target of a reference is an implicit item and this parameter is set to true, the test will get and compare the original object from which this * implicit item was created */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void testLinking(final EObject sourceObject, final int targetTag, final boolean traverseImplicitItems) { assertNotNull("Source object must not be null.", sourceObject); //$NON-NLS-1$ EObject referencedTargetObject = getObjectForTag(targetTag); @@ -845,6 +846,7 @@ public abstract class AbstractScopingTest extends AbstractXtextMarkerBasedTest { * Cross reference to be resolved, must not be {@code null} * @return the referenced {@link EObject}, must not be {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected EObject getCrossReferencedObject(final int sourceTag, final boolean traverseImplicitItems, final CrossReference crossReference) { EObject context = getObjectForTag(sourceTag); if (crossReference == null) { diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java index abb767b..8479f69 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java @@ -975,6 +975,7 @@ public abstract class AbstractValidationTest extends AbstractXtextMarkerBasedTes * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertNoLinkingErrorsOnResource(final EObject object, final String referenceType, final String... referenceNames) { final List<Resource.Diagnostic> linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List<String> errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); @@ -1000,6 +1001,7 @@ public abstract class AbstractValidationTest extends AbstractXtextMarkerBasedTes * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertLinkingErrorsOnResourceExist(final EObject object, final String referenceType, final String... referenceNames) { final List<Resource.Diagnostic> linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List<String> errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); diff --git a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java index 3a83525..a14651d 100644 --- a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java @@ -131,7 +131,7 @@ public abstract class AbstractLabelProvider extends DeclarativeLabelProvider { * the second argument * @return {@code null} by default */ - @SuppressWarnings("PMD.EmptyMethodInAbstractClassShouldBeAbstract") + @SuppressWarnings({"PMD.EmptyMethodInAbstractClassShouldBeAbstract", "PMD.UnusedFormalParameter"}) public Object image(final Object element, final Object feature) { return null; } @@ -156,7 +156,7 @@ public abstract class AbstractLabelProvider extends DeclarativeLabelProvider { * the second argument * @return {@code null} by default */ - @SuppressWarnings("PMD.EmptyMethodInAbstractClassShouldBeAbstract") + @SuppressWarnings({"PMD.EmptyMethodInAbstractClassShouldBeAbstract", "PMD.UnusedFormalParameter"}) public Object getStyledLabel(final Object element, final Object feature) { return null; } diff --git a/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java b/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java index 373295d..b71db5e 100644 --- a/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java @@ -36,6 +36,7 @@ public class ValidLabelProvider extends DefaultEObjectLabelProvider { * the category * @return name of the image file */ + @SuppressWarnings("PMD.UnusedFormalParameter") String image(final Category category) { return "category.gif"; //$NON-NLS-1$ } @@ -58,6 +59,7 @@ public class ValidLabelProvider extends DefaultEObjectLabelProvider { * the quick fix * @return name of the image file */ + @SuppressWarnings("PMD.UnusedFormalParameter") String image(final QuickFix quickFix) { return "quickfix.gif"; //$NON-NLS-1$ } @@ -70,6 +72,7 @@ public class ValidLabelProvider extends DefaultEObjectLabelProvider { * the import * @return the import image */ + @SuppressWarnings("PMD.UnusedFormalParameter") Image image(final Import impaurt) { return JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPDECL); } @@ -92,6 +95,7 @@ public class ValidLabelProvider extends DefaultEObjectLabelProvider { * the native context * @return name of the image file */ + @SuppressWarnings("PMD.UnusedFormalParameter") String image(final NativeContext nativeContext) { return "eclass.gif"; //$NON-NLS-1$ } diff --git a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java index 803a617..41d1ff5 100644 --- a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java @@ -87,6 +87,7 @@ public class ValidScopeProvider extends AbstractDeclarativeScopeProvider { * @return the i scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EClass(final ValidModel validModel, final EReference reference) { // CHECKSTYLE:ON IScope result = IScope.NULLSCOPE; diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java index fac2004..528deff 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java @@ -190,6 +190,7 @@ public class LinkingService extends DefaultLinkingService { * The meta model cross-reference, never {@code null} * @return the actual element or a proxy */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected EObject getEObjectOrProxy(final EObject context, final IEObjectDescription desc, final EReference ref) { return desc.getEObjectOrProxy(); } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java index 69057a2..c2a4beb 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java @@ -126,6 +126,7 @@ public class DefaultInferredElementFragmentProvider implements IInferredElementF * set of already assigned fragments, must not be {@code null} * @return string (preferably not contained in {@code assignedFragments}), never {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected String getFinalResult(final EObject object, final HashCode hash, final Set<String> assignedFragments) { return hash.toString(); } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java index 54f6d96..2d8023e 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java @@ -91,6 +91,7 @@ public class ParserContext { * @param input * Input token stream */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void beforeParse(final TokenStream input) { // No implementation by default } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java index 9d6b23b..b0f3312 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java @@ -205,6 +205,7 @@ public abstract class AbstractResourceDescriptionStrategy extends DefaultResourc return new ReferenceDescription(owner, target, eReference, exportedContainerURI, indexInList); } + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean isIndexable(final EObject from, final EReference eReference) { return !eReference.isContainment() && !eReference.isContainer(); } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java index 4c5f7a4..cf14bff 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java @@ -94,6 +94,7 @@ public class ResourceDescriptions2 implements IResourceDescriptions2 { return ResourceDescriptionsUtil.findReferencesToObjects(delegate, targetObjects); } + @SuppressWarnings("PMD.UnusedFormalParameter") public Iterable<IResourceDescription> findExactReferencingResources(final Set<IEObjectDescription> targetObjects, final boolean matchImportedNames) { return null; } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java index 51050c4..4cc6962 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java @@ -73,6 +73,7 @@ public class ResourceValidationRuleSummaryEvent extends ResourceEvent { * @param obj * object against which the validation will be executed */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void ruleStarted(final String rule, final EObject obj) { if (currentRule == null || !currentRule.equals(rule)) { currentRule = rule; @@ -94,6 +95,7 @@ public class ResourceValidationRuleSummaryEvent extends ResourceEvent { * @param obj * object against which the validation was executed */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void ruleEnded(final String rule, final EObject obj) { // see comment in ruleStarted() for explanation currentData[0] += System.nanoTime(); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java index ca3e473..5dca2cc 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java @@ -190,6 +190,7 @@ public abstract class AbstractDeclarativeValidValidator extends AbstractDeclarat * the issue data * @return the error message if the assertion failed, NO_ERROR otherwise */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected SimpleValidMessage assertEmpty(final String message, final String string, final String... issueData) { if (!Strings.isNullOrEmpty(string.trim())) { return new SimpleValidMessage(message);
1 parent 7fb2a64 commit f2baa24

File tree

37 files changed

+68
-5
lines changed

37 files changed

+68
-5
lines changed

‎com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,7 @@ protected void internalToConvertedExpression(final XExpression obj, final ITreeA
195195
}
196196

197197
// CHECKSTYLE:OFF
198+
@SuppressWarnings("PMD.UnusedFormalParameter")
198199
protected void _toJavaStatement(final XGuardExpression expr, final ITreeAppendable b, final boolean isReferenced) {
199200
// CHECKSTYLE:ON
200201
internalToJavaStatement(expr.getGuard(), b, true);

‎com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ public class DummyCheckContext extends AbstractCheckContext {
2626
* @return {@code true} always
2727
*/
2828
@CheckContext(issueCodes = {CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE})
29+
@SuppressWarnings("PMD.UnusedFormalParameter")
2930
public boolean enableForEnabledDisabledCode(final EObject context) {
3031
return ENABLED;
3132
}
@@ -39,6 +40,7 @@ public boolean enableForEnabledDisabledCode(final EObject context) {
3940
*/
4041
@CheckContext(issueCodes = {CheckContextTest.DISABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE,
4142
CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE})
43+
@SuppressWarnings("PMD.UnusedFormalParameter")
4244
public boolean disableForCodes(final EObject context) {
4345
return DISABLED;
4446
}
@@ -51,6 +53,7 @@ public boolean disableForCodes(final EObject context) {
5153
* @return {@code true} always
5254
*/
5355
@CheckContext(issueCodes = {CheckContextTest.ENABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE})
56+
@SuppressWarnings("PMD.UnusedFormalParameter")
5457
public boolean enabledForCodes(final EObject context) {
5558
return ENABLED;
5659
}

‎com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,7 @@ private String getLanguage(final URI uri) {
127127
* the context object of the validation being executed
128128
* @return the configuration store instance
129129
*/
130+
@SuppressWarnings("PMD.UnusedFormalParameter")
130131
protected ICheckConfigurationStore internalGetCheckConfigurationStore(final Object context) {
131132
if (configurationStore == null) {
132133
configurationStore = new CheckConfigurationStore(DEFAULT_CHECK_CONFIGURATION_NODE);

‎com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,7 @@ public interface DiagnosticCollector extends ValidationMessageAcceptor {
109109
* @param eventCollector
110110
* an event collector for collecting validation events, may be {@code null}
111111
*/
112-
@SuppressWarnings("checkstyle:IllegalCatch")
112+
@SuppressWarnings({"checkstyle:IllegalCatch", "PMD.UnusedFormalParameter"})
113113
protected void validate(final String contextName, final String qContextName, final EObject object, final Runnable checkAction, final DiagnosticCollector diagnosticCollector, final ResourceValidationRuleSummaryEvent.Collector eventCollector) {
114114
if (!disabledMethodTracker.isDisabled(contextName)) {
115115
try {

‎com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ private String ruleName(final MethodWrapper method) {
9999
* the context
100100
* @return true, if successful
101101
*/
102-
@SuppressWarnings("PMD.NPathComplexity")
102+
@SuppressWarnings({"PMD.NPathComplexity", "PMD.UnusedFormalParameter"})
103103
protected final boolean internalValidate(final EClass class1, final EObject object, final DiagnosticChain diagnostics, final Map<Object, Object> context) {
104104
initCheckMethodCache();
105105

‎com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ protected void handleChangedContents(final Delta delta, final IBuildContext cont
111111
* @param context
112112
* build context
113113
*/
114+
@SuppressWarnings("PMD.UnusedFormalParameter")
114115
protected void handleDeletion(final Delta delta, final IBuildContext context) {
115116
if (hasCorrectExtension(delta, resourceServiceProvider)) {
116117
try {

‎com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,6 +142,7 @@ protected <T> T getFromServiceProvider(final Class<T> type, final URI uri) {
142142
* have changed before the builder participant kicks
143143
* in.
144144
*/
145+
@SuppressWarnings("PMD.UnusedFormalParameter")
145146
protected boolean isExtensionUpdateRequired(final CheckCatalog catalog, final IPluginExtension extension, final Iterable<IPluginElement> elements) {
146147
return extension.getPoint().equals(getExtensionPointId()); // if points are different, given extension must not be updated
147148
}
@@ -214,6 +215,7 @@ public IPluginExtension addExtensionToPluginBase(final IPluginModelBase base, fi
214215
* the extension id
215216
* @return true, if the extension should be enabled
216217
*/
218+
@SuppressWarnings("PMD.UnusedFormalParameter")
217219
protected boolean isExtensionEnabled(final IPluginModelBase base, final CheckCatalog catalog, final ExtensionType type, final String extensionId) {
218220
if (type == ExtensionType.MARKERHELP) {
219221
return false; // disabled until https://bugs.eclipse.org/bugs/show_bug.cgi?id=369534 is fixed

‎com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,7 @@ public ExtensionType apply(final IPluginExtension from) {
272272
* @throws CoreException
273273
* the core exception
274274
*/
275+
@SuppressWarnings("PMD.UnusedFormalParameter")
275276
public void updateExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
276277
QualifiedName catalogName = nameProvider.apply(catalog);
277278
Collection<IPluginExtension> catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL);
@@ -296,6 +297,7 @@ public void updateExtensions(final CheckCatalog catalog, final IPluginModelBase
296297
* @throws CoreException
297298
* the core exception
298299
*/
300+
@SuppressWarnings("PMD.UnusedFormalParameter")
299301
public void addExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
300302
QualifiedName catalogName = nameProvider.apply(catalog);
301303
Collection<IPluginExtension> catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL);
@@ -324,6 +326,7 @@ public void addExtensions(final CheckCatalog catalog, final IPluginModelBase plu
324326
* @throws CoreException
325327
* the core exception
326328
*/
329+
@SuppressWarnings("PMD.UnusedFormalParameter")
327330
public void removeExtensions(final IEObjectDescription obj, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
328331
for (IPluginExtension extension : findExtensions(pluginModel, obj.getName(), ExtensionType.ALL)) {
329332
final ExtensionType extensionType = getExtensionType(extension);
@@ -344,6 +347,7 @@ public void removeExtensions(final IEObjectDescription obj, final IPluginModelBa
344347
* @throws CoreException
345348
* the core exception
346349
*/
350+
@SuppressWarnings("PMD.UnusedFormalParameter")
347351
public void removeExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
348352
QualifiedName name = nameConverter.toQualifiedName(projectUtil.getCatalogQualifiedName(catalog));
349353
for (IPluginExtension extension : findExtensions(pluginModel, name, ExtensionType.ALL)) {
@@ -362,6 +366,7 @@ public void removeExtensions(final CheckCatalog catalog, final IPluginModelBase
362366
* @throws CoreException
363367
* the core exception
364368
*/
369+
@SuppressWarnings("PMD.UnusedFormalParameter")
365370
public void sortAllExtensions(final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException {
366371
Ordering<IPluginExtension> ordering = Ordering.from((a, b) -> ComparisonChain.start().compare(a.getPoint(), b.getPoint()).compare(a.getId(), b.getId(), Ordering.natural().nullsLast()).compare(a.getName(), b.getName(), Ordering.natural().nullsLast()).result());
367372
List<IPluginExtension> catalogExtensions = Lists.newArrayList(findAllExtensions(pluginModel));

‎com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ public void generateDefaultQuickfixProvider(final IPath path, final CheckProject
6767
* @param projectInfo
6868
* the project info
6969
*/
70-
@SuppressWarnings("nls")
70+
@SuppressWarnings({"nls", "PMD.UnusedFormalParameter"})
7171
public void generateDocsDirectory(final IPath path, final CheckProjectInfo projectInfo) {
7272
fsa.setOutputPath(path.toOSString());
7373
// IFileSystemAccess doesn't support creating empty directories, so:

‎com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ protected void _createProposals(final Keyword keyword, final ContentAssistContex
111111
super._createProposals(keyword, context, acceptor);
112112
}
113113

114+
@SuppressWarnings("PMD.UnusedFormalParameter")
114115
protected void completeLanguages(final EObject model, final ContentAssistContext context, final IIdeContentProposalAcceptor acceptor) {
115116
for (String language : checkCfgUtil.getAllLanguages()) {
116117
ContentAssistEntry entry = getProposalCreator().createProposal(language, context, (final ContentAssistEntry it) -> {

0 commit comments

Comments
 (0)