diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java index f6c1c11ca6..c775964239 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/generator/CheckCompiler.java @@ -195,6 +195,7 @@ protected void internalToConvertedExpression(final XExpression obj, final ITreeA } // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected void _toJavaStatement(final XGuardExpression expr, final ITreeAppendable b, final boolean isReferenced) { // CHECKSTYLE:ON internalToJavaStatement(expr.getGuard(), b, true); diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessJavaValidationHelper.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessJavaValidationHelper.java index 939f3c6a5b..07a63c63f0 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessJavaValidationHelper.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessJavaValidationHelper.java @@ -48,6 +48,8 @@ public UniquenessJavaValidationHelper(final Function nameFunct * provides the feature of the duplicate object on which to anchor the marker * @param issueCode * the issue code + * @throws IllegalArgumentException + * if acceptor is null */ public void warnOnDuplicates(final Iterable possiblyDuplicateObjects, final Function featureProvider, final String issueCode) { if (acceptor == null) { @@ -75,6 +77,8 @@ public void warnOnDuplicates(final Iterable possiblyDuplicateObjects, final F * provides the feature of the duplicate object on which to anchor the marker * @param issueCode * the issue code + * @throws IllegalArgumentException + * if acceptor is null */ public void errorOnDuplicates(final Iterable possiblyDuplicateObjects, final Function featureProvider, final String issueCode) { if (acceptor == null) { diff --git a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessValidationHelper.java b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessValidationHelper.java index 9655c71116..2336e7bd32 100644 --- a/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessValidationHelper.java +++ b/com.avaloq.tools.ddk.check.core/src/com/avaloq/tools/ddk/check/validation/UniquenessValidationHelper.java @@ -36,9 +36,11 @@ public class UniquenessValidationHelper { /** * Creates a Uniqueness validation helper. - * + * * @param nameFunction * a function that returns a representation of a T object that can be compared by means of equals + * @throws IllegalArgumentException + * if nameFunction is null */ public UniquenessValidationHelper(final Function nameFunction) { if (nameFunction == null) { diff --git a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java index 14e6df33e8..68d41a676d 100644 --- a/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java +++ b/com.avaloq.tools.ddk.check.runtime.core.test/src/com/avaloq/tools/ddk/check/runtime/context/DummyCheckContext.java @@ -26,6 +26,7 @@ public class DummyCheckContext extends AbstractCheckContext { * @return {@code true} always */ @CheckContext(issueCodes = {CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE}) + @SuppressWarnings("PMD.UnusedFormalParameter") public boolean enableForEnabledDisabledCode(final EObject context) { return ENABLED; } @@ -39,6 +40,7 @@ public boolean enableForEnabledDisabledCode(final EObject context) { */ @CheckContext(issueCodes = {CheckContextTest.DISABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE, CheckContextTest.ENABLED_AND_DISABLED_ISSUE_CODE}) + @SuppressWarnings("PMD.UnusedFormalParameter") public boolean disableForCodes(final EObject context) { return DISABLED; } @@ -51,6 +53,7 @@ public boolean disableForCodes(final EObject context) { * @return {@code true} always */ @CheckContext(issueCodes = {CheckContextTest.ENABLED_ISSUE_CODE, CheckContextTest.DISABLED_AND_ENABLED_ISSUE_CODE}) + @SuppressWarnings("PMD.UnusedFormalParameter") public boolean enabledForCodes(final EObject context) { return ENABLED; } diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java index 32db9050de..a1773a1e1b 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/configuration/CheckConfigurationStoreService.java @@ -127,6 +127,7 @@ private String getLanguage(final URI uri) { * the context object of the validation being executed * @return the configuration store instance */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected ICheckConfigurationStore internalGetCheckConfigurationStore(final Object context) { if (configurationStore == null) { configurationStore = new CheckConfigurationStore(DEFAULT_CHECK_CONFIGURATION_NODE); diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java index 698514f584..5678c21fd3 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/AbstractDispatchingCheckImpl.java @@ -109,7 +109,7 @@ public interface DiagnosticCollector extends ValidationMessageAcceptor { * @param eventCollector * an event collector for collecting validation events, may be {@code null} */ - @SuppressWarnings("checkstyle:IllegalCatch") + @SuppressWarnings({"checkstyle:IllegalCatch", "PMD.UnusedFormalParameter"}) protected void validate(final String contextName, final String qContextName, final EObject object, final Runnable checkAction, final DiagnosticCollector diagnosticCollector, final ResourceValidationRuleSummaryEvent.Collector eventCollector) { if (!disabledMethodTracker.isDisabled(contextName)) { try { diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java index 6928a3406e..96caba661f 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/DefaultCheckImpl.java @@ -99,7 +99,7 @@ private String ruleName(final MethodWrapper method) { * the context * @return true, if successful */ - @SuppressWarnings("PMD.NPathComplexity") + @SuppressWarnings({"PMD.NPathComplexity", "PMD.UnusedFormalParameter"}) protected final boolean internalValidate(final EClass class1, final EObject object, final DiagnosticChain diagnostics, final Map context) { initCheckMethodCache(); diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/ValidationMessageAcceptorMixin.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/ValidationMessageAcceptorMixin.java index 29f76121d2..30da491744 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/ValidationMessageAcceptorMixin.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/issue/ValidationMessageAcceptorMixin.java @@ -145,6 +145,8 @@ default Diagnostic createDiagnostic(final Severity severity, final String messag * @param severity * the issue severity * @return the numeric value representing a severity + * @throws IllegalArgumentException + * if the severity is unknown */ static int toDiagnosticSeverity(final Severity severity) { return switch (severity) { diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/quickfix/BadLocationException.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/quickfix/BadLocationException.java index 1b520c5fb9..4a352ea714 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/quickfix/BadLocationException.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/quickfix/BadLocationException.java @@ -43,8 +43,8 @@ public BadLocationException(final String message) { /** * Creates a new bad location exception. - * - * @param exception + * + * @param wrappedException * the cause for the exception */ public BadLocationException(final Exception wrappedException) { diff --git a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/validation/AbstractCheckValidator.java b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/validation/AbstractCheckValidator.java index 23af33ea74..42ff9e2b7b 100644 --- a/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/validation/AbstractCheckValidator.java +++ b/com.avaloq.tools.ddk.check.runtime.core/src/com/avaloq/tools/ddk/check/runtime/validation/AbstractCheckValidator.java @@ -69,13 +69,16 @@ public Iterable getValidators(final Map internalCollectValidators(final String language, final EObject object) { if (language == null) { throw new IllegalArgumentException("Input language cannot be null"); //$NON-NLS-1$ diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java index dd75a86a54..1682ba17b8 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckBuilderParticipant.java @@ -111,6 +111,7 @@ protected void handleChangedContents(final Delta delta, final IBuildContext cont * @param context * build context */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void handleDeletion(final Delta delta, final IBuildContext context) { if (hasCorrectExtension(delta, resourceServiceProvider)) { try { diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java index 273cfea5d2..ef3118d530 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/CheckExtensionGenerator.java @@ -485,12 +485,15 @@ public boolean saveOpenEditor() { /** * Merges the {@code MANIFEST.MF} file with new plug-in dependencies. Adds dependencies as returned by + * {@link com.avaloq.tools.ddk.check.util.GrammarHelper#getRequiredBundleSymbolicNames()} of current + * check catalog to the MANIFEST.MF file. * * @param catalog * check catalog * @param monitor - * progress monitor {@link com.avaloq.tools.ddk.check.util.GrammarHelper#getRequiredBundleSymbolicNames()} of current - * check catalog to the MANIFEST.MF file. + * progress monitor + * @throws WrappedException + * if an IOException or CoreException occurs during manifest modification */ private void mergeManifest(final CheckCatalog catalog, final IProgressMonitor monitor) { final IProject project = RuntimeProjectUtil.getProject(catalog.eResource().getURI(), mapper); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java index 28ff2ac87d..e7fb723e77 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/AbstractCheckExtensionHelper.java @@ -142,6 +142,7 @@ protected T getFromServiceProvider(final Class type, final URI uri) { * have changed before the builder participant kicks * in. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean isExtensionUpdateRequired(final CheckCatalog catalog, final IPluginExtension extension, final Iterable elements) { return extension.getPoint().equals(getExtensionPointId()); // if points are different, given extension must not be updated } @@ -214,6 +215,7 @@ public IPluginExtension addExtensionToPluginBase(final IPluginModelBase base, fi * the extension id * @return true, if the extension should be enabled */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean isExtensionEnabled(final IPluginModelBase base, final CheckCatalog catalog, final ExtensionType type, final String extensionId) { if (type == ExtensionType.MARKERHELP) { return false; // disabled until https://bugs.eclipse.org/bugs/show_bug.cgi?id=369534 is fixed diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java index 3b8a1ac766..6a7cc8bc63 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckExtensionHelperManager.java @@ -272,6 +272,7 @@ public ExtensionType apply(final IPluginExtension from) { * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void updateExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { QualifiedName catalogName = nameProvider.apply(catalog); Collection catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL); @@ -296,6 +297,7 @@ public void updateExtensions(final CheckCatalog catalog, final IPluginModelBase * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void addExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { QualifiedName catalogName = nameProvider.apply(catalog); Collection catalogExtensions = findExtensions(pluginModel, catalogName, ExtensionType.ALL); @@ -324,6 +326,7 @@ public void addExtensions(final CheckCatalog catalog, final IPluginModelBase plu * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void removeExtensions(final IEObjectDescription obj, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { for (IPluginExtension extension : findExtensions(pluginModel, obj.getName(), ExtensionType.ALL)) { final ExtensionType extensionType = getExtensionType(extension); @@ -344,6 +347,7 @@ public void removeExtensions(final IEObjectDescription obj, final IPluginModelBa * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void removeExtensions(final CheckCatalog catalog, final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { QualifiedName name = nameConverter.toQualifiedName(projectUtil.getCatalogQualifiedName(catalog)); for (IPluginExtension extension : findExtensions(pluginModel, name, ExtensionType.ALL)) { @@ -362,6 +366,7 @@ public void removeExtensions(final CheckCatalog catalog, final IPluginModelBase * @throws CoreException * the core exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void sortAllExtensions(final IPluginModelBase pluginModel, final IProgressMonitor monitor) throws CoreException { Ordering ordering = Ordering.from((a, b) -> ComparisonChain.start().compare(a.getPoint(), b.getPoint()).compare(a.getId(), b.getId(), Ordering.natural().nullsLast()).compare(a.getName(), b.getName(), Ordering.natural().nullsLast()).result()); List catalogExtensions = Lists.newArrayList(findAllExtensions(pluginModel)); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java index 59c5b0436b..1a904cbce5 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/builder/util/CheckProjectHelper.java @@ -187,6 +187,8 @@ public CheckCatalog getCatalog(final IBuildContext context, final URI uri) { * @param className * the class name, must not be {@code null} * @return whether the corresponding java file exists in the project + * @throws IllegalArgumentException + * if the class name is simple or not a valid class name */ public boolean isJavaFilePresent(final IProject project, final String className) { int packageSplitIndex = className.lastIndexOf('.'); diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckLabelProvider.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckLabelProvider.java index 64bdc9acef..c28fecc809 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckLabelProvider.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/labeling/CheckLabelProvider.java @@ -91,6 +91,7 @@ public String text(final Category category) { * any catalog * @return a graphical representation of the catalog */ + @SuppressWarnings("PMD.UnusedFormalParameter") public Image image(final CheckCatalog catalog) { return images.forCheckCatalog(); } @@ -102,6 +103,7 @@ public Image image(final CheckCatalog catalog) { * any category * @return a graphical representation of the category */ + @SuppressWarnings("PMD.UnusedFormalParameter") public Image image(final Category category) { return images.forCategory(); } @@ -124,39 +126,43 @@ public Image image(final Check check) { * any context * @return a graphical representation of the context */ + @SuppressWarnings("PMD.UnusedFormalParameter") public Image image(final Context context) { return images.forContext(); } /** * An image for member labels. - * + * * @param context * any context * @return a graphical representation of the context */ + @SuppressWarnings("PMD.UnusedFormalParameter") public Image image(final Member context) { return images.getJdtImage(xbaseImages.forField(JvmVisibility.PRIVATE, 0)); } /** * An image for member labels. - * + * * @param context * any context * @return a graphical representation of the context */ + @SuppressWarnings("PMD.UnusedFormalParameter") public Image image(final ContextVariable context) { return images.getJdtImage(xbaseImages.forLocalVariable(0)); } /** * An image for member labels. - * + * * @param context * any context * @return a graphical representation of the context */ + @SuppressWarnings("PMD.UnusedFormalParameter") public Image image(final FormalParameter context) { return images.getJdtImage(xbaseImages.forLocalVariable(0)); } diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java index 41b13c6dbd..3d02494f8b 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/popup/actions/DeployJob.java @@ -418,7 +418,12 @@ private static class DeployException extends Exception { DeployException() { } - /** Constructor with cause exception. */ + /** + * Constructor with cause exception. + * + * @param e + * the cause exception + */ DeployException(final Exception e) { super(e); } diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/FieldInitializerUtil.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/FieldInitializerUtil.java index 1166b6334a..f9e5ea1ad3 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/FieldInitializerUtil.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/util/FieldInitializerUtil.java @@ -45,6 +45,8 @@ public class FieldInitializerUtil { * @param selection * the selection * @return the selected resource + * @throws RuntimeException + * if a Java model exception occurs */ public IJavaElement getSelectedResource(final IStructuredSelection selection) { IJavaElement elem = null; diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java index a2111decf2..6c215d915f 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/CheckCatalogGenerator.java @@ -67,7 +67,7 @@ public void generateDefaultQuickfixProvider(final IPath path, final CheckProject * @param projectInfo * the project info */ - @SuppressWarnings("nls") + @SuppressWarnings({"nls", "PMD.UnusedFormalParameter"}) public void generateDocsDirectory(final IPath path, final CheckProjectInfo projectInfo) { fsa.setOutputPath(path.toOSString()); // IFileSystemAccess doesn't support creating empty directories, so: diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizard.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizard.java index c0f67192e9..69d91cc69e 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizard.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckCatalogWizard.java @@ -40,11 +40,13 @@ public class NewCheckCatalogWizard extends XtextNewProjectWizard { /** * Instantiates a new new check file wizard. - * + * * @param images * the shared images - * @param page - * the new file wizard page + * @param catalogPage + * the new catalog wizard page + * @param creator + * the check catalog creator */ @Inject public NewCheckCatalogWizard(final CheckImages images, final NewCheckCatalogWizardPage catalogPage, final ICheckCatalogCreator creator) { diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizard.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizard.java index 38b5216376..5ab8d0ada9 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizard.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizard.java @@ -31,6 +31,13 @@ public class NewCheckProjectWizard extends XtextNewProjectWizard { // extends Wi /** * Constructor for the check project wizard. The pages required by this wizard are not created by hand, but by Guice (see also plugin.xml). + * + * @param creator + * the project creator + * @param newProjectPage + * the new project wizard page + * @param newCatalogPage + * the new catalog wizard page */ @Inject public NewCheckProjectWizard(final IProjectCreator creator, final NewCheckProjectWizardPage newProjectPage, final NewCheckCatalogWizardPage newCatalogPage) { diff --git a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java index ae13270179..fe1bfaa929 100644 --- a/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java +++ b/com.avaloq.tools.ddk.check.ui/src/com/avaloq/tools/ddk/check/ui/wizard/NewCheckProjectWizardPage.java @@ -50,8 +50,6 @@ public class NewCheckProjectWizardPage extends NewTypeWizardPage { /** * Constructor for NewCheckProjectWizardPage. - * - * @param selection */ @Inject public NewCheckProjectWizardPage() { diff --git a/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java b/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java index 031db95819..527e7b336a 100644 --- a/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java +++ b/com.avaloq.tools.ddk.checkcfg.ide/src/com/avaloq/tools/ddk/checkcfg/ide/contentassist/CheckCfgIdeContentProposalProvider.java @@ -111,6 +111,7 @@ protected void _createProposals(final Keyword keyword, final ContentAssistContex super._createProposals(keyword, context, acceptor); } + @SuppressWarnings("PMD.UnusedFormalParameter") protected void completeLanguages(final EObject model, final ContentAssistContext context, final IIdeContentProposalAcceptor acceptor) { for (String language : checkCfgUtil.getAllLanguages()) { ContentAssistEntry entry = getProposalCreator().createProposal(language, context, (final ContentAssistEntry it) -> { diff --git a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java index fe9632aed6..dbb65d1ca9 100644 --- a/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.checkcfg.ui/src/com/avaloq/tools/ddk/checkcfg/ui/outline/CheckCfgOutlineTreeProvider.java @@ -110,6 +110,7 @@ protected String safeName(final String s) { * @return {@code true} */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final ConfiguredCheck modelElement) { // CHECKSTYLE:ON return true; diff --git a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java index d970192258..ff192ecaef 100644 --- a/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java +++ b/com.avaloq.tools.ddk.test.core/src/com/avaloq/tools/ddk/test/core/mock/ExtensionRegistryMock.java @@ -48,7 +48,8 @@ private ExtensionRegistryMock() { /** * Mocks the extension registry. * - * @throws CoreException + * @throws WrappedException + * if the registry provider cannot be set */ @SuppressWarnings("restriction") // for accessing RegistryProviderFactory public static synchronized void mockRegistry() { @@ -148,6 +149,9 @@ public static void unMock(final String extensionPointId) { /** * Unmocks the extension registry. + * + * @throws WrappedException + * if the registry provider cannot be reset */ @SuppressWarnings("restriction") // for accessing RegistryProviderFactory public static void unMockRegistry() { @@ -167,6 +171,9 @@ public static void unMockRegistry() { /** * Asserts that the extension registry is unmocked. + * + * @throws IllegalStateException + * if the extension registry mock is in an unexpected state */ public static void assertUnMocked() { if (registrySpy != null) { diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java index 9329c5f628..be5b5a92eb 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/CoreSwtbotTools.java @@ -194,6 +194,8 @@ public void run() { * base name of file, may be {@code null} only if useCaller is {@code true} * @param useCaller * if {@code true}, append the name of the calling method to the prefix + * @throws IllegalArgumentException + * if prefix is null and useCaller is false */ public static void captureScreenshot(final SWTBot bot, final String prefix, final boolean useCaller) { Assert.isNotNull(bot, ARGUMENT_BOT); @@ -219,6 +221,8 @@ public static void captureScreenshot(final SWTBot bot, final String prefix, fina * @param windowName * the name of the window to search for, must not be {@code null} * @return {@code true} if a window was found, {@code false} otherwise + * @throws WrappedException + * if an error occurs while searching for the window */ public static boolean checkOpenWindow(final SWTWorkbenchBot bot, final String windowName) { Assert.isNotNull(bot, ARGUMENT_BOT); @@ -529,6 +533,8 @@ public static void openAvaloqPreferencesSection(final SWTWorkbenchBot bot, final * @param prefix * the prefix of the item to search for, must not be {@code null} * @return the full name of the item as string, never {@code null} + * @throws AssertionFailedException + * if no item with the given prefix is found */ public static String getCcomboItemText(final SWTBotCCombo ccombo, final String prefix) { Assert.isNotNull(ccombo, "ccombo"); diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java index 34a024f55e..1956624a31 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWizardBot.java @@ -91,6 +91,8 @@ public void writeToTextField(final String fieldName, final String input) { * the box label * @param selectionIndex * the selection index + * @throws IndexOutOfBoundsException + * if the selection index is out of bounds */ public void selectInComboBox(final String boxLabel, final int selectionIndex) { SWTBotCombo combo = comboBoxWithLabel(boxLabel); diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java index 050bd0bd62..d7f3f8b189 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/SwtWorkbenchBot.java @@ -313,6 +313,8 @@ public void clickButton(final SWTBotButton button) { * the {@link SWTBotButton} to be clicked * @param timeout * the timeout to wait for. When timeout is reached, a WrappedException is thrown. + * @throws WrappedException + * if the button does not become enabled within the timeout */ public void clickButton(final SWTBotButton button, final long timeout) { final long endTimeMillis = System.currentTimeMillis() + timeout; diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/DynamicViewMenu.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/DynamicViewMenu.java index 11db6da104..214bb0e5dc 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/DynamicViewMenu.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/DynamicViewMenu.java @@ -60,6 +60,8 @@ public DynamicViewMenu(final SWTWorkbenchBot bot) { * * @param menuPath * the menu path + * @throws IllegalStateException + * if the menu manager is not a MenuManager */ public void click(final String... menuPath) { final IViewSite viewSite = (IViewSite) viewReference.getPart(false).getSite(); diff --git a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java index f6cde77fa6..7859311b26 100644 --- a/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java +++ b/com.avaloq.tools.ddk.test.ui/src/com/avaloq/tools/ddk/test/ui/swtbot/util/SwtBotControlUtils.java @@ -50,6 +50,8 @@ public static void waitForItems(final AbstractSWTBotControl control) { * the SWTBot control to search in * @param timeout * how long should the system wait + * @throws WrappedException + * if the wait times out */ public static void waitForItems(final AbstractSWTBotControl control, final int timeout) { final long endTimeMillis = System.currentTimeMillis() + timeout; diff --git a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java index eebfd69ec2..6b586e8115 100644 --- a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java +++ b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeLabelProvider.java @@ -47,6 +47,7 @@ public String handle(final Object[] params, final Throwable e) { * exception encountered by the dispatcher. * @return default text for a null value if exception was a NullPointerException, else wraps and throws exception */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected String handleTextError(final Object[] params, final Throwable e) { if (e instanceof NullPointerException) { return text(null); @@ -66,6 +67,7 @@ public String getText(final IType type) { * a null value * @return the label for {@code type} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected String text(final Void type) { return ""; //$NON-NLS-1$ } diff --git a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java index 7c938da7e3..b50f633190 100644 --- a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java +++ b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/AbstractTypeProvider.java @@ -409,6 +409,7 @@ protected IType doHandleCyclicCall(final IExpression expression) { * the expression to get the type for * @return the type of {@code expression} if it can be computed; otherwise null. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType handleCyclicGetType(final IExpression expression) { return null; } @@ -423,6 +424,7 @@ protected IType handleCyclicGetType(final IExpression expression) { * the expression to compute the type for * @return the type of {@code expression} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType type(final IExpression expression) { return null; } @@ -475,6 +477,7 @@ protected EObject getPrimaryEObject(final IExpression expression) { * the expression to get the expected type for * @return the expected type of {@code expression} if it can be computed; otherwise null. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType handleCycleGetExpectedType(final IExpression expression) { return null; } @@ -494,6 +497,7 @@ protected IType handleCycleGetExpectedType(final IExpression expression) { * if {@code reference} is a list, then the index within that list; otherwise -1 * @return the expected type of {@code expression} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType expectedType(final EObject container, final EReference reference, final int index) { return null; } @@ -541,6 +545,7 @@ protected EObject getPrimaryEObject(final INamedElement element) { * the named element to get the type for * @return the type of {@code element} if it can be computed; otherwise null. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType handleCycleGetTypeForNamedElement(final INamedElement element) { return null; } @@ -555,6 +560,7 @@ protected IType handleCycleGetTypeForNamedElement(final INamedElement element) { * the named element to compute the type for * @return the type of {@code element} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected IType typeForNamedElement(final INamedElement element) { return null; } @@ -631,6 +637,7 @@ public IType getTypeForNamedElement(final INamedElement element) { * the object to get the provider for * @return the type provider for {@code eObject} or {@code null} if it is not known. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected ITypeProvider getTypeProviderFor(final EObject eObject) { return null; } diff --git a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/BasicMatchResult.java b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/BasicMatchResult.java index 5ceb67d00a..75231406a3 100644 --- a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/BasicMatchResult.java +++ b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/BasicMatchResult.java @@ -30,6 +30,9 @@ public BasicMatchResult() { /** * Creates a new instance of {@link BasicMatchResult} with the given status. + * + * @param status + * the match status */ public BasicMatchResult(final MatchStatus status) { this.status = status; diff --git a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/IncompleteTypeInformationException.java b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/IncompleteTypeInformationException.java index d03dc6772f..06a31acac9 100644 --- a/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/IncompleteTypeInformationException.java +++ b/com.avaloq.tools.ddk.typesystem/src/com/avaloq/tools/ddk/typesystem/IncompleteTypeInformationException.java @@ -28,6 +28,9 @@ public IncompleteTypeInformationException() { /** * Creates a new instance of {@link IncompleteTypeInformationException} with the given message. + * + * @param message + * the error message */ public IncompleteTypeInformationException(final String message) { super(message); @@ -35,6 +38,9 @@ public IncompleteTypeInformationException(final String message) { /** * Creates a new instance of {@link IncompleteTypeInformationException} by wrapping {@code wrappedException}. + * + * @param wrappedException + * the wrapped exception */ public IncompleteTypeInformationException(final Throwable wrappedException) { super(wrappedException); diff --git a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/CurrentDescriptions2.java b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/CurrentDescriptions2.java index 58b93d5769..06bc937b49 100644 --- a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/CurrentDescriptions2.java +++ b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/CurrentDescriptions2.java @@ -42,10 +42,8 @@ public class CurrentDescriptions2 extends CurrentDescriptions implements IResour * * @param resourceSet * The resource set - * @param oldState - * The old index - * @param initiallyDeleted - * URIs of resources physically deleted + * @param newData + * The new resource descriptions data */ public CurrentDescriptions2(final ResourceSet resourceSet, final ResourceDescriptionsData newData) { super(resourceSet, newData); diff --git a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/MonitoredClusteringBuilderState.java b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/MonitoredClusteringBuilderState.java index 7ef4655aa2..8c92fec749 100644 --- a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/MonitoredClusteringBuilderState.java +++ b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/MonitoredClusteringBuilderState.java @@ -1029,6 +1029,7 @@ private IDerivedObjectAssociationsStore getDerivedObjectAssociationsStore() { * the newly computed delta * @return true, if the new delta is to be registered in this state; false otherwise. */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean recordDeltaAsNew(final Delta newDelta) { return true; } @@ -1315,6 +1316,8 @@ protected void queueAffectedResources(final Set allRemainingURIs, final IRe * * @param monitor * the {@link IProgressMonitor} to check, must not be {@code null} + * @throws OperationCanceledException + * if the monitor was cancelled */ protected void checkForCancellation(final IProgressMonitor monitor) { if (monitor.isCanceled()) { diff --git a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/RegistryBuilderParticipant.java b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/RegistryBuilderParticipant.java index 6aa55e3f66..1a1dd2cd82 100644 --- a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/RegistryBuilderParticipant.java +++ b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/RegistryBuilderParticipant.java @@ -161,6 +161,8 @@ private void builLanguageSpecificContext(final IBuildContext buildContext, final * the {@link IProgressMonitor}, must not be {@code null} * @throws CoreException * caused by an {@link IXtextBuilderParticipant} + * @throws OperationCanceledException + * if the build is canceled */ protected void buildOtherParticipants(final IBuildContext buildContext, final IProgressMonitor monitor) throws CoreException { List otherBuilderParticipants = getParticipants(); diff --git a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java index b3a26bf647..dc504d1be7 100644 --- a/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java +++ b/com.avaloq.tools.ddk.xtext.builder/src/com/avaloq/tools/ddk/xtext/builder/resourceloader/ResourceLoaderProviders.java @@ -36,6 +36,7 @@ private ResourceLoaderProviders() { * degree * @return parallel resource loader */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static Provider getParallelLoader(final int nrOfThreads) { int nProcessors = Runtime.getRuntime().availableProcessors(); // CHECKSTYLE:CONSTANTS-OFF diff --git a/com.avaloq.tools.ddk.xtext.common.types.ui/src/com/avaloq/tools/ddk/xtext/common/types/ui/access/jdt/JdtFallbackTypeProviderFactory.java b/com.avaloq.tools.ddk.xtext.common.types.ui/src/com/avaloq/tools/ddk/xtext/common/types/ui/access/jdt/JdtFallbackTypeProviderFactory.java index 74739ee46e..b5c9ca7340 100644 --- a/com.avaloq.tools.ddk.xtext.common.types.ui/src/com/avaloq/tools/ddk/xtext/common/types/ui/access/jdt/JdtFallbackTypeProviderFactory.java +++ b/com.avaloq.tools.ddk.xtext.common.types.ui/src/com/avaloq/tools/ddk/xtext/common/types/ui/access/jdt/JdtFallbackTypeProviderFactory.java @@ -38,13 +38,15 @@ public class JdtFallbackTypeProviderFactory extends JdtTypeProviderFactory { /** * Creates a new instance of {@link JdtFallbackTypeProviderFactory}. - * + * * @param javaProjectProvider * the {@link IJavaProjectProvider}, may be {@code null} * @param classLoader * the {@link ClassLoader}, must not be {@code null} * @param indexedJvmTypeAccess * the {@link IndexedJvmTypeAccess}, may be {@code null} + * @param typeResourceServices + * the {@link TypeResourceServices}, may be {@code null} */ @Inject public JdtFallbackTypeProviderFactory(final IJavaProjectProvider javaProjectProvider, final ClassLoader classLoader, final IndexedJvmTypeAccess indexedJvmTypeAccess, final TypeResourceServices typeResourceServices) { diff --git a/com.avaloq.tools.ddk.xtext.common.types/src/com/avaloq/tools/ddk/xtext/common/types/access/jdt/BundleAwareTypeProvider.java b/com.avaloq.tools.ddk.xtext.common.types/src/com/avaloq/tools/ddk/xtext/common/types/access/jdt/BundleAwareTypeProvider.java index e2af3c707a..540b2b39ec 100644 --- a/com.avaloq.tools.ddk.xtext.common.types/src/com/avaloq/tools/ddk/xtext/common/types/access/jdt/BundleAwareTypeProvider.java +++ b/com.avaloq.tools.ddk.xtext.common.types/src/com/avaloq/tools/ddk/xtext/common/types/access/jdt/BundleAwareTypeProvider.java @@ -30,13 +30,15 @@ public class BundleAwareTypeProvider extends ClasspathTypeProvider { /** * Creates a new instance of {@link BundleAwareTypeProvider}. - * + * * @param classLoader * the {@link ClassLoader}, may be {@code null} * @param resourceSet * the {@link ResourceSet}, must not be {@code null} * @param indexedJvmTypeAccess * the {@link IndexedJvmTypeAccess}, may be {@code null} + * @param typeResourceServices + * the {@link TypeResourceServices}, may be {@code null} */ public BundleAwareTypeProvider(final ClassLoader classLoader, final ResourceSet resourceSet, final IndexedJvmTypeAccess indexedJvmTypeAccess, final TypeResourceServices typeResourceServices) { super(classLoader, resourceSet, indexedJvmTypeAccess, typeResourceServices); diff --git a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java index 624ad7d1bb..279254b552 100644 --- a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/labeling/ExportLabelProvider.java @@ -119,6 +119,7 @@ public String text(final Export context) { * the import * @return the import image */ + @SuppressWarnings("PMD.UnusedFormalParameter") Image image(final Import impaurt) { return JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPDECL); } diff --git a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java index a676a8a720..4a39120d7b 100644 --- a/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.xtext.export.ui/src/com/avaloq/tools/ddk/xtext/export/ui/outline/ExportOutlineTreeProvider.java @@ -61,6 +61,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ExportMo * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final Interface modelElement) { // CHECKSTYLE:ON return true; @@ -74,6 +75,7 @@ protected boolean _isLeaf(final Interface modelElement) { * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final Export modelElement) { // CHECKSTYLE:ON return true; diff --git a/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java b/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java index aaccae97d3..fa3739145c 100644 --- a/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext.export/src/com/avaloq/tools/ddk/xtext/export/scoping/ExportScopeProvider.java @@ -87,6 +87,7 @@ private IScope createEClassScope(final IScope parent, final Import importedPacka * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EClass(final ExportModel context, final EReference reference) { // CHECKSTYLE:ON IScope result = IScope.NULLSCOPE; @@ -117,6 +118,7 @@ private IScope createENamedElementScope(final Iterable * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EStructuralFeature(final DeclarationForType context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getType(); @@ -136,6 +138,7 @@ public IScope scope_EStructuralFeature(final DeclarationForType context, final E * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EAttribute(final DeclarationForType context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getType(); @@ -155,6 +158,7 @@ public IScope scope_EAttribute(final DeclarationForType context, final EReferenc * @return The scope */ // CHECKSTYLE:OFF (MethodName) + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_InterfaceNavigation_ref(final Interface context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getType(); diff --git a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java index 071b7df0e5..c13280669d 100644 --- a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java +++ b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/CompilationContext.java @@ -78,6 +78,8 @@ public Type analyze(final String expression) { * * @param context * xtend context to wrap + * @param genModelUtil + * the gen model utility */ public CompilationContext(final ExecutionContext context, final GenModelUtilX genModelUtil) { this.context = context; @@ -90,6 +92,8 @@ public CompilationContext(final ExecutionContext context, final GenModelUtilX ge * * @param context * xtend context to wrap + * @param genModelUtil + * the gen model utility * @param implicitVar * name of the Java variable to bind "this" to * @param contextType diff --git a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java index 295d3197d7..f84a568fc4 100644 --- a/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java +++ b/com.avaloq.tools.ddk.xtext.expression/src/com/avaloq/tools/ddk/xtext/expression/generator/Graph.java @@ -138,6 +138,8 @@ public Graph addEdge(final T from, final T to) { * Sorts this graph topologically and returns the sorted result. * * @return sorted graph + * @throws IllegalStateException + * if a cycle is detected in the graph */ public List sort() { // TODO try to sort to something as close as possible to the original diff --git a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java index f6c796f659..7c7ce4ef05 100644 --- a/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.format.ui/src/com/avaloq/tools/ddk/xtext/format/ui/labeling/FormatLabelProvider.java @@ -42,6 +42,7 @@ public FormatLabelProvider(final AdapterFactoryLabelProvider delegate) { * the element * @return the string */ + @SuppressWarnings("PMD.UnusedFormalParameter") public String text(final WildcardRule element) { return "*"; //$NON-NLS-1$ } diff --git a/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/GrammarAnalysisReportBuilder.java b/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/GrammarAnalysisReportBuilder.java index beca220994..5eaed834c2 100644 --- a/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/GrammarAnalysisReportBuilder.java +++ b/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/GrammarAnalysisReportBuilder.java @@ -52,6 +52,17 @@ public class GrammarAnalysisReportBuilder { /** * Instantiates a new grammar analysis report builder. + * + * @param mainGrammarName + * the main grammar name + * @param xtextDocFileSimpleName + * the xtext documentation file simple name + * @param sortedKeywords + * the sorted keywords + * @param keywords + * the keywords map + * @param allGrammars + * all grammars */ public GrammarAnalysisReportBuilder(final String mainGrammarName, final String xtextDocFileSimpleName, final List sortedKeywords, final Map> keywords, final List allGrammars) { this.xtextDocFileSimpleName = xtextDocFileSimpleName; diff --git a/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/KeywordAnalysisHelper.java b/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/KeywordAnalysisHelper.java index f77ff99e23..d216693afc 100644 --- a/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/KeywordAnalysisHelper.java +++ b/com.avaloq.tools.ddk.xtext.generator/src/com/avaloq/tools/ddk/xtext/generator/parser/antlr/KeywordAnalysisHelper.java @@ -125,6 +125,9 @@ public KeywordAnalysisHelper(final String parserGrammarFileName, final Grammar g /** * Prepares a report on identifier rules. + * + * @throws UncheckedIOException + * if an I/O error occurs */ private void reportOnIdentifierRules() { List suspectIdentifierRules = Lists.newArrayList(); @@ -171,6 +174,8 @@ private boolean hasLetters(final String keyword) { * * @param srcGenPath * path to src-gen folder of the plugin being generated + * @throws UncheckedIOException + * if an I/O error occurs */ public void printViolations(final String srcGenPath) { try { @@ -269,7 +274,10 @@ public void printViolations(final String srcGenPath) { } /** - * Prepares a report on identifier rules. + * Prepares a report on keywords in identifier rules only. + * + * @throws UncheckedIOException + * if an I/O error occurs */ private void reportOnKeywordsInIdentifierRulesOnly() { Map> keyWordsInIDRules = Maps.newHashMap(); @@ -427,6 +435,8 @@ public List getAllGrammars() { * * @param srcGenPath * Location for generated sources + * @throws UncheckedIOException + * if an I/O error occurs */ public void printReport(final String srcGenPath) { try { diff --git a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java index 2700384751..210bfb0f5a 100644 --- a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/labeling/ScopeLabelProvider.java @@ -95,6 +95,7 @@ public String text(final ScopeRule rule) { * the import * @return the import image */ + @SuppressWarnings("PMD.UnusedFormalParameter") Image image(final Import impaurt) { return JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPDECL); } diff --git a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java index 2d2aafe016..04e4f15146 100644 --- a/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope.ui/src/com/avaloq/tools/ddk/xtext/scope/ui/outline/ScopeOutlineTreeProvider.java @@ -59,6 +59,7 @@ protected void _createChildren(final DocumentRootNode parentNode, final ScopeMod * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final Expression modelElement) { // CHECKSTYLE:ON return true; @@ -72,6 +73,7 @@ protected boolean _isLeaf(final Expression modelElement) { * @return true */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean _isLeaf(final ScopeRule modelElement) { // CHECKSTYLE:ON return true; diff --git a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java index c90bb364b9..ca1fba7325 100644 --- a/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext.scope/src/com/avaloq/tools/ddk/xtext/scope/scoping/ScopeScopeProvider.java @@ -105,6 +105,7 @@ private IScope createENamedElementScope(final Iterable * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EClass(final ScopeModel context, final EReference reference) { // CHECKSTYLE:ON IScope result = IScope.NULLSCOPE; @@ -125,6 +126,7 @@ public IScope scope_EClass(final ScopeModel context, final EReference reference) * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_ScopeContext_reference(final ScopeContext context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getContextType(); @@ -144,6 +146,7 @@ public IScope scope_ScopeContext_reference(final ScopeContext context, final ERe * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_ScopeDefinition_reference(final ScopeDefinition context, final EReference reference) { // CHECKSTYLE:ON final EClass type = context.getContextType(); @@ -190,6 +193,7 @@ public QualifiedName apply(final EObject from) { * @return The scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_ScopeDelegation_scope(final ScopeDelegation context, final EReference reference) { // CHECKSTYLE:ON return getIncludedScopes(IScope.NULLSCOPE, EcoreUtil2.getContainerOfType(context, ScopeModel.class)); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java index 327f336c6a..e10ed157c7 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/AbstractXtextMarkerBasedTest.java @@ -625,6 +625,7 @@ public void setTestClassInvalid() { * @param testSource * the test source, not {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void beforeApplyAssertions(final XtextTestSource testSource) { } diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java index d873827ac5..395ef797e4 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractScopingTest.java @@ -780,6 +780,7 @@ protected void testLinking(final int sourceTag, final EObject targetObject, fina * If target of a reference is an implicit item and this parameter is set to true, the test will get and compare the original object from which this * implicit item was created */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void testLinking(final EObject sourceObject, final int targetTag, final boolean traverseImplicitItems) { assertNotNull(sourceObject, "Source object must not be null."); //$NON-NLS-1$ EObject referencedTargetObject = getObjectForTag(targetTag); @@ -845,6 +846,7 @@ protected void assertEObjectsAreEqual(final EObject sourceObject, final EObject * Cross reference to be resolved, must not be {@code null} * @return the referenced {@link EObject}, must not be {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected EObject getCrossReferencedObject(final int sourceTag, final boolean traverseImplicitItems, final CrossReference crossReference) { EObject context = getObjectForTag(sourceTag); if (crossReference == null) { diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java index b8e426ebc9..e59a736ca4 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractValidationTest.java @@ -974,6 +974,7 @@ public static void assertNoErrorsOnResource(final EObject object, final String.. * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertNoLinkingErrorsOnResource(final EObject object, final String referenceType, final String... referenceNames) { final List linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); @@ -999,6 +1000,7 @@ public static void assertNoLinkingErrorsOnResource(final EObject object, final S * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertLinkingErrorsOnResourceExist(final EObject object, final String referenceType, final String... referenceNames) { final List linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java index 38a5ab84c0..d797d5e8ce 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/jupiter/AbstractXtextMarkerBasedTest.java @@ -627,6 +627,7 @@ public void setTestClassInvalid() { * @param testSource * the test source, not {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void beforeApplyAssertions(final XtextTestSource testSource) { } diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java index ad5df858a6..86b877c451 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/scoping/AbstractScopingTest.java @@ -780,6 +780,7 @@ protected void testLinking(final int sourceTag, final EObject targetObject, fina * If target of a reference is an implicit item and this parameter is set to true, the test will get and compare the original object from which this * implicit item was created */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void testLinking(final EObject sourceObject, final int targetTag, final boolean traverseImplicitItems) { assertNotNull("Source object must not be null.", sourceObject); //$NON-NLS-1$ EObject referencedTargetObject = getObjectForTag(targetTag); @@ -845,6 +846,7 @@ protected void assertEObjectsAreEqual(final EObject sourceObject, final EObject * Cross reference to be resolved, must not be {@code null} * @return the referenced {@link EObject}, must not be {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected EObject getCrossReferencedObject(final int sourceTag, final boolean traverseImplicitItems, final CrossReference crossReference) { EObject context = getObjectForTag(sourceTag); if (crossReference == null) { diff --git a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java index abb767b6eb..8479f692b8 100644 --- a/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java +++ b/com.avaloq.tools.ddk.xtext.test.core/src/com/avaloq/tools/ddk/xtext/test/validation/AbstractValidationTest.java @@ -975,6 +975,7 @@ public static void assertNoErrorsOnResource(final EObject object, final String.. * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertNoLinkingErrorsOnResource(final EObject object, final String referenceType, final String... referenceNames) { final List linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); @@ -1000,6 +1001,7 @@ public static void assertNoLinkingErrorsOnResource(final EObject object, final S * @param referenceNames * the names of the referenced elements */ + @SuppressWarnings("PMD.UnusedFormalParameter") public static void assertLinkingErrorsOnResourceExist(final EObject object, final String referenceType, final String... referenceNames) { final List linkingErrors = object.eResource().getErrors().stream().filter(error -> error instanceof XtextLinkingDiagnostic).collect(Collectors.toList()); final List errorMessages = Lists.transform(linkingErrors, Resource.Diagnostic::getMessage); diff --git a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java index 3a83525d13..a14651d210 100644 --- a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/labeling/AbstractLabelProvider.java @@ -131,7 +131,7 @@ protected Object doGetImage(final Object object) { * the second argument * @return {@code null} by default */ - @SuppressWarnings("PMD.EmptyMethodInAbstractClassShouldBeAbstract") + @SuppressWarnings({"PMD.EmptyMethodInAbstractClassShouldBeAbstract", "PMD.UnusedFormalParameter"}) public Object image(final Object element, final Object feature) { return null; } @@ -156,7 +156,7 @@ public final Object getStyledLabel(final Object object) { * the second argument * @return {@code null} by default */ - @SuppressWarnings("PMD.EmptyMethodInAbstractClassShouldBeAbstract") + @SuppressWarnings({"PMD.EmptyMethodInAbstractClassShouldBeAbstract", "PMD.UnusedFormalParameter"}) public Object getStyledLabel(final Object element, final Object feature) { return null; } diff --git a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/AbstractValidElementBase.java b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/AbstractValidElementBase.java index 6ecd2fe984..692c7ebe58 100644 --- a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/AbstractValidElementBase.java +++ b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/AbstractValidElementBase.java @@ -139,6 +139,8 @@ protected static void logException(final Exception ex, final String msg) { * @param optional * if true, will return null if not found, otherwise IllegalArgumentException is raised * @return the value of the attribute of null if the attribute is optional and not supplied + * @throws IllegalArgumentException + * if the attribute is not optional and not supplied */ protected static String getAttribute(final IConfigurationElement configurationElement, final String name, final boolean optional) { String value = configurationElement.getAttribute(name); diff --git a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/ValidExtensionPointManager.java b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/ValidExtensionPointManager.java index bc400c1086..5cac8fd1ef 100644 --- a/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/ValidExtensionPointManager.java +++ b/com.avaloq.tools.ddk.xtext.ui/src/com/avaloq/tools/ddk/xtext/ui/validation/ValidExtensionPointManager.java @@ -45,6 +45,8 @@ private ValidExtensionPointManager() { * if extension point is unknown * * @return array of proxies + * @throws IllegalArgumentException + * if the extension point is unknown */ public static ValidExtension[] getExtensions() { IExtensionPoint point = Platform.getExtensionRegistry().getExtensionPoint(PLUGIN_ID, EXTENSION_POINT_NAME); diff --git a/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java b/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java index 373295d129..b71db5e0c7 100644 --- a/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java +++ b/com.avaloq.tools.ddk.xtext.valid.ui/src/com/avaloq/tools/ddk/xtext/valid/ui/labeling/ValidLabelProvider.java @@ -36,6 +36,7 @@ public class ValidLabelProvider extends DefaultEObjectLabelProvider { * the category * @return name of the image file */ + @SuppressWarnings("PMD.UnusedFormalParameter") String image(final Category category) { return "category.gif"; //$NON-NLS-1$ } @@ -58,6 +59,7 @@ String image(final Rule rule) { * the quick fix * @return name of the image file */ + @SuppressWarnings("PMD.UnusedFormalParameter") String image(final QuickFix quickFix) { return "quickfix.gif"; //$NON-NLS-1$ } @@ -70,6 +72,7 @@ String image(final QuickFix quickFix) { * the import * @return the import image */ + @SuppressWarnings("PMD.UnusedFormalParameter") Image image(final Import impaurt) { return JavaPlugin.getImageDescriptorRegistry().get(JavaPluginImages.DESC_OBJS_IMPDECL); } @@ -92,6 +95,7 @@ String text(final Import impaurt) { * the native context * @return name of the image file */ + @SuppressWarnings("PMD.UnusedFormalParameter") String image(final NativeContext nativeContext) { return "eclass.gif"; //$NON-NLS-1$ } diff --git a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java index 803a617677..41d1ff5391 100644 --- a/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext.valid/src/com/avaloq/tools/ddk/xtext/valid/scoping/ValidScopeProvider.java @@ -87,6 +87,7 @@ public IScope scope_EPackage(final ValidModel context, final EReference referenc * @return the i scope */ // CHECKSTYLE:OFF + @SuppressWarnings("PMD.UnusedFormalParameter") public IScope scope_EClass(final ValidModel validModel, final EReference reference) { // CHECKSTYLE:ON IScope result = IScope.NULLSCOPE; diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/ExtendedLine.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/ExtendedLine.java index 2e2ee4d435..1c308018ea 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/ExtendedLine.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/ExtendedLine.java @@ -50,6 +50,9 @@ public class ExtendedLine extends ExtendedFormattingConfigBasedStream.AbstractEx /** * Creates a new instance of {@link com.avaloq.tools.ddk.xtext.formatting.ExtendedFormattingConfigBasedStream.AbstractExtendedLine}. + * + * @param configBasedStream + * the extended formatting config based stream */ public ExtendedLine(final ExtendedFormattingConfigBasedStream configBasedStream) { // NOPMD - false positive by PMD configBasedStream.super(); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/SpaceEntry.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/SpaceEntry.java index 718cf17eed..8ae3a5af32 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/SpaceEntry.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/SpaceEntry.java @@ -77,6 +77,8 @@ public String getValue() { * Combine all space locators - the maximum length of any locator. * * @return blanks / spaces. + * @throws IllegalArgumentException + * if an illegal aggregation policy is encountered */ protected String combineSpaceLocators() { String space = null; diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/NoFormatLocator.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/NoFormatLocator.java index 310d153e0c..e2b21832ff 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/NoFormatLocator.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/NoFormatLocator.java @@ -21,6 +21,8 @@ public class NoFormatLocator extends ElementLocator implements IExtendedLocator /** * Creates a new locator. + * + * @param formattingConfig the formatting configuration */ public NoFormatLocator(final FormattingConfig formattingConfig) { // NOPMD CallSuperInConstructor - false positive by PMD formattingConfig.super(); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/OffsetLocator.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/OffsetLocator.java index ed5bc68836..ce760b9d9d 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/OffsetLocator.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/OffsetLocator.java @@ -30,6 +30,8 @@ public class OffsetLocator extends ElementLocator implements ISpaceLocator { /** * Creates a new offset locator. * + * @param formattingConfig + * the formatting configuration * @param offset * the offset */ diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/RightPaddingLocator.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/RightPaddingLocator.java index 39e70608f2..41e9cb9466 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/RightPaddingLocator.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/formatting/locators/RightPaddingLocator.java @@ -30,6 +30,8 @@ public class RightPaddingLocator extends ElementLocator implements ISpaceLocator /** * Instantiates a new right padding locator. * + * @param formattingConfig + * the formatting configuration * @param length * the minimum amount of space allocated for an entry * @see {@link #getPadding(ExtendedLineEntry)} diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/grammar/KeywordCollector.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/grammar/KeywordCollector.java index b79cda1cbd..b79b16a6b8 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/grammar/KeywordCollector.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/grammar/KeywordCollector.java @@ -51,6 +51,9 @@ public class KeywordCollector extends XtextSwitch { *

* Note: By default, keywords are not case sensitive. *

+ * + * @param rule + * the {@link AbstractRule}, must not be {@code null} */ public KeywordCollector(final AbstractRule rule) { this(rule, true); @@ -73,6 +76,8 @@ public KeywordCollector(final AbstractRule rule, final boolean ignoreCase) { * Returns the collected keywords of the {@link AbstractRule}. * * @return the collected keywords, never {@code null} + * @throws IllegalStateException + * if keywords cannot be collected */ public Set getKeywords() { if (ruleKeywords == null) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/layered/DefaultXtextTargetPlatformManager.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/layered/DefaultXtextTargetPlatformManager.java index 3ae22e98b1..fc88d50450 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/layered/DefaultXtextTargetPlatformManager.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/layered/DefaultXtextTargetPlatformManager.java @@ -74,7 +74,7 @@ protected IXtextTargetPlatform basicGetPlatform() { /** * Make sure the platform is loaded. * - * @returns the loaded platform + * @return the loaded platform */ protected IXtextTargetPlatform ensureLoaded() { IXtextTargetPlatform localRef = platform; // access volatile field only once when initialized @@ -95,6 +95,8 @@ protected IXtextTargetPlatform ensureLoaded() { * * @param monitor * progress monitor + * @throws WrappedException + * if loading fails */ protected void load(final IProgressMonitor monitor) { try { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProvider.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProvider.java index 06340c88c6..58dc6f69bd 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProvider.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/AbstractFragmentProvider.java @@ -52,6 +52,8 @@ protected class FragmentSegmentIterator implements Iterator { * * @param fragment * URI fragment to create iterator for, must not be {@code null} + * @throws IllegalArgumentException + * if fragment does not start with segment separator */ public FragmentSegmentIterator(final String fragment) { if (fragment.charAt(0) != SEGMENT_SEPARATOR) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java index fac2004e1a..528deff64f 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/linking/LinkingService.java @@ -190,6 +190,7 @@ protected boolean doRegisterUnresolvedReference(final EObject context, final ERe * The meta model cross-reference, never {@code null} * @return the actual element or a proxy */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected EObject getEObjectOrProxy(final EObject context, final IEObjectDescription desc, final EReference ref) { return desc.getEObjectOrProxy(); } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java index 69057a2079..c2a4beb6bb 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/modelinference/DefaultInferredElementFragmentProvider.java @@ -126,6 +126,7 @@ protected HashCode computeHash(final EClass eClass, final QualifiedName name) { * set of already assigned fragments, must not be {@code null} * @return string (preferably not contained in {@code assignedFragments}), never {@code null} */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected String getFinalResult(final EObject object, final HashCode hash, final Set assignedFragments) { return hash.toString(); } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePattern.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePattern.java index c663c7f95d..a09c4764f5 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePattern.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/naming/QualifiedNamePattern.java @@ -53,6 +53,8 @@ public int compare(final QualifiedName o1, final QualifiedName o2) { * @param singleSegment * the single segment of the newly created qualified name * @return qualified name pattern + * @throws IllegalArgumentException + * if singleSegment is null */ public static QualifiedNamePattern create(final String singleSegment) { if (singleSegment == null) { @@ -114,6 +116,8 @@ public Pattern apply(final String from) { * Qualified name segments * @param verify * {@code true} if pattern should be verified + * @throws IllegalArgumentException + * if wildcard is not in the last segment */ protected QualifiedNamePattern(final String[] segments, final boolean verify) { super(segments); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java index 54f6d96f17..2d8023e502 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/parser/antlr/ParserContext.java @@ -91,6 +91,7 @@ public void setTokenStream(final TokenStream input) { * @param input * Input token stream */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void beforeParse(final TokenStream input) { // No implementation by default } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java index 9d6b23b869..b0f331236c 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/AbstractResourceDescriptionStrategy.java @@ -205,6 +205,7 @@ protected IReferenceDescription createReferenceDescription(final EObject owner, return new ReferenceDescription(owner, target, eReference, exportedContainerURI, indexInList); } + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean isIndexable(final EObject from, final EReference eReference) { return !eReference.isContainment() && !eReference.isContainer(); } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ReferenceDescription.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ReferenceDescription.java index 958c38759a..78eb7051ed 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ReferenceDescription.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ReferenceDescription.java @@ -32,9 +32,15 @@ public final class ReferenceDescription implements IReferenceDescription, IDetac * Creates a new instance of {@link ReferenceDescription}. * * @param from + * the source EObject * @param to + * the target EObject * @param eReference + * the reference * @param containerEObjectURI + * the container EObject URI + * @param indexInList + * the index in the list */ public ReferenceDescription(final EObject from, final EObject to, final EReference eReference, final URI containerEObjectURI, final int indexInList) { this.sourceEObjectURI = EcoreUtil.getURI(from); @@ -48,9 +54,15 @@ public ReferenceDescription(final EObject from, final EObject to, final EReferen * Creates a new instance of {@link ReferenceDescription}. * * @param sourceEObjectURI + * the source EObject URI * @param targetEObjectUri + * the target EObject URI * @param eReference + * the reference * @param containerEObjectURI + * the container EObject URI + * @param indexInList + * the index in the list */ public ReferenceDescription(final URI sourceEObjectURI, final URI targetEObjectUri, final EReference eReference, final URI containerEObjectURI, final int indexInList) { this.sourceEObjectURI = sourceEObjectURI; diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDelta.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDelta.java index 625e45089e..d05e32bdfb 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDelta.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/ResourceDescriptionDelta.java @@ -67,6 +67,8 @@ public String apply(final IEObjectDescription from) { * The new description * @param index * index + * @throws AssertionError + * if old and new descriptions are the same or have different URIs */ public ResourceDescriptionDelta(final IResourceDescription oldDesc, final IResourceDescription newDesc, final IResourceDescriptions index) { if (oldDesc == newDesc) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java index 4c5f7a4b93..cf14bff559 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/extensions/ResourceDescriptions2.java @@ -94,6 +94,7 @@ public Iterable findReferencesToObjects(final Set ta return ResourceDescriptionsUtil.findReferencesToObjects(delegate, targetObjects); } + @SuppressWarnings("PMD.UnusedFormalParameter") public Iterable findExactReferencingResources(final Set targetObjects, final boolean matchImportedNames) { return null; } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingEObjectOutputStream.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingEObjectOutputStream.java index e68c301a3d..316473a22b 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingEObjectOutputStream.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingEObjectOutputStream.java @@ -16,8 +16,8 @@ import java.util.List; import java.util.Map; -import org.apache.logging.log4j.Logger; import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import org.eclipse.emf.common.util.EList; import org.eclipse.emf.common.util.URI; import org.eclipse.emf.ecore.EObject; @@ -83,7 +83,8 @@ public void writeEObjectURI(final EObject obj, final Resource context) throws IO * * @param obj * object to get URI fragment for, must not be {@code null} - * @return URI fragment path, where the segments encode the feature IDs and position in case of multi-valued features, never {@code null} + * @throws IOException + * if an I/O exception occurred */ @SuppressWarnings("unchecked") private void writeEObjectURIFragmentPath(final EObject obj) throws IOException { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingResourceStorageLoadable.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingResourceStorageLoadable.java index cc73ada5b1..04efeaf6e3 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingResourceStorageLoadable.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/resource/persistence/DirectLinkingResourceStorageLoadable.java @@ -85,6 +85,7 @@ public int readCompressedInt() throws IOException { return super.readCompressedInt(); } + @SuppressWarnings("PMD.UnusedFormalParameter") protected void handleLoadEObject(final InternalEObject loaded, final BinaryResourceImpl.EObjectInputStream input) throws IOException { if (modificationTrackingAdapter != null) { loaded.eAdapters().add(modificationTrackingAdapter); @@ -178,6 +179,8 @@ protected void loadIntoResource(final StorageAwareResource resource) throws IOEx * load mode, must not be {@code null} * @throws IOException * if an I/O exception occurred + * @throws IllegalArgumentException + * if the load mode is incompatible */ public void loadIntoResource(final StorageAwareResource resource, final ResourceLoadMode loadMode) throws IOException { if (loadMode.instruction(Constituent.RESOURCE) != Instruction.LOAD) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractNameFunction.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractNameFunction.java index 921567f56e..5fd92fccef 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractNameFunction.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractNameFunction.java @@ -31,7 +31,7 @@ public AbstractNameFunction() { /** * Creates a name function with the given value for {@link #representation}. * - * @param rep + * @param representation * String representation of NameFunction */ public AbstractNameFunction(final String representation) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractPolymorphicScopeProvider.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractPolymorphicScopeProvider.java index d7f44847e1..b7182e5f29 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractPolymorphicScopeProvider.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractPolymorphicScopeProvider.java @@ -110,6 +110,7 @@ public IResourceDescriptions getResourceDescriptions(final Resource resource) { * @param originalResource * Our resource */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected void registerForeignObject(final EObject context, final XtextResource contextResource, final Resource originalResource) { ImplicitReferencesAdapter.findOrCreate(originalResource).addImplicitReference(contextResource.getURI()); } @@ -165,6 +166,7 @@ public IScope getScope(final EObject context, final EReference reference, final * the original resource, must not be {@code null} * @return true if it should be cached */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean doCache(final EObject context, final EReference reference, final String scopeName, final Resource originalResource) { return !context.eContents().isEmpty(); } @@ -182,6 +184,7 @@ protected boolean doCache(final EObject context, final EReference reference, fin * the original resource, must not be {@code null} * @return true if it should be globally cached */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean doGlobalCache(final EObject context, final EReference reference, final String scopeName, final Resource originalResource) { return false; } @@ -264,6 +267,7 @@ public IScope getScope(final EObject context, final EClass type, final String sc * the original resource * @return true if it should be cached */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean doCache(final EObject context, final EClass type, final String scopeName, final Resource originalResource) { return !context.eContents().isEmpty(); } @@ -281,6 +285,7 @@ protected boolean doCache(final EObject context, final EClass type, final String * the original resource, must not be {@code null} * @return true if it should be globally cached */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected boolean doGlobalCache(final EObject context, final EClass type, final String scopeName, final Resource originalResource) { return false; } @@ -310,6 +315,8 @@ protected boolean doGlobalCache(final EObject context, final EClass type, final * @param originalResource * the original resource * @return The list of visible containers. + * @throws IllegalStateException + * if the resource is not an Xtext resource */ protected List getVisibleContainers(final EObject context, final Resource originalResource) { // NOPMD by WTH on 26.01.11 09:26 (NPath // complexity...) @@ -517,6 +524,8 @@ private Object getCacheKey(final EObject context, final ENamedElement namedEleme * @param originalResource * the original resource, must not be {@code null} * @return the scope, or {@code null} + * @throws IllegalArgumentException + * if namedElement is neither an EReference nor an EClass */ protected IScope doGetScope(final EObject context, final ENamedElement namedElement, final String scopeName, final Resource originalResource) { if (namedElement instanceof EReference) { @@ -978,6 +987,8 @@ public Iterable get() { * @param originalResource * the original Resource this scope provider belongs to * @return resulting scope + * @throws IllegalStateException + * if delegate and originalResource are different */ protected IScope newDelegateScope(final String id, final IScope parent, final Resource delegate, final EClass type, final String scopeName, final Resource originalResource) { if (delegate != originalResource) { // NOPMD CompareObjectsWithEquals by WTH on 24.11.10 06:07 @@ -1172,6 +1183,8 @@ public Iterable get() { * @param originalResource * the original Resource this scope provider belongs to * @return resulting scope + * @throws IllegalStateException + * if delegate and originalResource are different */ protected IScope newDelegateScope(final String id, final IScope parent, final Resource delegate, final EReference ref, final String scopeName, final Resource originalResource) { if (delegate != originalResource) { // NOPMD CompareObjectsWithEquals by WTH on 24.11.10 06:07 diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractScopeNameProvider.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractScopeNameProvider.java index cd756d44e4..9985b1eab6 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractScopeNameProvider.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/AbstractScopeNameProvider.java @@ -72,6 +72,8 @@ public Iterable getNameFunctions(final EClass type) { * @param type * type to return default name for * @return default name functions + * @throws IllegalArgumentException + * if type is unknown */ protected Iterable getDefaultNames(final EClass type) { final EStructuralFeature nameFeature = type.getEStructuralFeature("name"); //$NON-NLS-1$ diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/ContainerQuery.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/ContainerQuery.java index 5b126f7703..a8eaa0cd84 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/ContainerQuery.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/scoping/ContainerQuery.java @@ -92,6 +92,8 @@ public EClass getType() { * * @param type * the new type + * @throws IllegalArgumentException + * if the type cannot be converted to EClass */ public void setType(final Object type) { if (type instanceof EReference) { @@ -206,6 +208,7 @@ public Iterable execute(final EObject context) { * @return The query results */ @Deprecated + @SuppressWarnings("PMD.UnusedFormalParameter") public Iterable execute(final Resource context, final Resource originalResource) { return execute(originalResource); } @@ -227,6 +230,7 @@ public Iterable execute(final Resource context, final Resou * @return The query results */ @Deprecated + @SuppressWarnings("PMD.UnusedFormalParameter") public Iterable execute(final EObject context, final Resource originalResource) { return execute(originalResource); } @@ -241,6 +245,8 @@ public Iterable execute(final EObject context, final Resour * @param resource * The resource. * @return The query results + * @throws IllegalStateException + * if the resource is not a LazyLinkingResource */ @SuppressWarnings("nls") public Iterable execute(final Resource resource) { @@ -366,6 +372,8 @@ public static class Builder extends ContainerQuery { /** * Creator. * + * @param domainMapper + * the domain mapper * @param type * {@link ContainerQuery#getType() Type} of objects to query. */ @@ -400,6 +408,7 @@ public Builder copy() { * @deprecated URI pattern matching of resources is no longer supported */ @Deprecated + @SuppressWarnings("PMD.UnusedFormalParameter") public Builder resource(final String uriPattern) { LOGGER.error("URI pattern matching using ContainerQuery.Builder#resource() is no longer supported"); //$NON-NLS-1$ return this; @@ -411,6 +420,8 @@ public Builder resource(final String uriPattern) { * @param pattern * {@link ContainerQuery#getNamePattern() Name pattern} (glob pattern) for queried objects. * @return The Builder itself. + * @throws IllegalArgumentException + * if the wildcard is not at the end of the pattern */ public Builder name(final String pattern) { if (pattern != null && pattern.length() > 0) { @@ -481,6 +492,7 @@ public Builder domains(final String... domainHandles) { * @deprecated Caching of {@link ContainerQuery} is no longer supported */ @Deprecated + @SuppressWarnings("PMD.UnusedFormalParameter") public Builder cache(final boolean doCache) { return this; } diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/serializer/tokens/CommonCrossReferenceSerializer.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/serializer/tokens/CommonCrossReferenceSerializer.java index d7275329e1..3385778466 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/serializer/tokens/CommonCrossReferenceSerializer.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/serializer/tokens/CommonCrossReferenceSerializer.java @@ -54,6 +54,8 @@ public class CommonCrossReferenceSerializer extends CrossReferenceSerializer { * @param grammarElement * the cross reference, must not be {@code null} * @return the converted value or {@code null} if conversion failed + * @throws IllegalStateException + * if the targeted rule name cannot be determined */ protected String getConvertedValue(final String unconverted, final AbstractElement grammarElement) { String ruleName = linkingHelper.getRuleNameFrom(grammarElement); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java index 51050c4632..4cc696218e 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/tracing/ResourceValidationRuleSummaryEvent.java @@ -73,6 +73,7 @@ public static Collector extractFromLoadOptions(final ResourceSet resourceSet) { * @param obj * object against which the validation will be executed */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void ruleStarted(final String rule, final EObject obj) { if (currentRule == null || !currentRule.equals(rule)) { currentRule = rule; @@ -94,6 +95,7 @@ public void ruleStarted(final String rule, final EObject obj) { * @param obj * object against which the validation was executed */ + @SuppressWarnings("PMD.UnusedFormalParameter") public void ruleEnded(final String rule, final EObject obj) { // see comment in ruleStarted() for explanation currentData[0] += System.nanoTime(); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ELists.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ELists.java index 8abefc83e8..b8957e3118 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ELists.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ELists.java @@ -32,6 +32,8 @@ public final class ELists { * @param predicate * to apply * @return filtered list + * @throws IllegalArgumentException + * if predicate is null */ public static EList filter(final EList unfiltered, final Predicate predicate) { if (unfiltered == null) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/EObjectUtil.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/EObjectUtil.java index 7c3bd518c0..145d96009e 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/EObjectUtil.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/EObjectUtil.java @@ -103,6 +103,8 @@ public static String getModelFilename(final EObject object) { * @param scopeName * the scope name, may be {@code null} * @return the scope provider by e object + * @throws IllegalArgumentException + * if the object's resource is not a LazyLinkingResource */ public static IScope getScope(final EObject object, final EClass type, final String scopeName) { Resource resource = object.eResource(); @@ -120,6 +122,8 @@ public static IScope getScope(final EObject object, final EClass type, final Str * @param object * the object * @return the scope provider by e object + * @throws IllegalArgumentException + * if the object's resource is not a LazyLinkingResource */ public static IScopeProvider getScopeProviderByEObject(final EObject object) { if (object.eResource() instanceof LazyLinkingResource) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/InjectorUtil.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/InjectorUtil.java index f76a1c542e..fb2eb5faaa 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/InjectorUtil.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/InjectorUtil.java @@ -39,6 +39,8 @@ public final class InjectorUtil { * @param clazz * the type clazz, must not be {@code null} * @return the implementation instance, never {@code null} + * @throws IllegalStateException + * if the implementation cannot be retrieved */ public static T get(final EObject context, final Class clazz) { final Resource resource = context.eResource(); @@ -73,6 +75,8 @@ public static T get(final EObject context, final Class clazz) { * @param clazz * the type clazz, must not be {@code null} * @return the implementation instance, never {@code null} + * @throws IllegalStateException + * if the implementation cannot be retrieved */ public static T get(final Resource resource, final Class clazz) { if (resource instanceof XtextResource xtextResource) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ParseTreeUtil.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ParseTreeUtil.java index 1ac724dc50..cb8498958c 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ParseTreeUtil.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/util/ParseTreeUtil.java @@ -69,6 +69,8 @@ public static Iterable getIterableParseTree(final IComposit * @param feature * the feature, e.g. CodetabdefPackage.Literals.VERSION_TAG * @return the parsed string + * @throws IllegalArgumentException + * if object is null */ public static String getParsedString(final EObject object, final EStructuralFeature feature) { if (object == null) { @@ -88,6 +90,8 @@ public static String getParsedString(final EObject object, final EStructuralFeat * @param convert * whether or not the parsed string should be run through the value converter * @return the parsed string + * @throws IllegalArgumentException + * if the feature is not part of the object's eclass */ public static String getParsedString(final EObject object, final EStructuralFeature feature, final boolean convert) { if (!object.eClass().getEAllStructuralFeatures().contains(feature)) { @@ -120,6 +124,8 @@ public static String getParsedString(final EObject object, final String feature) * @param convert * {@code true} if the parsed string from the parse tree model should be converted using the corresponding value converter, else {@code false} * @return the parsed string + * @throws IllegalArgumentException + * if the feature name is not valid */ public static String getParsedString(final EObject object, final String featureName, final boolean convert) { EStructuralFeature feature = object.eClass().getEStructuralFeature(featureName); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java index ca3e473131..5dca2ccaa0 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/AbstractDeclarativeValidValidator.java @@ -190,6 +190,7 @@ protected SimpleValidMessage assertEmpty(final String message, final MessagePara * the issue data * @return the error message if the assertion failed, NO_ERROR otherwise */ + @SuppressWarnings("PMD.UnusedFormalParameter") protected SimpleValidMessage assertEmpty(final String message, final String string, final String... issueData) { if (!Strings.isNullOrEmpty(string.trim())) { return new SimpleValidMessage(message); diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessJavaValidationHelper.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessJavaValidationHelper.java index 10db6f83ab..9a31e78708 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessJavaValidationHelper.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessJavaValidationHelper.java @@ -44,6 +44,8 @@ public UniquenessJavaValidationHelper(final INameFunction nameFunction, final Va * an Iterable into which to look for duplicates * @param feature * the feature of the duplicate object on which to anchor the marker + * @throws IllegalArgumentException + * if acceptor is null */ public void warnOnDuplicates(final Iterable possiblyDuplicateObjects, final EStructuralFeature feature) { if (acceptor == null) { @@ -68,6 +70,8 @@ public void warnOnDuplicates(final Iterable possiblyDuplicateObjects, final E * an Iterable into which to look for duplicates * @param feature * the feature of the duplicate object on which to anchor the marker + * @throws IllegalArgumentException + * if acceptor is null */ public void errorOnDuplicates(final Iterable possiblyDuplicateObjects, final EStructuralFeature feature) { if (acceptor == null) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessValidationHelper.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessValidationHelper.java index e4b87305e0..44019a874c 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessValidationHelper.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/UniquenessValidationHelper.java @@ -38,6 +38,8 @@ public class UniquenessValidationHelper { * * @param nameFunction * a function that returns a representation of a T object that can be compared by means of equals + * @throws IllegalArgumentException + * if nameFunction is null */ public UniquenessValidationHelper(final INameFunction nameFunction) { if (nameFunction == null) { diff --git a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/ValidMessage.java b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/ValidMessage.java index 1e0c75679d..c70c665ddd 100644 --- a/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/ValidMessage.java +++ b/com.avaloq.tools.ddk.xtext/src/com/avaloq/tools/ddk/xtext/validation/ValidMessage.java @@ -78,6 +78,10 @@ public ValidMessage(final String message, final E context, final String... issue * the message * @param context * the context + * @param offset + * the offset + * @param length + * the length * @param issueData * the issue data */ diff --git a/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/caching/CacheConfiguration.java b/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/caching/CacheConfiguration.java index e42b90bdb1..e2bd844b9a 100644 --- a/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/caching/CacheConfiguration.java +++ b/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/caching/CacheConfiguration.java @@ -136,6 +136,9 @@ public int getConcurrencyLevel() { * Setsthe concurrency level for the cache. Guava concurrent maps creates as many segments * as the specified concurrency level, each segment having its own lock. * If not set, a reasonable default is deternimed by the library according to the number of CPUs. + * + * @param concurrencyLevel + * the concurrency level */ public void setConcurrencyLevel(final int concurrencyLevel) { this.concurrencyLevel = concurrencyLevel; diff --git a/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/tracing/TraceSet.java b/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/tracing/TraceSet.java index 740ed1ab69..d39b715ca4 100644 --- a/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/tracing/TraceSet.java +++ b/com.avaloq.tools.ddk/src/com/avaloq/tools/ddk/tracing/TraceSet.java @@ -160,6 +160,8 @@ protected void doPost(final T event) { * @param data * event data * @return new event instance + * @throws IllegalStateException + * if the event class cannot be instantiated */ @SuppressWarnings("unchecked") @SuppressFBWarnings("RV_RETURN_VALUE_OF_PUTIFABSENT_IGNORED") diff --git a/ddk-configuration/checkstyle/avaloq.xml b/ddk-configuration/checkstyle/avaloq.xml index 63ac5a7154..0634a4dd64 100644 --- a/ddk-configuration/checkstyle/avaloq.xml +++ b/ddk-configuration/checkstyle/avaloq.xml @@ -70,10 +70,23 @@ + + + + - - + + + + + + + + + + + diff --git a/ddk-configuration/pmd/ruleset.xml b/ddk-configuration/pmd/ruleset.xml index 5ae4cbd431..cca425c723 100644 --- a/ddk-configuration/pmd/ruleset.xml +++ b/ddk-configuration/pmd/ruleset.xml @@ -90,6 +90,11 @@ + + + + +