Skip to content

Commit 51b8130

Browse files
committed
Update note about secret scanning
1 parent 74806c8 commit 51b8130

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

data/release-notes/enterprise-server/3-5/5.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ sections:
99
- The top site admin bar contained a broken link to the SHA for the currently running version of the application.
1010
- Some background tasks could deadlock preventing them from making progress caused by `enterprise-crypto` which has now been modified to be thread safe.
1111
- The list of organizations on the fork screen would overflow its box when a user was in many organizations.
12+
- Alerts from secret scanning for GitHub Advanced Security customers were missing in the web UI and REST API if a site administrator did not upgrade directly to GitHub Enterprise Server 3.4. The alerts are now visible.
1213
changes:
13-
- In some cases, GitHub Advanced Security customers who skipped an upgrade to GitHub Enterprise Server 3.4 may have noticed that alerts from secret scanning were missing in the web UI and REST API. This fix recovers those impacted alerts.
1414
- Performance improvements to the GitHub Enterprise Support Bundle generation process. This modifies the `sanitize_logs` function in `ghe-support-bundle` to run `psed` in parallel vs. serially. This is based on an analysis of bundle generation on `ghe.io` where it was observed we spent 36% of our time in `psed` sanitizing logs.
1515
- Change the `/organizations/`, `/orgs/` API routes to accept organization slugs or IDs. Previously, they only accepted slugs which was inconsistent with the `/enterprises/` routes and caused `Link` headers on GitHub Advanced Security API endpoints, that use IDs not slugs, to be inaccessible to users.
1616
- User generated audit-logs events, such as `repo.create`, are now correctly returned from the REST API availabe at `api.github.com/enterprises/{enterprise}/audit-log`. In addition to that, more types of user generated events, such as `project.create`, are now available on both the enterprise audit-log UI (available at `github.com/enterprises/{enterprise}/settings/audit-log`) and REST API (same endpoint as above).
@@ -25,4 +25,3 @@ sections:
2525
- The {% data variables.product.prodname_registry %} npm registry no longer returns a time value in metadata responses. This was done to allow for substantial performance improvements. We continue to have all the data necessary to return a time value as part of the metadata response and will resume returning this value in the future once we have solved the existing performance issues.
2626
- Resource limits that are specific to processing pre-receive hooks may cause some pre-receive hooks to fail.
2727
- Actions services need to be restarted after restoring an appliance from a backup taken on a different host.
28-
- '{% data reusables.release-notes.ghas-3.4-secret-scanning-known-issue %}'

data/release-notes/enterprise-server/3-6/1.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ sections:
1212
- Fixes an issue where enterprise users were incorrectly seeing a link to the GitHub.com community guidelines.
1313
- Some background tasks could deadlock preventing them from making progress caused by `enterprise-crypto` which has now been modified to be thread safe.
1414
- The top site admin bar contained a broken link to the SHA for the currently running version of the application.
15+
- Alerts from secret scanning for GitHub Advanced Security customers were missing in the web UI and REST API if a site administrator did not upgrade directly to GitHub Enterprise Server 3.4. The alerts are now visible.
1516
changes:
16-
- In some cases, GitHub Advanced Security customers who skipped an upgrade to GitHub Enterprise Server 3.4 may have noticed that alerts from secret scanning were missing in the web UI and REST API. This fix recovers those impacted alerts.
1717
- Performance improvements to the GitHub Enterprise Support Bundle generation process. This modifies the `sanitize_logs` function in `ghe-support-bundle` to run `psed` in parallel vs. serially. This is based on an analysis of bundle generation on `ghe.io` where it was observed we spent 36% of our time in `psed` sanitizing logs.
1818
- Change the `/organizations/`, `/orgs/` API routes to accept organization slugs or IDs. Previously, they only accepted slugs which was inconsistent with the `/enterprises/` routes and caused `Link` headers on GitHub Advanced Security API endpoints, that use IDs not slugs, to be inaccessible to users.
1919
- User generated audit-logs events, such as `repo.create`, are now correctly returned from the REST API availabe at `api.github.com/enterprises/{enterprise}/audit-log`. In addition to that, more types of user generated events, such as `project.create`, are now available on both the enterprise audit-log UI (available at `github.com/enterprises/{enterprise}/settings/audit-log`) and REST API (same endpoint as above).
@@ -32,4 +32,3 @@ sections:
3232
- In a repository's settings, enabling the option to allow users with read access to create discussions does not enable this functionality.
3333
- In some cases, users cannot convert existing issues to discussions.
3434
- Custom patterns for secret scanning have `.*` as an end delimiter, specifically in the "After secret" field. This delimiter causes inconsistencies in scans for secrets across repositories, and you may notice gaps in a repository's history where no scans completed. Incremental scans may also be impacted. To prevent issues with scans, modify the end of the pattern to remove the `.*` delimiter.
35-
- '{% data reusables.release-notes.ghas-3.4-secret-scanning-known-issue %}'
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
{% ifversion ghes < 3.5 %}
22

3-
In some cases, GitHub Advanced Security customers who upgrade to GitHub Enterprise Server 3.5 or later may notice that alerts from secret scanning are missing in the web UI and REST API. To ensure the alerts remain visible, do not skip 3.4 when you upgrade from an earlier release to 3.5 or later. A fix will be available in upcoming patch releases.
3+
In some cases, GitHub Advanced Security customers who upgrade to GitHub Enterprise Server 3.5 or later may notice that alerts from secret scanning are missing in the web UI and REST API. To ensure the alerts remain visible, do not skip 3.4 when you upgrade from an earlier release to 3.5 or later. A fix is available in the [3.5.5](/[email protected]/admin/release-notes#3.5.5) and [3.6.1](/[email protected]/admin/release-notes#3.6.1) patch releases.
44

5-
To plan an upgrade through 3.4, see the [Upgrade assistant](https://support.github.com/enterprise/server-upgrade). [Updated: 2022-08-26]
5+
To plan an upgrade through 3.4, see the [Upgrade assistant](https://support.github.com/enterprise/server-upgrade). [Updated: 2022-09-01]
66

77
{% elsif ghes = 3.5 or ghes = 3.6 %}
88

@@ -11,6 +11,6 @@ In some cases, GitHub Advanced Security customers who upgrade to GitHub Enterpri
1111
- To display the missing alerts for all repositories owned by an organization, organization owners can navigate to the organization's **Code security and analysis** settings, then click **Enable all** for secret scanning. For more information, see "[Managing security and analysis settings for your organization](/organizations/keeping-your-organization-secure/managing-security-settings-for-your-organization/managing-security-and-analysis-settings-for-your-organization#enabling-or-disabling-a-feature-for-all-existing-repositories)."
1212
- To display the missing alerts for an individual repository, people with admin access to the repository can disable then enable secret scanning for the repository. For more information, see "[Managing security and analysis settings for your repository](/repositories/managing-your-repositorys-settings-and-features/enabling-features-for-your-repository/managing-security-and-analysis-settings-for-your-repository)."
1313

14-
A fix will be available in an upcoming patch release. [Updated: 2022-08-26]
14+
A fix is available in the {% ifversion ghes = 3.5 %}[3.5.5](/admin/release-notes#3.5.5){% elsif ghes = 3.6 %}[3.6.1](/admin/release-notes#3.6.1){% endif %} patch release. [Updated: 2022-09-01]
1515

1616
{% endif %}

0 commit comments

Comments
 (0)