callbacks: provide default implementations

Author: dspicher

src/callbacks/balances.rs

@@ -43,14 +43,6 @@ impl Callback for Balances {
         Ok(())
     }
 
-    fn on_header(
-        &mut self,
-        _header: &bitcoin::blockdata::block::Header,
-        _block_height: u64,
-    ) -> anyhow::Result<()> {
-        Ok(())
-    }
-
     /// For each transaction in the block
     ///   1. apply input transactions (remove (TxID == prevTxIDOut and prevOutID == spentOutID))
     ///   2. apply output transactions (add (TxID + curOutID -> HashMapVal))

src/callbacks/mod.rs

@@ -15,20 +15,28 @@ pub trait Callback {
         Self: Sized;
 
     /// Gets called shortly before the blocks are parsed.
-    fn on_start(&mut self, block_height: u64) -> anyhow::Result<()>;
+    fn on_start(&mut self, _block_height: u64) -> anyhow::Result<()> {
+        Ok(())
+    }
 
     /// Gets called if a new header is available.
     fn on_header(
         &mut self,
         _header: &bitcoin::blockdata::block::Header,
         _block_height: u64,
-    ) -> anyhow::Result<()>;
+    ) -> anyhow::Result<()> {
+        Ok(())
+    }
 
     /// Gets called if a new block is available.
-    fn on_block(&mut self, block: &bitcoin::Block, block_height: u64) -> anyhow::Result<()>;
+    fn on_block(&mut self, _block: &bitcoin::Block, _block_height: u64) -> anyhow::Result<()> {
+        Ok(())
+    }
 
     /// Gets called if the parser has finished and all blocks are handled
-    fn on_complete(&mut self, block_height: u64) -> anyhow::Result<()>;
+    fn on_complete(&mut self, _block_height: u64) -> anyhow::Result<()> {
+        Ok(())
+    }
 }
 
 pub struct UnspentValue {

src/callbacks/opreturn.rs

@@ -18,14 +18,6 @@ impl Callback for OpReturn {
         Ok(())
     }
 
-    fn on_header(
-        &mut self,
-        _header: &bitcoin::blockdata::block::Header,
-        _block_height: u64,
-    ) -> anyhow::Result<()> {
-        Ok(())
-    }
-
     fn on_block(&mut self, block: &bitcoin::Block, block_height: u64) -> anyhow::Result<()> {
         for tx in &block.txdata {
             for out in &tx.output {
@@ -51,8 +43,4 @@ impl Callback for OpReturn {
         }
         Ok(())
     }
-
-    fn on_complete(&mut self, _: u64) -> anyhow::Result<()> {
-        Ok(())
-    }
 }

src/callbacks/simplestats.rs

@@ -186,14 +186,6 @@ impl Callback for SimpleStats {
         Ok(())
     }
 
-    fn on_header(
-        &mut self,
-        _header: &bitcoin::blockdata::block::Header,
-        _block_height: u64,
-    ) -> anyhow::Result<()> {
-        Ok(())
-    }
-
     fn on_block(&mut self, block: &bitcoin::Block, block_height: u64) -> anyhow::Result<()> {
         self.n_valid_blocks += 1;
         self.n_tx += block.txdata.len();

src/callbacks/unspentcsvdump.rs

@@ -45,14 +45,6 @@ impl crate::callbacks::Callback for UnspentCsvDump {
         Ok(())
     }
 
-    fn on_header(
-        &mut self,
-        _header: &bitcoin::blockdata::block::Header,
-        _block_height: u64,
-    ) -> anyhow::Result<()> {
-        Ok(())
-    }
-
     /// For each transaction in the block
     ///   1. apply input transactions (remove (TxID == prevTxIDOut and prevOutID == spentOutID))
     ///   2. apply output transactions (add (TxID + curOutID -> HashMapVal))