Skip to content

Commit c0e9f80

Browse files
authored
Merge pull request #85 from BoniLindsley/fix-84-letter-case-of-user-repo
Lower case command arguments user and repo
2 parents aac4c98 + 8417787 commit c0e9f80

File tree

1 file changed

+13
-8
lines changed

1 file changed

+13
-8
lines changed

lib/git-issue/import-export.sh

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ USAGE_export_EOF
2424
exit 2
2525
}
2626

27+
convert_to_lower_case()
28+
{
29+
echo "$1" | tr '[:upper:]' '[:lower:]'
30+
}
31+
2732
# importsget: Return all mentions of SHA given in imports
2833

2934
importsget()
@@ -202,8 +207,8 @@ create_issue()
202207
path=$(issue_path_part "$1") || exit
203208
isha=$(issue_sha "$path")
204209
provider="$2"
205-
user="$3"
206-
repo="$4"
210+
user="$(convert_to_lower_case $3)"
211+
repo="$(convert_to_lower_case $4)"
207212

208213
if [ "$provider" = gitlab ] ; then
209214
# if the repo belongs to a group, repo will be in the format groupname/reponame
@@ -810,8 +815,8 @@ export_issues()
810815
test -n "$2" -a -n "$3" || usage_export
811816
test "$1" = github -o "$1" = gitlab || usage_export
812817
provider=$1
813-
user="$2"
814-
repo="$3"
818+
user="$(convert_to_lower_case $2)"
819+
repo="$(convert_to_lower_case $3)"
815820

816821
cdissues
817822
test -d "imports/$provider/$user/$repo" || error "No local issues found for this repository."
@@ -886,8 +891,8 @@ sub_import()
886891
test "$1" = github -o "$1" = gitlab -a -n "$2" -a -n "$3" || usage_import
887892
provider="$1"
888893
# convert to lowercase to avoid duplicates
889-
user="$(echo "$2" | tr '[:upper:]' '[:lower:]')"
890-
repo="$(echo "$3" | tr '[:upper:]' '[:lower:]')"
894+
user="$(convert_to_lower_case $2)"
895+
repo="$(convert_to_lower_case $3)"
891896

892897
cdissues
893898

@@ -959,8 +964,8 @@ sub_exportall()
959964
test "$1" = github -o "$1" = gitlab || usage_exportall
960965
test -n "$2" -a -n "$3" || usage_exportall
961966
provider="$1"
962-
user="$2"
963-
repo="$3"
967+
user="$(convert_to_lower_case $2)"
968+
repo="$(convert_to_lower_case $3)"
964969

965970
# Create list of relevant shas sorted by date
966971
shas=$(sub_list -l %i -o %c "$all"| sed '/^$/d' | tr '\n' ' ')

0 commit comments

Comments
 (0)