Skip to content

Commit 9ea6bf7

Browse files
authored
Relax event message validation rules (#3394)
Replace some message validation rules with implicit message transformations. Some event messages may include extracts from external sources (e.g., external error messages), that do not pass the validation rules. Such cases may be difficult to find during development, and we do not want them to break dstack in production.
1 parent 03df449 commit 9ea6bf7

File tree

1 file changed

+1
-6
lines changed
  • src/dstack/_internal/server/services

1 file changed

+1
-6
lines changed

src/dstack/_internal/server/services/events.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -171,14 +171,9 @@ def emit(session: AsyncSession, message: str, actor: AnyActor, targets: list[Tar
171171
"""
172172
if not targets:
173173
raise ValueError("At least one target must be specified")
174+
message = message.strip().rstrip(".").replace("\n", " ")
174175
if not message:
175176
raise ValueError("Message cannot be empty")
176-
if message.strip() != message:
177-
raise ValueError("Message cannot have leading or trailing whitespace")
178-
if "\n" in message:
179-
raise ValueError("Message cannot contain newlines")
180-
if message.endswith("."):
181-
raise ValueError("Message cannot end with a period")
182177

183178
logger.info(
184179
"Emitting event: %s. Event targets: %s. Actor: %s",

0 commit comments

Comments
 (0)