Move DualNumbers to an extension (JuliaApproximation#888)

* Move DualNumbers to an extension

* only define dualcfsFun in ApproxFun

* fix path

Author: jishnub

Project.toml

@@ -42,13 +42,20 @@ SpecialFunctions = "1.1, 2"
 StaticArrays = "1"
 julia = "1.6"
 
+[extensions]
+ApproxFunDualNumbersExt = "DualNumbers"
+
 [extras]
 ApproxFunBaseTest = "a931bfaf-0cfd-4a5c-b69c-bf2eed002b43"
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 BlockBandedMatrices = "ffab5731-97b5-5995-9138-79e8c1846df0"
 Documenter = "e30172f5-a6a5-5a46-863b-614d45cd2de4"
+DualNumbers = "fa6b7ba4-c1ee-5f82-b5fc-ecf0adba8f74"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
 [targets]
-test = ["ApproxFunBaseTest", "Aqua", "BlockBandedMatrices", "Documenter", "Random", "Test"]
+test = ["ApproxFunBaseTest", "Aqua", "BlockBandedMatrices", "Documenter", "DualNumbers", "Random", "Test"]
+
+[weakdeps]
+DualNumbers = "fa6b7ba4-c1ee-5f82-b5fc-ecf0adba8f74"

src/Extras/dualnumbers.jl renamed to ext/ApproxFunDualNumbersExt.jl

@@ -1,13 +1,24 @@
+module ApproxFunDualNumbersExt
+
+using DualNumbers
+using ApproxFun
+using ApproxFun: TransformPlan, ITransformPlan
+import ApproxFunBase: valsdomain_type_promote
+using DomainSets
+import FastTransforms: ChebyshevTransformPlan, plan_chebyshevtransform,
+                        plan_chebyshevtransform!, plan_ichebyshevtransform,
+                        plan_ichebyshevtransform!
+
 # Dual number support. Should there be realpart and dualpart of Space and Domain?
 DualNumbers.realpart(f::Fun{S,T}) where {S,T<:Dual} = Fun(space(f),realpart.(coefficients(f)))
 DualNumbers.dualpart(f::Fun{S,T}) where {S,T<:Dual} = Fun(space(f),dualpart.(coefficients(f)))
 
 
 DualNumbers.realpart(d::Segment{<:Dual}) = Segment(realpart(leftendpoint(d)),realpart(rightendpoint(d)))
 
-indomain(x::Number, d::Segment{<:Dual}) = in(x,realpart(d))
-indomain(x::Dual, d::Segment{<:Dual}) = in(realpart(x),realpart(d))
-isempty(d::Segment{<:Dual}) = isempty(realpart(d))
+DomainSets.indomain(x::Number, d::Segment{<:Dual}) = in(x,realpart(d))
+DomainSets.indomain(x::Dual, d::Segment{<:Dual}) = in(realpart(x),realpart(d))
+Base.isempty(d::Segment{<:Dual}) = isempty(realpart(d))
 
 
 
@@ -33,22 +44,22 @@ plan_ichebyshevtransform(v::AbstractVector{D}, ::Val{kind}) where {D<:Dual,kind}
 
 
 
-*(P::ChebyshevTransformPlan,v::AbstractVector{<:Dual}) = dual.(P*realpart.(v),P*dualpart.(v))
+Base.:(*)(P::ChebyshevTransformPlan,v::AbstractVector{<:Dual}) = dual.(P*realpart.(v),P*dualpart.(v))
 
 #TODO: Hardy{false}
 for (OP,TransPlan) in ((:plan_transform,:TransformPlan),(:plan_itransform,:ITransformPlan)),
         TYP in  (:Fourier,:Laurent,:SinSpace)
     @eval begin
-        function $OP(sp::$TYP{D},x::AbstractVector{T}) where {T<:Dual,D<:Domain}
+        function ApproxFun.$OP(sp::$TYP{D},x::AbstractVector{T}) where {T<:Dual,D<:Domain}
             plan = $OP(sp,realpart.(x))
             $TransPlan{T,typeof(sp),false,typeof(plan)}(sp,plan)
         end
-        *(P::$TransPlan{T,$TYP{D},false},x::AbstractVector{T}) where {T<:Dual,D<:Domain} =
+        Base.:(*)(P::$TransPlan{T,$TYP{D},false},x::AbstractVector{T}) where {T<:Dual,D<:Domain} =
             dual(P.plan*realpart.(x),P.plan*dualpart.(x))
     end
 end
 
-chop!(f::Fun,d::Dual)=chop!(f,realpart(d))
+ApproxFun.chop!(f::Fun,d::Dual)=chop!(f,realpart(d))
 
 
 
@@ -62,12 +73,12 @@ function simplifycfs!(cfs::AbstractVector{DD},tol::Float64=4E-16) where DD<:Dual
 end
 
 
-function dualFun(f,S,n)
+function ApproxFun.dualFun(f,S,n)
     pts=points(S,n) + Dual{Float64}[dual(0.,rand(Bool)) for k=1:n]
     Fun(transform(S,map(f,pts)),S)
 end
 
-function dualcfsFun(f,S)
+function ApproxFun.dualcfsFun(f,S)
     T = real(float(eltype(domain(S))))
     r=checkpoints(S)
     f0=f(first(r))
@@ -84,7 +95,7 @@ function dualcfsFun(f,S)
     for logn = 4:20
         n=2^logn
 
-        cf=dualFun(f,S,n)
+        cf = dualFun(f,S,n)
 
         if maximum(abs,realpart(cf.coefficients[end-8:end]))<maximum(abs,dualpart(cf.coefficients[end-8:end]))*tol &&
                                 all(k->norm(cf(r[k])-fr[k],1)<1E-4,1:length(r))
@@ -95,3 +106,5 @@ function dualcfsFun(f,S)
 
     Fun(f,S,2^21)
 end
+
+end

src/ApproxFun.jl

@@ -1,6 +1,6 @@
 module ApproxFun
 using Base, Reexport,
-		AbstractFFTs, FFTW, DualNumbers, FastTransforms,
+		AbstractFFTs, FFTW, FastTransforms,
 		LinearAlgebra, RecipesBase, DomainSets, SpecialFunctions #, Arpack
 
 import Calculus

src/Extras/Extras.jl

@@ -20,6 +20,10 @@ include("simplify.jl")
 include("autodifferentiation.jl")
 include("fractional.jl")
 
+function dualFun end
+function dualcfsFun end
 
-include("dualnumbers.jl")
+if !isdefined(Base, :get_extension)
+	include(joinpath(dirname(dirname(pathof(@__MODULE__))), "ext", "ApproxFunDualNumbersExt.jl"))
+end
 include("lanczos.jl")