Skip to content

VCRURLConnection doesn’t consider request headers and body #21

@0xced

Description

@0xced

VCRURLConnection doesn’t properly record requests if they have the same method and same URL but different headers and/or body. This is obvious when looking at the source code since VCRRequestKey is based on the URI and method properties only.

An example where this behavior becomes problematic is when using the Range header. Say you first ask for range 0-123 then you ask for range 0-12345. The second request will never be recorded because it’s considered equal to the first one since it has the same URL and same method.

I plan to work on this issue but before I start I’d like to know what’s the status of #16 as these issues are slightly related.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions