Skip to content

Commit 21f2ff7

Browse files
committed
Fix #81120: PGO data for main PHP DLL are not used
We need to look for the right file. To avoid total confusion, we also rename the variables; however, the right solution would have been to drop the version suffixes, since they don't help (major + minor maybe, but not major only).
1 parent 0877738 commit 21f2ff7

File tree

2 files changed

+9
-6
lines changed

2 files changed

+9
-6
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ PHP NEWS
4545
. Fixed bug #77627 (method_exists on Closure::__invoke inconsistency).
4646
(krakjoe)
4747

48+
- Windows:
49+
. Fixed bug #81120 (PGO data for main PHP DLL are not used). (cmb)
50+
4851
03 Jun 2021, PHP 8.0.7
4952

5053
- Core:

win32/build/Makefile

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,15 +98,15 @@ sapi\phpdbg\phpdbg_lexer.c: sapi\phpdbg\phpdbg_lexer.l
9898
!endif
9999

100100
!if "$(ZTS)" == "1"
101-
PHP7_PGD_SUFFIX=ts
101+
PHP8_PGD_SUFFIX=ts
102102
!else
103-
PHP7_PGD_SUFFIX=
103+
PHP8_PGD_SUFFIX=
104104
!endif
105105

106106
!if $(PGOMGR) != ""
107-
PHP7_PGD_OPTION=/PGD:$(PGOPGD_DIR)\php7$(PHP7_PGD_SUFFIX).pgd
107+
PHP8_PGD_OPTION=/PGD:$(PGOPGD_DIR)\php8$(PHP8_PGD_SUFFIX).pgd
108108
!else
109-
PHP7_PGD_OPTION=
109+
PHP8_PGD_OPTION=
110110
!endif
111111

112112
PHPDLL_RES=$(BUILD_DIR)\$(PHPDLL).res
@@ -132,8 +132,8 @@ $(PHPDLL_RES): win32\build\template.rc
132132

133133
$(BUILD_DIR)\$(PHPDLL): generated_files $(PHPDEF) $(PHP_GLOBAL_OBJS) $(STATIC_EXT_OBJS) $(PHPDLL_RES) $(MCFILE)
134134
@copy win32\build\default.manifest $(BUILD_DIR)\$(PHPDLL).manifest >nul
135-
# @$(CC) $(PHP_GLOBAL_OBJS) $(STATIC_EXT_OBJS) $(STATIC_EXT_LIBS) $(LIBS) $(PHPDLL_RES) /link /out:$(BUILD_DIR)\$(PHPDLL) $(PHP7_PGD_OPTION) $(PHP_LDFLAGS) $(LDFLAGS) $(STATIC_EXT_LDFLAGS)
136-
@"$(LINK)" $(PHP_GLOBAL_OBJS_RESP) $(STATIC_EXT_OBJS_RESP) $(STATIC_EXT_LIBS) $(LIBS) $(PHPDLL_RES) /out:$(BUILD_DIR)\$(PHPDLL) $(PHP7_PGD_OPTION) $(PHP_LDFLAGS) $(LDFLAGS) $(STATIC_EXT_LDFLAGS)
135+
# @$(CC) $(PHP_GLOBAL_OBJS) $(STATIC_EXT_OBJS) $(STATIC_EXT_LIBS) $(LIBS) $(PHPDLL_RES) /link /out:$(BUILD_DIR)\$(PHPDLL) $(PHP8_PGD_OPTION) $(PHP_LDFLAGS) $(LDFLAGS) $(STATIC_EXT_LDFLAGS)
136+
@"$(LINK)" $(PHP_GLOBAL_OBJS_RESP) $(STATIC_EXT_OBJS_RESP) $(STATIC_EXT_LIBS) $(LIBS) $(PHPDLL_RES) /out:$(BUILD_DIR)\$(PHPDLL) $(PHP8_PGD_OPTION) $(PHP_LDFLAGS) $(LDFLAGS) $(STATIC_EXT_LDFLAGS)
137137
-@$(_VC_MANIFEST_EMBED_DLL)
138138

139139
$(BUILD_DIR)\$(PHPLIB): $(BUILD_DIR)\$(PHPDLL)

0 commit comments

Comments
 (0)