readline: inline _readline_long_zval() function (php#15840)

DanielEScherzer · web-flow · commit 4ffc971f6277 · 2024-09-11T20:43:21.000+02:00
Unneeded wrapper around the `ZVAL_LONG()` macro
diff --git a/ext/readline/readline.c b/ext/readline/readline.c
@@ -453,19 +453,14 @@ static void _readline_string_zval(zval *ret, const char *str)
 	}
 }
 
-static void _readline_long_zval(zval *ret, long l)
-{
-	ZVAL_LONG(ret, l);
-}
-
 char **php_readline_completion_cb(const char *text, int start, int end)
 {
 	zval params[3];
 	char **matches = NULL;
 
 	_readline_string_zval(&params[0], text);
-	_readline_long_zval(&params[1], start);
-	_readline_long_zval(&params[2], end);
+	ZVAL_LONG(&params[1], start);
+	ZVAL_LONG(&params[2], end);
 
 	if (call_user_function(NULL, NULL, &_readline_completion, &_readline_array, 3, params) == SUCCESS) {
 		if (Z_TYPE(_readline_array) == IS_ARRAY) {

Original file line number	Diff line number	Diff line change
`@@ -453,19 +453,14 @@ static void _readline_string_zval(zval ret, const char str)`
`453`	`453`	`}`
`454`	`454`	`}`
`455`	`455`
`456`		`-static void _readline_long_zval(zval *ret, long l)`
`457`		`-{`
`458`		`- ZVAL_LONG(ret, l);`
`459`		`-}`
`460`		`-`
`461`	`456`	`char *php_readline_completion_cb(const char text, int start, int end)`
`462`	`457`	`{`
`463`	`458`	`zval params[3];`
`464`	`459`	`char **matches = NULL;`
`465`	`460`
`466`	`461`	`_readline_string_zval(&params[0], text);`
`467`		`- _readline_long_zval(&params[1], start);`
`468`		`- _readline_long_zval(&params[2], end);`
	`462`	`+ ZVAL_LONG(&params[1], start);`
	`463`	`+ ZVAL_LONG(&params[2], end);`
`469`	`464`
`470`	`465`	`if (call_user_function(NULL, NULL, &_readline_completion, &_readline_array, 3, params) == SUCCESS) {`
`471`	`466`	`if (Z_TYPE(_readline_array) == IS_ARRAY) {`