Skip to content

Conversation

@dtcxzyw
Copy link
Owner

@dtcxzyw dtcxzyw commented Dec 2, 2024

Link: llvm/llvm-project#118257
Requested by: @dtcxzyw

@github-actions github-actions bot mentioned this pull request Dec 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

runner: buildkitsandbox
baseline: llvm/llvm-project@a8a494f
patch: llvm/llvm-project#118257
sha256: 9707b10196f80d60b1aff7ffb180160b9cb68a501cf040b1108b499cd38ba16d
commit: af4aff9

127 files changed, 27642 insertions(+), 28233 deletions(-)

Improvements:
  instcombine.NumSimplified 412145 -> 412179 +0.01%
  globalsmodref-aa.NumNoMemFunctions 781046 -> 781087 +0.01%
  globalsmodref-aa.NumReadMemFunctions 1142131 -> 1142172 +0.00%
  globalopt.NumDeleted 823399 -> 823410 +0.00%
  local.NumRemoved 3776944 -> 3776972 +0.00%
  gvn.IsValueFullyAvailableInBlockNumSpeculationsMax 463360 -> 463363 +0.00%
  instcombine.NumCombined 95561392 -> 95561731 +0.00%
  simplifycfg.NumHoistCommonInstrs 1763108 -> 1763114 +0.00%
  memdep.NumCacheCompleteNonLocalPtr 4119949 -> 4119953 +0.00%
  instcombine.NumTwoIterations 17154478 -> 17154494 +0.00%
Regressions:
  adce.NumBranchesRemoved 22388 -> 22386 -0.01%
  simplifycfg.NumInvokesMerged 147808 -> 147805 -0.00%
  simplifycfg.NumInvokeSetsFormed 53901 -> 53900 -0.00%
  adce.NumRemoved 88000 -> 87999 -0.00%
  sccp.NumDeadBlocks 706976 -> 706972 -0.00%
  gvn.NumGVNInstr 7581926 -> 7581887 -0.00%
  gvn.NumGVNSimpl 4152386 -> 4152369 -0.00%
  memdep.NumCacheNonLocalPtr 174944949 -> 174944442 -0.00%
  memdep.NumUncacheNonLocalPtr 171483084 -> 171482642 -0.00%
  sccp.NumInstRemoved 1912762 -> 1912758 -0.00%

af4aff9 pre-commit: Update
5 2 bench/abc/optimized/sclSize.c.ll
2 2 bench/abseil-cpp/optimized/convert_test.cc.ll
10 10 bench/arrow/optimized/slow.cc.ll
78 78 bench/assimp/optimized/IFCReaderGen1_2x3.cpp.ll
34 34 bench/assimp/optimized/IFCReaderGen2_2x3.cpp.ll
215 217 bench/boost/optimized/buffer_with_strategies.ll
214 216 bench/boost/optimized/difference_linear_linear.ll
1 3 bench/bullet3/optimized/btSoftBody.ll
4 4 bench/ceres/optimized/block_sparse_matrix.cc.ll
1 1 bench/folly/optimized/FunctionScheduler.cpp.ll
244 253 bench/g2o/optimized/optimizable_graph.cpp.ll
147 156 bench/g2o/optimized/vertex_ellipse.cpp.ll
61 61 bench/graphviz/optimized/emit.c.ll
30 42 bench/graphviz/optimized/input.c.ll
11 11 bench/hermes/optimized/SamplingProfilerSampler.cpp.ll
27 22 bench/icu/optimized/putil.ll
91 93 bench/imgui/optimized/imgui.cpp.ll
3 3 bench/llvm/optimized/RISCVISelLowering.cpp.ll
173 182 bench/meshlab/optimized/edit_align.cpp.ll
181 190 bench/meshlab/optimized/edit_point.cpp.ll
176 185 bench/meshlab/optimized/edit_referencing.cpp.ll
180 189 bench/meshlab/optimized/filter_colorproc.cpp.ll
69 69 bench/meshlab/optimized/filter_func.cpp.ll
175 184 bench/meshlab/optimized/filter_voronoi.cpp.ll
9 9 bench/meshlab/optimized/matching.cpp.ll
178 187 bench/meshlab/optimized/meshselect.cpp.ll
14 14 bench/minetest/optimized/test_serialization.cpp.ll
278 279 bench/mitsuba3/optimized/principled.cpp.ll
5 5 bench/nix/optimized/nix-build.ll
8 5 bench/opencv/optimized/binary_descriptor.cpp.ll
8 8 bench/opencv/optimized/short_term_imageless_tracker.cpp.ll
4 1 bench/opencv/optimized/speech_recognition.cpp.ll
12 12 bench/opencv/optimized/tldUtils.cpp.ll
11 8 bench/openspiel/optimized/mcts.cc.ll
45 48 bench/php/optimized/logical_filters.ll
73 79 bench/php/optimized/zend_API.ll
49 49 bench/proj/optimized/coordinateoperationfactory.cpp.ll
15 15 bench/proj/optimized/io.cpp.ll
129 125 bench/quantlib/optimized/beta.ll
1 2 bench/quantlib/optimized/longstaffschwartzmultipathpricer.ll
9 6 bench/quantlib/optimized/normaldistribution.ll
22 46 bench/quantlib/optimized/tcopulapolicy.ll
47 48 bench/quantlib/optimized/termstructure.ll
27 49 bench/ruby/optimized/enum.ll
16 18 bench/stat-rs/optimized/3koi1gt1wwkf7v6z.ll
131 138 bench/stat-rs/optimized/4d9pj14shc9lbmph.ll
48 63 bench/typst-rs/optimized/4qskctz4kwc33g7b.ll
250 254 bench/typst-rs/optimized/59tuvc5m3xlovl3o.ll
3 1 bench/yoga/optimized/CalculateLayout.cpp.ll
6 6 bench/yosys/optimized/logger.ll
160 175 bench/z3/optimized/qi_queue.cpp.ll

%cmp.i2.sink.i.i1748 = fcmp olt float %retval.sroa.0.0.i1765, %add.i1752
%or.cond.i.i1745 = fcmp ord float %add.i1752, 0.000000e+00
%cmp.i.i.i1747 = fcmp olt float %retval.sroa.0.0.i1765, %add.i1752
%cmp.i2.sink.i.i1748 = select i1 %or.cond.i.i1745, i1 %cmp.i.i.i1747, i1 false
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot reproduce it with 22417ec6cca0ed8ccecb0c2b77011e591378fd2a.
Looks like it doesn't matter: https://godbolt.org/z/qxcxKh6eM.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"

%"struct.facebook::yoga::FloatOptional" = type { float }

declare i1 @_ZN8facebook4yoga4Node21styleDefinesDimensionENS0_13FlexDirectionEf()

define i1 @_ZNK8facebook4yoga13FloatOptional9isDefinedEv(ptr %this) {
entry:
  %0 = load float, ptr %this, align 4
  %call = call i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %0)
  ret i1 %call
}

define i1 @_ZN8facebook4yoga11isUndefinedITkSt14floating_pointfEEbT_(float %value) {
entry:
  %cmp = fcmp uno float %value, 0.000000e+00
  ret i1 %cmp
}

define i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %value) {
entry:
  %call = call i1 @_ZN8facebook4yoga11isUndefinedITkSt14floating_pointfEEbT_(float %value)
  %lnot = xor i1 %call, true
  ret i1 %lnot
}

define float @_ZN8facebook4yoga12maxOrDefinedITkSt14floating_pointfTkSt14floating_pointfEEDaT_T0_(float %a, float noundef %b) {
entry:
  %a.addr111 = alloca [0 x [0 x [0 x float]]], i32 0, align 4
  %b.addr = alloca float, align 4
  store float %a, ptr %a.addr111, align 4
  store float %b, ptr %b.addr, align 4
  %call = call i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %a)
  br i1 %call, label %land.lhs.true, label %if.end

land.lhs.true:                                    ; preds = %entry
  %call1 = call i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %b)
  br i1 %call1, label %if.then, label %if.end

if.then:                                          ; preds = %land.lhs.true
  %call2 = call ptr @_ZSt3maxIfERKT_S2_S2_(ptr %a.addr111, ptr %b.addr)
  %0 = load float, ptr %call2, align 4
  br label %return

if.end:                                           ; preds = %land.lhs.true, %entry
  %call3 = call i1 @_ZN8facebook4yoga11isUndefinedITkSt14floating_pointfEEbT_(float %a)
  %cond = select i1 %call3, float 0.000000e+00, float %a
  br label %return

return:                                           ; preds = %if.end, %if.then
  %retval.0 = phi float [ %0, %if.then ], [ %cond, %if.end ]
  ret float %retval.0
}

define void @_ZN8facebook4yogaL24computeFlexBasisForChildEPKNS0_4NodeEPS1_fNS0_10SizingModeEfffS5_NS0_9DirectionERNS0_10LayoutDataEjj(float %width, float %call10, i1 %call33) {
entry:
  %resolvedFlexBasis111 = alloca [0 x [0 x [0 x %"struct.facebook::yoga::FloatOptional"]]], i32 0, align 4
  store float %call10, ptr %resolvedFlexBasis111, align 4
  %call11 = call i1 @_ZN8facebook4yoga4Node21styleDefinesDimensionENS0_13FlexDirectionEf()
  %call15 = call i1 @_ZNK8facebook4yoga13FloatOptional9isDefinedEv(ptr %resolvedFlexBasis111)
  %call15.not = xor i1 %call15, true
  %brmerge = select i1 %call15.not, i1 true, i1 %call33
  br i1 %brmerge, label %common.ret, label %if.then

common.ret:                                       ; preds = %if.then, %entry
  ret void

if.then:                                          ; preds = %entry
  %call30 = call float @_ZN8facebook4yoga12maxOrDefinedENS0_13FloatOptionalES1_(float %call10, float %width)
  store volatile float %call30, ptr null, align 4
  br label %common.ret
}

define float @_ZN8facebook4yoga12maxOrDefinedENS0_13FloatOptionalES1_(float %lhs.coerce, float %rhs.coerce) {
entry:
  %call3 = call float @_ZN8facebook4yoga12maxOrDefinedITkSt14floating_pointfTkSt14floating_pointfEEDaT_T0_(float %lhs.coerce, float %rhs.coerce)
  ret float %call3
}

define ptr @_ZSt3maxIfERKT_S2_S2_(ptr %__a, ptr %__b) {
entry:
  %0 = load float, ptr %__a, align 4
  %1 = load float, ptr %__b, align 4
  %cmp = fcmp olt float %0, %1
  %__b.__a = select i1 %cmp, ptr %__b, ptr %__a
  ret ptr %__b.__a
}

@dtcxzyw
Copy link
Owner Author

dtcxzyw commented Dec 2, 2024

/add-label reviewed,regression

@dtcxzyw
Copy link
Owner Author

dtcxzyw commented Dec 2, 2024

/close

@github-actions github-actions bot closed this Dec 2, 2024
@dtcxzyw dtcxzyw reopened this Dec 2, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2024

runner: buildkitsandbox
baseline: llvm/llvm-project@a8a494f
patch: llvm/llvm-project#118257
sha256: c20a4b399925a87e3ecbc9044db97712e03dd2c23fb9b0fea37676dc2543c8ee
commit: ab28ecc

83 files changed, 24162 insertions(+), 24586 deletions(-)

Improvements:
  instcombine.NumSimplified 412145 -> 412178 +0.01%
  globalsmodref-aa.NumNoMemFunctions 781046 -> 781087 +0.01%
  globalsmodref-aa.NumReadMemFunctions 1142131 -> 1142172 +0.00%
  globalopt.NumDeleted 823399 -> 823410 +0.00%
  local.NumRemoved 3776944 -> 3776972 +0.00%
  gvn.IsValueFullyAvailableInBlockNumSpeculationsMax 463360 -> 463363 +0.00%
  instcombine.NumCombined 95561392 -> 95561731 +0.00%
  simplifycfg.NumHoistCommonInstrs 1763108 -> 1763114 +0.00%
  memdep.NumCacheCompleteNonLocalPtr 4119949 -> 4119953 +0.00%
  simplifycfg.NumSimpl 42457891 -> 42457931 +0.00%
Regressions:
  adce.NumBranchesRemoved 22388 -> 22386 -0.01%
  simplifycfg.NumInvokesMerged 147808 -> 147805 -0.00%
  simplifycfg.NumInvokeSetsFormed 53901 -> 53900 -0.00%
  adce.NumRemoved 88000 -> 87999 -0.00%
  sccp.NumDeadBlocks 706976 -> 706972 -0.00%
  gvn.NumGVNInstr 7581926 -> 7581887 -0.00%
  gvn.NumGVNSimpl 4152386 -> 4152369 -0.00%
  memdep.NumCacheNonLocalPtr 174944949 -> 174944438 -0.00%
  memdep.NumUncacheNonLocalPtr 171483084 -> 171482642 -0.00%
  sccp.NumInstRemoved 1912762 -> 1912758 -0.00%

ab28ecc pre-commit: Update
52 52 bench/assimp/optimized/IFCReaderGen1_2x3.cpp.ll
29 29 bench/assimp/optimized/IFCReaderGen2_2x3.cpp.ll
430 434 bench/boost/optimized/buffer_gc.ll
216 218 bench/boost/optimized/buffer_variable_width.ll
434 438 bench/boost/optimized/difference_multi_areal_linear.ll
215 217 bench/boost/optimized/get_turn_info.ll
218 220 bench/boost/optimized/relate_linear_linear.ll
438 442 bench/boost/optimized/within_linear_linear.ll
4 4 bench/ceres/optimized/compressed_row_sparse_matrix.cc.ll
2 2 bench/duckdb/optimized/ub_duckdb_common_types.cpp.ll
8 8 bench/folly/optimized/LoggerDB.cpp.ll
5 2 bench/gromacs/optimized/coupling.cpp.ll
1 1 bench/hermes/optimized/DateUtil.cpp.ll
354 372 bench/meshlab/optimized/filter_create.cpp.ll
69 69 bench/meshlab/optimized/filter_func.cpp.ll
173 182 bench/meshlab/optimized/filter_icp.cpp.ll
176 185 bench/meshlab/optimized/filter_measure.cpp.ll
289 307 bench/meshlab/optimized/meshfilter.cpp.ll
14 14 bench/minetest/optimized/test_serialization.cpp.ll
5 5 bench/minetest/optimized/test_voxelmanipulator.cpp.ll
328 330 bench/mitsuba3/optimized/principledthin.cpp.ll
3 3 bench/nix/optimized/nix-store.ll
4 1 bench/openspiel/optimized/policy.cc.ll
40 40 bench/proj/optimized/coordinateoperationfactory.cpp.ll
6 6 bench/proj/optimized/factory.cpp.ll
308 320 bench/stat-rs/optimized/rkxxfn3f5mhspne.ll
1 3 bench/typst-rs/optimized/d6l9ieo9tcw33dn.ll

@dtcxzyw dtcxzyw closed this Dec 2, 2024
@dtcxzyw dtcxzyw deleted the test-run12113607709 branch January 9, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant