-
Notifications
You must be signed in to change notification settings - Fork 8
pre-commit: PR118257 #1783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pre-commit: PR118257 #1783
Conversation
|
runner: buildkitsandbox 127 files changed, 27642 insertions(+), 28233 deletions(-) af4aff9 pre-commit: Update |
| %cmp.i2.sink.i.i1748 = fcmp olt float %retval.sroa.0.0.i1765, %add.i1752 | ||
| %or.cond.i.i1745 = fcmp ord float %add.i1752, 0.000000e+00 | ||
| %cmp.i.i.i1747 = fcmp olt float %retval.sroa.0.0.i1765, %add.i1752 | ||
| %cmp.i2.sink.i.i1748 = select i1 %or.cond.i.i1745, i1 %cmp.i.i.i1747, i1 false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cannot reproduce it with 22417ec6cca0ed8ccecb0c2b77011e591378fd2a.
Looks like it doesn't matter: https://godbolt.org/z/qxcxKh6eM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-i128:128-f80:128-n8:16:32:64-S128"
target triple = "x86_64-unknown-linux-gnu"
%"struct.facebook::yoga::FloatOptional" = type { float }
declare i1 @_ZN8facebook4yoga4Node21styleDefinesDimensionENS0_13FlexDirectionEf()
define i1 @_ZNK8facebook4yoga13FloatOptional9isDefinedEv(ptr %this) {
entry:
%0 = load float, ptr %this, align 4
%call = call i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %0)
ret i1 %call
}
define i1 @_ZN8facebook4yoga11isUndefinedITkSt14floating_pointfEEbT_(float %value) {
entry:
%cmp = fcmp uno float %value, 0.000000e+00
ret i1 %cmp
}
define i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %value) {
entry:
%call = call i1 @_ZN8facebook4yoga11isUndefinedITkSt14floating_pointfEEbT_(float %value)
%lnot = xor i1 %call, true
ret i1 %lnot
}
define float @_ZN8facebook4yoga12maxOrDefinedITkSt14floating_pointfTkSt14floating_pointfEEDaT_T0_(float %a, float noundef %b) {
entry:
%a.addr111 = alloca [0 x [0 x [0 x float]]], i32 0, align 4
%b.addr = alloca float, align 4
store float %a, ptr %a.addr111, align 4
store float %b, ptr %b.addr, align 4
%call = call i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %a)
br i1 %call, label %land.lhs.true, label %if.end
land.lhs.true: ; preds = %entry
%call1 = call i1 @_ZN8facebook4yoga9isDefinedITkSt14floating_pointfEEbT_(float %b)
br i1 %call1, label %if.then, label %if.end
if.then: ; preds = %land.lhs.true
%call2 = call ptr @_ZSt3maxIfERKT_S2_S2_(ptr %a.addr111, ptr %b.addr)
%0 = load float, ptr %call2, align 4
br label %return
if.end: ; preds = %land.lhs.true, %entry
%call3 = call i1 @_ZN8facebook4yoga11isUndefinedITkSt14floating_pointfEEbT_(float %a)
%cond = select i1 %call3, float 0.000000e+00, float %a
br label %return
return: ; preds = %if.end, %if.then
%retval.0 = phi float [ %0, %if.then ], [ %cond, %if.end ]
ret float %retval.0
}
define void @_ZN8facebook4yogaL24computeFlexBasisForChildEPKNS0_4NodeEPS1_fNS0_10SizingModeEfffS5_NS0_9DirectionERNS0_10LayoutDataEjj(float %width, float %call10, i1 %call33) {
entry:
%resolvedFlexBasis111 = alloca [0 x [0 x [0 x %"struct.facebook::yoga::FloatOptional"]]], i32 0, align 4
store float %call10, ptr %resolvedFlexBasis111, align 4
%call11 = call i1 @_ZN8facebook4yoga4Node21styleDefinesDimensionENS0_13FlexDirectionEf()
%call15 = call i1 @_ZNK8facebook4yoga13FloatOptional9isDefinedEv(ptr %resolvedFlexBasis111)
%call15.not = xor i1 %call15, true
%brmerge = select i1 %call15.not, i1 true, i1 %call33
br i1 %brmerge, label %common.ret, label %if.then
common.ret: ; preds = %if.then, %entry
ret void
if.then: ; preds = %entry
%call30 = call float @_ZN8facebook4yoga12maxOrDefinedENS0_13FloatOptionalES1_(float %call10, float %width)
store volatile float %call30, ptr null, align 4
br label %common.ret
}
define float @_ZN8facebook4yoga12maxOrDefinedENS0_13FloatOptionalES1_(float %lhs.coerce, float %rhs.coerce) {
entry:
%call3 = call float @_ZN8facebook4yoga12maxOrDefinedITkSt14floating_pointfTkSt14floating_pointfEEDaT_T0_(float %lhs.coerce, float %rhs.coerce)
ret float %call3
}
define ptr @_ZSt3maxIfERKT_S2_S2_(ptr %__a, ptr %__b) {
entry:
%0 = load float, ptr %__a, align 4
%1 = load float, ptr %__b, align 4
%cmp = fcmp olt float %0, %1
%__b.__a = select i1 %cmp, ptr %__b, ptr %__a
ret ptr %__b.__a
}
|
/add-label reviewed,regression |
|
/close |
|
runner: buildkitsandbox 83 files changed, 24162 insertions(+), 24586 deletions(-) ab28ecc pre-commit: Update |
Link: llvm/llvm-project#118257
Requested by: @dtcxzyw