-
Notifications
You must be signed in to change notification settings - Fork 296
layoutOptions.storage.removeItem not called #180
Copy link
Copy link
Open
Description
Current behavior:
- Click 'x' to remove layout
removeLayout(layout)is called, thenlayoutStorage.remove(layout)is called- We delete
this.states[layout.id] layoutStorage.save()is called, thenthis.storage.setItem
Expected behavior:
After deleting the layout from states, I'd expect this.storage.removeItem() to be called, though I'm not really sure what the intended behavior of that method is other than to handle mismatched hashes.
Using anything other than localStorage, and storing layouts individually, it becomes a pain to detect when a layout was removed, since at present it calls this.storage.setItem as any other change would. Further, it doesn't seem that removeItem is ever realistically called when using dashboard-layouts.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels